walterddr commented on code in PR #10792:
URL: https://github.com/apache/pinot/pull/10792#discussion_r1206988449
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java:
##########
@@ -91,4 +94,11 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(_resolutions);
}
+
+ public static class ToIntListConverted extends
StdConverter<H3IndexResolution, List<Integer>> {
Review Comment:
do we need the list format? as both are not human readable eitherway.
keeping it as short is good IMO.
as long as we can construct this from list or short we should be fine right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
