[pinot] branch master updated (61d6b1075d -> cb607a8594)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 61d6b1075d Minor Pinot Deepstore Upload Retry Task Improvements (#10752) add cb607a8594 Track Number of Segments

[GitHub] [pinot] yupeng9 merged pull request #10780: Track Number of Segments Fixed by Deepstore Retry Task

yupeng9 merged PR #10780: URL: https://github.com/apache/pinot/pull/10780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] walterddr commented on pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

walterddr commented on PR #10772: URL: https://github.com/apache/pinot/pull/10772#issuecomment-1552328942 > syntax for hints seems a bit verbose.. can we follow spark or postgres model > > https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-hints.html There will alwa

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197274563 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -526,6 +529,32 @@ private void handleUpsert(ImmutableSegme

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197273114 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -526,6 +529,32 @@ private void handleUpsert(ImmutableSegme

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197272216 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -526,6 +529,32 @@ private void handleUpsert(ImmutableSegme

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197270563 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -526,6 +529,32 @@ private void handleUpsert(ImmutableSegme

[GitHub] [pinot] codecov-commenter commented on pull request #10780: Track Number of Segments Fixed by Deepstore Retry Task

codecov-commenter commented on PR #10780: URL: https://github.com/apache/pinot/pull/10780#issuecomment-1552303500 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10780?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] ankitsultana closed pull request #10780: Track Number of Segments Fixed by Deepstore Retry Task

ankitsultana closed pull request #10780: Track Number of Segments Fixed by Deepstore Retry Task URL: https://github.com/apache/pinot/pull/10780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pinot] codecov-commenter commented on pull request #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

codecov-commenter commented on PR #10779: URL: https://github.com/apache/pinot/pull/10779#issuecomment-1552287266 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jackjlli commented on a diff in pull request #10777: Introduce a metric to count individual segment fetch failures.

jackjlli commented on code in PR #10777: URL: https://github.com/apache/pinot/pull/10777#discussion_r1197235975 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -628,9 +628,15 @@ private File downloadAndStreamUntarWithRateLimit(Stri

[GitHub] [pinot] ankitsultana opened a new pull request, #10780: Track Number of Segments Fixed by Deepstore Retry Task

ankitsultana opened a new pull request, #10780: URL: https://github.com/apache/pinot/pull/10780 Missed this in: https://github.com/apache/pinot/pull/10752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] jackjlli commented on a diff in pull request #10754: Keep last completed segments for retention

jackjlli commented on code in PR #10754: URL: https://github.com/apache/pinot/pull/10754#discussion_r1197228815 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -872,6 +874,24 @@ public List getSegmentsZKMetadata(Str

[GitHub] [pinot] walterddr opened a new pull request, #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

walterddr opened a new pull request, #10779: URL: https://github.com/apache/pinot/pull/10779 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197215241 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -181,6 +203,60 @@ protected void rem

[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

chenboat commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1197213067 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -395,6 +399,31 @@ protected void finishOperat

[pinot] branch master updated: Minor Pinot Deepstore Upload Retry Task Improvements (#10752)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 61d6b1075d Minor Pinot Deepstore Upload Retry T

[GitHub] [pinot] chenboat merged pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

chenboat merged PR #10752: URL: https://github.com/apache/pinot/pull/10752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] chenboat closed issue #10751: Deepstore Upload Retry Task Uploads Segments to Paths Ending with UUID

chenboat closed issue #10751: Deepstore Upload Retry Task Uploads Segments to Paths Ending with UUID URL: https://github.com/apache/pinot/issues/10751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pinot] navina commented on pull request #10777: Introduce a metric to count individual segment fetch failures.

navina commented on PR #10777: URL: https://github.com/apache/pinot/pull/10777#issuecomment-1552206271 btw, which metric are you trying to re-define? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] navina commented on a diff in pull request #10777: Introduce a metric to count individual segment fetch failures.

navina commented on code in PR #10777: URL: https://github.com/apache/pinot/pull/10777#discussion_r1197155941 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java: ## @@ -70,6 +70,7 @@ public enum ServerMeter implements AbstractMetrics.Meter { REFRES

[GitHub] [pinot] navina commented on a diff in pull request #10777: Introduce a metric to count individual segment fetch failures.

navina commented on code in PR #10777: URL: https://github.com/apache/pinot/pull/10777#discussion_r1197154934 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -628,9 +628,15 @@ private File downloadAndStreamUntarWithRateLimit(String

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10778: update pinot helm readme

zhtaoxiang opened a new pull request, #10778: URL: https://github.com/apache/pinot/pull/10778 update pinot helm readme to explain how to create EKS cluster for Pinot with k8s 1.23+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[pinot] branch master updated: Add decoder initialization error to the server's error cache (#10773)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ab0c27e947 Add decoder initialization error to the

[GitHub] [pinot] walterddr merged pull request #10773: Add decoder initialization error to the server's error cache

walterddr merged PR #10773: URL: https://github.com/apache/pinot/pull/10773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] kishoreg commented on pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

kishoreg commented on PR #10772: URL: https://github.com/apache/pinot/pull/10772#issuecomment-1552154190 syntax for hints seems a bit verbose.. can we follow spark or postgres model https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-hints.html -- This is an automated mes

[GitHub] [pinot] cbalci commented on pull request #10643: Add PercentileKLL aggregation function

cbalci commented on PR #10643: URL: https://github.com/apache/pinot/pull/10643#issuecomment-1552143192 @navina, not yet. I'll add it to OSS documentation soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pinot] codecov-commenter commented on pull request #10777: Introduce a metric to count individual segment fetch failures.

codecov-commenter commented on PR #10777: URL: https://github.com/apache/pinot/pull/10777#issuecomment-1552127228 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10777?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jtao15 commented on a diff in pull request #10777: Introduce a metric to count individual segment fetch failures.

jtao15 commented on code in PR #10777: URL: https://github.com/apache/pinot/pull/10777#discussion_r1197073484 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -628,9 +628,15 @@ private File downloadAndStreamUntarWithRateLimit(String

[GitHub] [pinot] navina commented on pull request #10643: Add PercentileKLL aggregation function

navina commented on PR #10643: URL: https://github.com/apache/pinot/pull/10643#issuecomment-1552087310 @cbalci / @chenboat : has this feature been documented ? is it available in the OSS docs? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] jugomezv opened a new pull request, #10777: Introduce a metric to count individual segment fetch failures.

jugomezv opened a new pull request, #10777: URL: https://github.com/apache/pinot/pull/10777 Current metric for failures ticks only after 3 consecutive failures and that almost never happens, I am introducing a new metric so we can track individual failures in segment fetcher. -- This

[GitHub] [pinot] walterddr commented on a diff in pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

walterddr commented on code in PR #10772: URL: https://github.com/apache/pinot/pull/10772#discussion_r1197007479 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java: ## @@ -88,8 +92,11 @@ public boolean matches(RelOptRuleCa

[GitHub] [pinot] walterddr commented on a diff in pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

walterddr commented on code in PR #10772: URL: https://github.com/apache/pinot/pull/10772#discussion_r1197005806 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintOptions.java: ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] walterddr commented on a diff in pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

walterddr commented on code in PR #10772: URL: https://github.com/apache/pinot/pull/10772#discussion_r1197005806 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintOptions.java: ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] codecov-commenter commented on pull request #10776: upgrade guava version to 30.1.1-jre for CVE fixes

codecov-commenter commented on PR #10776: URL: https://github.com/apache/pinot/pull/10776#issuecomment-1551968008 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10776?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] branch master updated (59599872fb -> 4f15641379)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 59599872fb [multistage]: Added support for Json Data Type. (#10765) add 4f15641379 [multistage] mailbox sending exc

[GitHub] [pinot] walterddr merged pull request #10761: [multistage] sending exchange service

walterddr merged PR #10761: URL: https://github.com/apache/pinot/pull/10761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

xiangfu0 commented on code in PR #10772: URL: https://github.com/apache/pinot/pull/10772#discussion_r1196907567 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintOptions.java: ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [pinot] klsince commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

klsince commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1196924108 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1555,4 +1562,19 @@ public PauseStatus getP

[GitHub] [pinot] navina commented on a diff in pull request #10773: Add decoder initialization error to the server's error cache

navina commented on code in PR #10773: URL: https://github.com/apache/pinot/pull/10773#discussion_r1196908534 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1419,8 +1419,15 @@ public LLRealtimeSegmentDataManager(

[GitHub] [pinot] xiangfu0 opened a new pull request, #10776: upgrade guava version to 30.1.1-jre for CVE fixes

xiangfu0 opened a new pull request, #10776: URL: https://github.com/apache/pinot/pull/10776 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6

[GitHub] [pinot] walterddr commented on a diff in pull request #10773: Add decoder initialization error to the server's error cache

walterddr commented on code in PR #10773: URL: https://github.com/apache/pinot/pull/10773#discussion_r1196898970 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1419,8 +1419,15 @@ public LLRealtimeSegmentDataManag

[GitHub] [pinot] walterddr commented on a diff in pull request #10773: Add decoder initialization error to the server's error cache

walterddr commented on code in PR #10773: URL: https://github.com/apache/pinot/pull/10773#discussion_r1196898970 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1419,8 +1419,15 @@ public LLRealtimeSegmentDataManag

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

ankitsultana commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1196894903 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1555,4 +1562,19 @@ public PauseStatus

[GitHub] [pinot] navina commented on a diff in pull request #10773: Add decoder initialization error to the server's error cache

navina commented on code in PR #10773: URL: https://github.com/apache/pinot/pull/10773#discussion_r1196883043 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1419,8 +1419,15 @@ public LLRealtimeSegmentDataManager(

[GitHub] [pinot] xiangfu0 opened a new pull request, #10775: update libtasn1 lib to fix CVE-2022-1471

xiangfu0 opened a new pull request, #10775: URL: https://github.com/apache/pinot/pull/10775 update libtasn1 lib to fix CVE-2022-1471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] jtao15 commented on a diff in pull request #10754: Keep last completed segments for retention

jtao15 commented on code in PR #10754: URL: https://github.com/apache/pinot/pull/10754#discussion_r1196876283 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/retention/RetentionManagerTest.java: ## @@ -233,6 +233,39 @@ public void testRealtimeLLCCleanup(

[GitHub] [pinot] klsince commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

klsince commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1196870494 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1555,4 +1562,19 @@ public PauseStatus getP

[GitHub] [pinot] walterddr commented on a diff in pull request #10773: Add decoder initialization error to the server's error cache

walterddr commented on code in PR #10773: URL: https://github.com/apache/pinot/pull/10773#discussion_r1196823821 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1419,8 +1419,15 @@ public LLRealtimeSegmentDataManag

[GitHub] [pinot] soumitra-st commented on pull request #10773: Add decoder initialization error to the server's error cache

soumitra-st commented on PR #10773: URL: https://github.com/apache/pinot/pull/10773#issuecomment-1551738351 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [pinot] navina commented on pull request #10773: Add decoder initialization error to the server's error cache

navina commented on PR #10773: URL: https://github.com/apache/pinot/pull/10773#issuecomment-1551730973 @npawar / @Jackie-Jiang / @mayankshriv : review pls! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] GSharayu commented on pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

GSharayu commented on PR #10759: URL: https://github.com/apache/pinot/pull/10759#issuecomment-1551708417 @snleee Can you also please take a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pinot] branch master updated: [multistage]: Added support for Json Data Type. (#10765)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 59599872fb [multistage]: Added support for Json Da

[GitHub] [pinot] walterddr merged pull request #10765: [multistage]: Added support for Json Data Type.

walterddr merged PR #10765: URL: https://github.com/apache/pinot/pull/10765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] walterddr commented on pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

walterddr commented on PR #10772: URL: https://github.com/apache/pinot/pull/10772#issuecomment-1551517227 CC - @vvivekiyer and @somandal who visited the hintable framework previously on aggregate and window functions - @ankitsultana for the colocated options. -- This is an automate

[GitHub] [pinot] gortiz opened a new pull request, #10774: Always use LArray buffer in order to verify a bug

gortiz opened a new pull request, #10774: URL: https://github.com/apache/pinot/pull/10774 This PR tries to reproduce a bug detected in LArray implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196363274 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProp

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196363274 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProp

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196363274 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProp

[GitHub] [pinot] gortiz commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

gortiz commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196344690 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProperty(v

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196314940 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProp

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196314940 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProp

[GitHub] [pinot] gortiz commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

gortiz commented on code in PR #10759: URL: https://github.com/apache/pinot/pull/10759#discussion_r1196145111 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java: ## @@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProperty(v

[GitHub] [pinot] gortiz commented on pull request #10687: Implement mutable index using index SPI

gortiz commented on PR #10687: URL: https://github.com/apache/pinot/pull/10687#issuecomment-1550966001 > I think all the confusion from the reviewers stemmed from the fact that the boundaries got blurred in one case but we're calling out separation in another case. I understand the c