chenboat commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1197215241
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -181,6 +203,60 @@ protected void removeSegment(IndexSegment segment,
MutableRoaringBitmap validDoc
}
}
+ /**
+ * When TTL is enabled for upsert, this function is used to remove expired
keys from the primary key indexes.
+ *
+ * When committing consuming segment, we replace the consuming segment with
an immutable segments.
+ * After replaceSegment, we iterate over recordInfoIterator to find
validDocIds that are expired (out-of-TTL).
+ * Primarykey expired when the comparison time value of the record is less
or equal to (segmentEndTime - TTL).
Review Comment:
what is segmentEndTime? why use it instead of the current system time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
