jtao15 commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1197073484
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -628,9 +628,15 @@ private File downloadAndStreamUntarWithRateLimit(String
segmentName, SegmentZKMe
maxStreamRateInByte);
String uri = zkMetadata.getDownloadUrl();
try {
- File ret = SegmentFetcherFactory.fetchAndStreamUntarToLocal(uri,
tempRootDir, maxStreamRateInByte);
- LOGGER.info("Download and untarred segment: {} for table: {} from: {}",
segmentName, _tableNameWithType, uri);
- return ret;
+ try {
+ File ret = SegmentFetcherFactory.fetchAndStreamUntarToLocal(uri,
tempRootDir, maxStreamRateInByte);
+ LOGGER.info("Download and untarred segment: {} for table: {} from:
{}", segmentName, _tableNameWithType, uri);
+ return ret;
+ } catch (Exception e) {
+ _serverMetrics.addMeteredTableValue(_tableNameWithType,
+ ServerMeter.SEGMENT_TOTAL_STREAMED_DOWNLOAD_UNTAR_FAILURES, 1L);
Review Comment:
IMO, it's better to reuse the old metric and mark this pr as an incompatible
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
