[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #10754: Keep last completed segments for retention

2023-05-16 Thread via GitHub
sajjad-moradi commented on code in PR #10754: URL: https://github.com/apache/pinot/pull/10754#discussion_r1195998765 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/retention/RetentionManagerTest.java: ## @@ -233,6 +233,39 @@ public void testRealtimeLLCC

[GitHub] [pinot] codecov-commenter commented on pull request #10773: Add decoder initialization error to the server's error cache

2023-05-16 Thread via GitHub
codecov-commenter commented on PR #10773: URL: https://github.com/apache/pinot/pull/10773#issuecomment-1550791710 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] navina commented on issue #10717: can't add schema using Pinot UI, always get the error " HTTP 415 Unsupported Media Type "

2023-05-16 Thread via GitHub
navina commented on issue #10717: URL: https://github.com/apache/pinot/issues/10717#issuecomment-1550770810 @thatran which pinot version did you try? I am able to add the schema using the UI and don't see any error about unsupported media type. -- This is an automated message from the Ap

[GitHub] [pinot] navina opened a new pull request, #10773: Add decoder initialization error to the server's error cache

2023-05-16 Thread via GitHub
navina opened a new pull request, #10773: URL: https://github.com/apache/pinot/pull/10773 Add decoder initialization error to server's error cache so that it can show up in the server's debug API. A follow-up can be to surface this error in the UI itself. -- This is an automated

[GitHub] [pinot] codecov-commenter commented on pull request #10772: [multistage] hintable option framework & dynamic broadcast hint

2023-05-16 Thread via GitHub
codecov-commenter commented on PR #10772: URL: https://github.com/apache/pinot/pull/10772#issuecomment-1550670580 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr opened a new pull request, #10772: [multistage]hintable option framework & dynamic broadcast hint

2023-05-16 Thread via GitHub
walterddr opened a new pull request, #10772: URL: https://github.com/apache/pinot/pull/10772 Details === - add hintable option framework - indicates the hint applicable node (`aggOptions`, `joinOptions` are added for now) - each hint support arbitrary k-v options (e.g. `join

[GitHub] [pinot] codecov-commenter commented on pull request #10771: Enable case insensitivity by default

2023-05-16 Thread via GitHub
codecov-commenter commented on PR #10771: URL: https://github.com/apache/pinot/pull/10771#issuecomment-1550621694 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10765: [multistage]: Added support for Json Data Type.

2023-05-16 Thread via GitHub
abhioncbr commented on code in PR #10765: URL: https://github.com/apache/pinot/pull/10765#discussion_r1195857950 ## pinot-query-runtime/src/test/resources/queries/JsonType.json: ## @@ -0,0 +1,41 @@ +{ + "json_data": { +"tables": { + "jsonTbl": { +"schema": [ +

[GitHub] [pinot] abhioncbr commented on pull request #10771: Enable case insensitivity by default

2023-05-16 Thread via GitHub
abhioncbr commented on PR #10771: URL: https://github.com/apache/pinot/pull/10771#issuecomment-1550598880 I think this change will resolce this [issue](https://github.com/apache/pinot/issues/10734) as well. Thanks -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] soumitra-st opened a new pull request, #10771: Enable case insensitivity by default

2023-05-16 Thread via GitHub
soumitra-st opened a new pull request, #10771: URL: https://github.com/apache/pinot/pull/10771 This PR changes the default value of enable.case.insensitive configuration to true to make Pinot case insensitive by default. ## Old data in Pinot cluster - case insensitive query fails h

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10765: [multistage]: Added support for Json Data Type.

2023-05-16 Thread via GitHub
abhioncbr commented on code in PR #10765: URL: https://github.com/apache/pinot/pull/10765#discussion_r1195857950 ## pinot-query-runtime/src/test/resources/queries/JsonType.json: ## @@ -0,0 +1,41 @@ +{ + "json_data": { +"tables": { + "jsonTbl": { +"schema": [ +

[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

2023-05-16 Thread via GitHub
chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195840785 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1404,6 +1405,8 @@ public void uploadToDee

[GitHub] [pinot] INNOCENT-BOY commented on pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

2023-05-16 Thread via GitHub
INNOCENT-BOY commented on PR #10759: URL: https://github.com/apache/pinot/pull/10759#issuecomment-1550568118 I think this is a very important Bugfix if you want to use separate segmentAssignStrategy for completed segment of Realtime Table. Because we can't turn on this feature if we won't m

[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

2023-05-16 Thread via GitHub
chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195835315 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java: ## @@ -25,5 +25,15 @@ public interface SegmentUploader { // Returns

[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

2023-05-16 Thread via GitHub
chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195835315 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java: ## @@ -25,5 +25,15 @@ public interface SegmentUploader { // Returns

[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

2023-05-16 Thread via GitHub
chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195834151 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -527,7 +529,12 @@ public String uploadLLCSegment( // Use segmen

[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

2023-05-16 Thread via GitHub
chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195833919 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -468,7 +468,8 @@ public Response downloadValidDocIds( * Upload a low

[pinot] branch master updated: [feature] [null support # 9] Support null in time related transform functions. (#10598)

2023-05-16 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 12d86902a8 [feature] [null support # 9] Support

[GitHub] [pinot] xiangfu0 merged pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

2023-05-16 Thread via GitHub
xiangfu0 merged PR #10598: URL: https://github.com/apache/pinot/pull/10598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] walterddr commented on issue #10701: TableName extraction fails for tables with name pattern as `db.tablename` in CalciteSqlParser

2023-05-16 Thread via GitHub
walterddr commented on issue #10701: URL: https://github.com/apache/pinot/issues/10701#issuecomment-1550490765 - I don't think so at this moment. we can continue discussion this thread on how to support catalog going forward. - I couldn't find a single reference to `db.tbl` or `catalog.t

[pinot] branch master updated: Add PercentileKLL aggregation function (#10643)

2023-05-16 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 41fbb32846 Add PercentileKLL aggregation functi

[GitHub] [pinot] chenboat merged pull request #10643: Add PercentileKLL aggregation function

2023-05-16 Thread via GitHub
chenboat merged PR #10643: URL: https://github.com/apache/pinot/pull/10643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] shenyu0127 commented on pull request #10650: [bugfix] fix floating point and integral type backward incompatible issue

2023-05-16 Thread via GitHub
shenyu0127 commented on PR #10650: URL: https://github.com/apache/pinot/pull/10650#issuecomment-1550448591 > > 1. Before [1], the behavior was: a thrift (long, 1) -> a literal (long, 1) -> a literal transform function (int, 1) > > 2. After [1], the behavior is: a thrift (long, 1) -> a lit

[GitHub] [pinot] navina commented on issue #10701: TableName extraction fails for tables with name pattern as `db.tablename` in CalciteSqlParser

2023-05-16 Thread via GitHub
navina commented on issue #10701: URL: https://github.com/apache/pinot/issues/10701#issuecomment-1550404908 @walterddr : is there an action item on this issue? follow-up question: Have we already documented the rules / requirements for a pinot table resource somewhere? -- This is

[GitHub] [pinot] walterddr commented on a diff in pull request #10761: [multistage] sending exchange service

2023-05-16 Thread via GitHub
walterddr commented on code in PR #10761: URL: https://github.com/apache/pinot/pull/10761#discussion_r1195553191 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -118,6 +122,7 @@ public void init(PinotConfiguration config, InstanceData

[GitHub] [pinot] walterddr commented on a diff in pull request #10756: Refactor usage of WorkerMetadata and StageMetadata

2023-05-16 Thread via GitHub
walterddr commented on code in PR #10756: URL: https://github.com/apache/pinot/pull/10756#discussion_r1195433083 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -212,7 +212,8 @@ public static DistributedStagePlan construc

[GitHub] [pinot] walterddr commented on a diff in pull request #10756: Refactor usage of WorkerMetadata and StageMetadata

2023-05-16 Thread via GitHub
walterddr commented on code in PR #10756: URL: https://github.com/apache/pinot/pull/10756#discussion_r1195430392 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -212,7 +212,8 @@ public static DistributedStagePlan construc

[GitHub] [pinot] walterddr commented on a diff in pull request #10765: [multistage]: Added support for Json Data Type.

2023-05-16 Thread via GitHub
walterddr commented on code in PR #10765: URL: https://github.com/apache/pinot/pull/10765#discussion_r1195307453 ## pinot-query-runtime/src/test/resources/queries/JsonType.json: ## @@ -0,0 +1,41 @@ +{ + "json_data": { +"tables": { + "jsonTbl": { +"schema": [ +

[GitHub] [pinot] walterddr commented on a diff in pull request #10765: [multistage]: Added support for Json Data Type.

2023-05-16 Thread via GitHub
walterddr commented on code in PR #10765: URL: https://github.com/apache/pinot/pull/10765#discussion_r1195307453 ## pinot-query-runtime/src/test/resources/queries/JsonType.json: ## @@ -0,0 +1,41 @@ +{ + "json_data": { +"tables": { + "jsonTbl": { +"schema": [ +

[GitHub] [pinot] spareslant commented on issue #10747: Basic Auth not working for other users

2023-05-16 Thread via GitHub
spareslant commented on issue #10747: URL: https://github.com/apache/pinot/issues/10747#issuecomment-1549824138 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pinot] codecov-commenter commented on pull request #10770: UI: fix sql query options seperator

2023-05-16 Thread via GitHub
codecov-commenter commented on PR #10770: URL: https://github.com/apache/pinot/pull/10770#issuecomment-1549424374 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jayeshchoudhary opened a new pull request, #10770: UI: fix sql query options seperator

2023-05-16 Thread via GitHub
jayeshchoudhary opened a new pull request, #10770: URL: https://github.com/apache/pinot/pull/10770 This PR is `ui` `bugfix` ### Issue - In the SQL editor If there were multiple query options, then queryOptions passed to payload were incorrect. - Backend expects `;` as a separato

[GitHub] [pinot] rahul8383 closed issue #10769: Remove Primary Key from Upsert Metadata when a Segment is removed

2023-05-16 Thread via GitHub
rahul8383 closed issue #10769: Remove Primary Key from Upsert Metadata when a Segment is removed URL: https://github.com/apache/pinot/issues/10769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] rahul8383 commented on issue #10769: Remove Primary Key from Upsert Metadata when a Segment is removed

2023-05-16 Thread via GitHub
rahul8383 commented on issue #10769: URL: https://github.com/apache/pinot/issues/10769#issuecomment-1549104334 Tested that ConcurrentHashMap.computeIfPresent() removes the key when null is returned in the BiFunction. This is not an issue. Closing the ticket. -- This is an automated mes