chenboat commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1195835315
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java: ########## @@ -25,5 +25,15 @@ public interface SegmentUploader { // Returns the URI of the uploaded segment. null if the upload fails. + + /** + * Uploads the given segmentFile to the deep-store. The upload to deep-store involve calling another Pinot component. + */ Review Comment: Can you combine the javadoc in line 27 in the new comment too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org