chenboat commented on code in PR #10752:
URL: https://github.com/apache/pinot/pull/10752#discussion_r1195834151
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -527,7 +529,12 @@ public String uploadLLCSegment(
// Use segment uploader to upload the segment tar file to segment store
and return the segment download url.
SegmentUploader segmentUploader =
_serverInstance.getInstanceDataManager().getSegmentUploader();
- URI segmentDownloadUrl = segmentUploader.uploadSegment(segmentTarFile,
new LLCSegmentName(segmentName));
+ URI segmentDownloadUrl;
+ if (timeoutMs <= 0) {
Review Comment:
javadoc to explain the difference here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
