[GitHub] [pinot] gortiz commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

gortiz commented on PR #10352: URL: https://github.com/apache/pinot/pull/10352#issuecomment-1449501930 > Trying to understand why making the IndexLoadingConfig fields immutable can help here. The fields within IndexLoadingConfig is already a copy of the original config, so it should be okay

[GitHub] [pinot] swaminathanmanish opened a new pull request, #10359: (WIP....DRAFT] Rebalance API changes

swaminathanmanish opened a new pull request, #10359: URL: https://github.com/apache/pinot/pull/10359 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat

[GitHub] [pinot] siddharthteotia commented on pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

siddharthteotia commented on PR #10286: URL: https://github.com/apache/pinot/pull/10286#issuecomment-1449377238 Will be reviewing this today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pinot] codecov-commenter commented on pull request #10358: Clean up the Block APIs and introduce RowBlock

codecov-commenter commented on PR #10358: URL: https://github.com/apache/pinot/pull/10358#issuecomment-1449280216 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10358: Clean up the Block APIs and introduce RowBlock

Jackie-Jiang opened a new pull request, #10358: URL: https://github.com/apache/pinot/pull/10358 Make `Block` a placeholder class as the result for `Operator` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pinot] codecov-commenter commented on pull request #10348: [bugfix] Fix bug with PERCENT_SEGMENTS_AVAILABLE metric rounding down

codecov-commenter commented on PR #10348: URL: https://github.com/apache/pinot/pull/10348#issuecomment-1449237864 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1121006314 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java: ## @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [pinot] aidar-st commented on pull request #10348: [bugfix] Fix bug with PERCENT_SEGMENTS_AVAILABLE metric rounding down

aidar-st commented on PR #10348: URL: https://github.com/apache/pinot/pull/10348#issuecomment-1449178243 > Good catch. Can you take a look at the test failures? I'm not quite sure why some tests end up failing, it's also different set of tests that fail when I run maven locally. Let's

[GitHub] [pinot] aidar-st commented on a diff in pull request #10348: [bugfix] Fix bug with PERCENT_SEGMENTS_AVAILABLE metric rounding down

aidar-st commented on code in PR #10348: URL: https://github.com/apache/pinot/pull/10348#discussion_r1121003259 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java: ## @@ -298,7 +298,7 @@ private void updateSegmentMetrics(String tableNam

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

Jackie-Jiang commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120998078 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,40 @@ private RecordInfo getRe

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120988051 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,40 @@ private RecordInfo getRecordI

[GitHub] [pinot] codecov-commenter commented on pull request #10357: Enhance select order-by combine to use merge sort

codecov-commenter commented on PR #10357: URL: https://github.com/apache/pinot/pull/10357#issuecomment-1449137938 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] codecov-commenter commented on pull request #10356: Fixes mixup of getRight/getLeft resulting in many non-filter aggs

codecov-commenter commented on PR #10356: URL: https://github.com/apache/pinot/pull/10356#issuecomment-1449137087 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

Jackie-Jiang commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120935766 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,40 @@ private RecordInfo getRe

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10357: Enhance select order-by combine to use merge sort

Jackie-Jiang opened a new pull request, #10357: URL: https://github.com/apache/pinot/pull/10357 Currently for selection order-by queries, when combining multiple segment results, we maintain a heap (PriorityQueue) of the top values, which has time complexity of O(nlogm) where n is the total

[GitHub] [pinot] egalpin opened a new pull request, #10356: Fixes mixup of getRight/getLeft resulting in many non-filter aggs

egalpin opened a new pull request, #10356: URL: https://github.com/apache/pinot/pull/10356 WIP - working on performance of FILTER expressions for aggregations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[pinot] branch master updated (135f13e323 -> 246f4db352)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 135f13e323 Adding setter to DeletedSegmentsRetentionPeriod in TableConfigBuilder (#10351) add 246f4db352 [multista

[GitHub] [pinot] walterddr merged pull request #10332: [multistage] Dispatch Query Plan in Parallel

walterddr merged PR #10332: URL: https://github.com/apache/pinot/pull/10332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] Jackie-Jiang commented on issue #10342: Segment Reload Unable to Fix Segment in Error State

Jackie-Jiang commented on issue #10342: URL: https://github.com/apache/pinot/issues/10342#issuecomment-1449088044 > @Jackie-Jiang : Any concerns in making the zk call? We actually make a zk call anyways to get the metadata in `reloadSegmentWithMetadata` if the segment is not a mutable one.

[GitHub] [pinot] vvivekiyer commented on issue #10318: [multistage] Return type for AVG() aggregation function

vvivekiyer commented on issue #10318: URL: https://github.com/apache/pinot/issues/10318#issuecomment-1449070682 **POSTGRES: Numeric DataType and AVG Return Type** Postgres supports some variable size datatypes (where the number of digits before and after decimal point is fixed and can be

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10191: [Index SPI] IndexType

Jackie-Jiang commented on code in PR #10191: URL: https://github.com/apache/pinot/pull/10191#discussion_r1120876913 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/FieldIndexConfigs.java: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] deemoliu commented on pull request #10047: [WIP] Add upsert ttl configs for Pinot upsert optimizations

deemoliu commented on PR #10047: URL: https://github.com/apache/pinot/pull/10047#issuecomment-1449056733 > > Hi @Jackie-Jiang, thanks for the commit. Can you help understand this part? In my understanding, each partitionManager has its own PrimaryKeyToRecordLocation map. When committing a n

[GitHub] [pinot] deemoliu commented on issue #10353: On-demand API for backing up segments of offline table back to deepstore

deemoliu commented on issue #10353: URL: https://github.com/apache/pinot/issues/10353#issuecomment-1449049361 There is a uploadLLCSegment in the pinot server tablesResource. However to avoid consistency issue (two servers might try to upload at the same time), we might need to find a way

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120890410 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -154,10 +135,22 @@ public void setDefaultPartialUpsertStrategy(Strategy defaultPa

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120887829 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,39 @@ private RecordInfo getRecordI

[GitHub] [pinot] Jackie-Jiang commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

Jackie-Jiang commented on PR #10352: URL: https://github.com/apache/pinot/pull/10352#issuecomment-1449002253 Trying to understand why making the `IndexLoadingConfig` fields immutable can help here. The fields within `IndexLoadingConfig` is already a copy of the original config, so it should

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10355: Make IndexLoadingConfig directly read configs from TableConfig and Schema

Jackie-Jiang opened a new pull request, #10355: URL: https://github.com/apache/pinot/pull/10355 There are still some tests need to be modified to apply the change Use this PR to show the idea of how the `IndexLoadingConfig` should access the configs -- This is an automated message from

[GitHub] [pinot] ankitsultana commented on pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable

ankitsultana commented on PR #10005: URL: https://github.com/apache/pinot/pull/10005#issuecomment-1448986354 Let's follow-up on this offline as we have planned @walterddr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pinot] ankitsultana closed pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable

ankitsultana closed pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable URL: https://github.com/apache/pinot/pull/10005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pinot] branch master updated (8ddbd25e18 -> 135f13e323)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8ddbd25e18 Add min / max values to virtual column metadata to allow segment pruning (#10343) add 135f13e323 Addin

[GitHub] [pinot] Jackie-Jiang merged pull request #10351: [feature] Adding setter to DeletedSegmentsRetentionPeriod in TableConfigBuilder

Jackie-Jiang merged PR #10351: URL: https://github.com/apache/pinot/pull/10351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (ea6424e3d8 -> 8ddbd25e18)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ea6424e3d8 Show correct query plan when prefetch is enabled (#10172) add 8ddbd25e18 Add min / max values to virtua

[GitHub] [pinot] Jackie-Jiang merged pull request #10343: Add min / max values to virtual column metadata to allow segment pruning

Jackie-Jiang merged PR #10343: URL: https://github.com/apache/pinot/pull/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] talovicnedim closed issue #10200: Docker build fails

talovicnedim closed issue #10200: Docker build fails URL: https://github.com/apache/pinot/issues/10200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120731929 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,39 @@ private RecordInfo getRecordI

[pinot] branch master updated: Show correct query plan when prefetch is enabled (#10172)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ea6424e3d8 Show correct query plan when prefetch

[GitHub] [pinot] Jackie-Jiang merged pull request #10172: Show correct query plan when prefetch is enabled

Jackie-Jiang merged PR #10172: URL: https://github.com/apache/pinot/pull/10172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120717264 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java: ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundat

[pinot] branch master updated: [multistage] Use Different Thread Pool for QueryServer (#10349)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 733cc2fa6b [multistage] Use Different Thread Pool

[GitHub] [pinot] walterddr merged pull request #10349: [multistage] Use Different Thread Pool for QueryServer

walterddr merged PR #10349: URL: https://github.com/apache/pinot/pull/10349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] gortiz commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

gortiz commented on PR #10352: URL: https://github.com/apache/pinot/pull/10352#issuecomment-1448739077 I will try to fix the integration test that is failing tomorrow morning (eu time). I think I already solve that issue in index-spi -- This is an automated message from the Apache Git Ser

[GitHub] [pinot] codecov-commenter commented on pull request #10354: [Test][DoNotReivew] try reverting grpc

codecov-commenter commented on PR #10354: URL: https://github.com/apache/pinot/pull/10354#issuecomment-1448738304 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] ankitsultana commented on issue #10342: Segment Reload Unable to Fix Segment in Error State

ankitsultana commented on issue #10342: URL: https://github.com/apache/pinot/issues/10342#issuecomment-1448726744 @Jackie-Jiang : Any concerns in making the zk call? We actually make a zk call anyways to get the metadata in `reloadSegmentWithMetadata` if the segment is not a mutable one.

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120629885 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -558,15 +560,39 @@ private RecordInfo getRecordI

[GitHub] [pinot] walterddr commented on pull request #10354: [Test][DoNotReivew] try reverting grpc

walterddr commented on PR #10354: URL: https://github.com/apache/pinot/pull/10354#issuecomment-1448686063 CC @ankitsultana @xiangfu0 @aahmed-se -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] walterddr opened a new pull request, #10354: [Test][DoNotReivew] try reverting grpc

walterddr opened a new pull request, #10354: URL: https://github.com/apache/pinot/pull/10354 saw some regression since grpc version bump. try reverting and check CI performance. do not review -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10348: [bugfix] Fix bug with PERCENT_SEGMENTS_AVAILABLE metric rounding down

Jackie-Jiang commented on code in PR #10348: URL: https://github.com/apache/pinot/pull/10348#discussion_r1120594397 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java: ## @@ -298,7 +298,7 @@ private void updateSegmentMetrics(String tabl

[pinot] branch master updated: [feature] Add jdbc multistage support (#10292)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2dc26ac402 [feature] Add jdbc multistage support (

[GitHub] [pinot] walterddr merged pull request #10292: [feature] Add jdbc multistage support

walterddr merged PR #10292: URL: https://github.com/apache/pinot/pull/10292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] tibrewalpratik17 opened a new issue, #10353: On-demand API for backing up segments of offline table back to deepstore

tibrewalpratik17 opened a new issue, #10353: URL: https://github.com/apache/pinot/issues/10353 We have an offline table for which the deepstore data got deleted. We want to copy the data back from Pinot-servers to deepstore. At present, there is no support for this in case of offline segmen

[GitHub] [pinot] ankitsultana commented on pull request #10349: [multistage] Use Different Thread Pool for QueryServer

ankitsultana commented on PR #10349: URL: https://github.com/apache/pinot/pull/10349#issuecomment-1448650897 > can you elaborate more on "threads blocked on the queue"? which queue are we talking about? The blockingQueue in BaseCombineOperator > we should submit stage plans in

[GitHub] [pinot] codecov-commenter commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

codecov-commenter commented on PR #10352: URL: https://github.com/apache/pinot/pull/10352#issuecomment-1448621898 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10352?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] vvivekiyer commented on issue #10318: [multistage] Return type for AVG() aggregation function

vvivekiyer commented on issue #10318: URL: https://github.com/apache/pinot/issues/10318#issuecomment-1448605060 Let me do some digging today on Postgres numeric type and Calcite and get back. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI

tibrewalpratik17 commented on code in PR #10336: URL: https://github.com/apache/pinot/pull/10336#discussion_r1120430373 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -170,10 +171,10 @@ private String getMultiStageQuery

[GitHub] [pinot] walterddr commented on pull request #10349: [multistage] Use Different Thread Pool for QueryServer

walterddr commented on PR #10349: URL: https://github.com/apache/pinot/pull/10349#issuecomment-1448505451 > In v2 engine at present we use the same thread-pool for both of the above which can lead to a dead-lock in cases when the thread-pool is fully occupied with threads blocked on the que

[GitHub] [pinot] gortiz commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

gortiz commented on PR #10352: URL: https://github.com/apache/pinot/pull/10352#issuecomment-1448463423 @Jackie-Jiang please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pinot] gortiz commented on issue #10183: Index Service Provider Interface (SPI)

gortiz commented on issue #10183: URL: https://github.com/apache/pinot/issues/10183#issuecomment-1448459058 I've created #10352 in order to clean up `IndexLoadingConfig` and `SegmentGeneratorConfig`. During this month I've have to deal with several complex merges when retrieving code from m

[GitHub] [pinot] gortiz opened a new pull request, #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

gortiz opened a new pull request, #10352: URL: https://github.com/apache/pinot/pull/10352 When we were working on #10183, two classes that were quite problematic were `IndexLoadingConfig` and `SegmentGeneratorConfig`. Both classes are usually build from a `TableConfig`, which they use to ex

[GitHub] [pinot] eaugene opened a new pull request, #10351: [feature] Adding setter to DeletedSegmentsRetentionPeriod in TableConfigBuilder

eaugene opened a new pull request, #10351: URL: https://github.com/apache/pinot/pull/10351 TableConfigBuilder hard codes the DeletedSegmentsRetentionPeriod as with default value of 7days . Making this change to have a setter to make DeletedSegmentsRetentionPeriod configurable from the c

[GitHub] [pinot] gortiz commented on issue #10183: Index Service Provider Interface (SPI)

gortiz commented on issue #10183: URL: https://github.com/apache/pinot/issues/10183#issuecomment-1448260115 @Jackie-Jiang and I decided to change the current proposals in order to use the alternative where IndexDeclaration is not necessary. https://github.com/apache/pinot/pull/10191 has bee

[GitHub] [pinot] gortiz commented on pull request #10191: [Index SPI] IndexType

gortiz commented on PR #10191: URL: https://github.com/apache/pinot/pull/10191#issuecomment-1448257699 @Jackie-Jiang I've modified this PR in order to remove the IndexDeclaration, as we discussed online. I'll be checking the tests, but this should be ready to merge -- This is an automat

[GitHub] [pinot] abhijeetkushe commented on issue #10274: Provide support for AWS Corretto and Microsoft JDK 11

abhijeetkushe commented on issue #10274: URL: https://github.com/apache/pinot/issues/10274#issuecomment-1448202465 Any updates on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pinot] codecov-commenter commented on pull request #10346: (WIP) Add broker side segment name pruner

codecov-commenter commented on PR #10346: URL: https://github.com/apache/pinot/pull/10346#issuecomment-1448096797 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] codecov-commenter commented on pull request #10350: [bugfix] Fix unavailable instances issues for StrictReplicaGroup

codecov-commenter commented on PR #10350: URL: https://github.com/apache/pinot/pull/10350#issuecomment-1448042685 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10346: (WIP) Add broker side segment name pruner

saurabhd336 commented on code in PR #10346: URL: https://github.com/apache/pinot/pull/10346#discussion_r1119941859 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/SegmentNameSegmentPruner.java: ## @@ -0,0 +1,164 @@ +/** + * Licensed to the Apache Soft

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10255: Allow replica group assignment support in tier configs

saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1119909860 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -545,10 +547,54 @@ private Map getTierToInstancePart

[GitHub] [pinot] 61yao commented on pull request #10350: [bugfix] Fix unavailable instances issues for StrictReplicaGroup

61yao commented on PR #10350: URL: https://github.com/apache/pinot/pull/10350#issuecomment-1447994320 @Jackie-Jiang @snleee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] 61yao opened a new pull request, #10350: [bugfix] Fix unavailable instances issues for StrictReplicaGroup

61yao opened a new pull request, #10350: URL: https://github.com/apache/pinot/pull/10350 New segments won't exclude unavailable instances from replica group. Also, we don't report new segments as unavailable segments. Definition of new segments: segments with creation age more than 5

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10255: Allow replica group assignment support in tier configs

saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1119895149 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1757,6 +1758,23 @@ private void assignInstances(Tabl

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10255: Allow replica group assignment support in tier configs

saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1119889957 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -82,4 +83,34 @@ public InstancePar

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10255: Allow replica group assignment support in tier configs

saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1119870270 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java: ## @@ -80,39 +83,68 @@ public class PinotIn

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10255: Allow replica group assignment support in tier configs

saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1119869074 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java: ## @@ -261,6 +263,20 @@ public static UserConfig getUserConfig(ZkHelixPrope

[pinot] branch master updated: Add Statistics grouped at Stage ID level in the V2 Engine Response (#10337)

This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c5dd6df27c Add Statistics grouped at Stage I

[GitHub] [pinot] KKcorps merged pull request #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

KKcorps merged PR #10337: URL: https://github.com/apache/pinot/pull/10337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] codecov-commenter commented on pull request #10349: [multistage] Use Different Thread Pool for QueryServer

codecov-commenter commented on PR #10349: URL: https://github.com/apache/pinot/pull/10349#issuecomment-1447863251 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] ankitsultana opened a new pull request, #10349: [multistage] Use Different Thread Pool for QueryServer

ankitsultana opened a new pull request, #10349: URL: https://github.com/apache/pinot/pull/10349 v1 engine uses two types of thread-pools: runners and workers. Workers run the per-segment operators and runners run the BaseCombineOperator. Workers provide data to the blockingQueue in the comb

[GitHub] [pinot] GSharayu commented on a diff in pull request #10270: Adding partition pruner in QueryContext

GSharayu commented on code in PR #10270: URL: https://github.com/apache/pinot/pull/10270#discussion_r1119699319 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -190,4 +191,25 @@ public static Integer getGroupTrimThreshold(Map quer

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10343: Add min / max values to virtual column metadata to allow segment pruning

saurabhd336 commented on code in PR #10343: URL: https://github.com/apache/pinot/pull/10343#discussion_r1119695533 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java: ## @@ -94,6 +95,36 @@ public Co