saurabhd336 commented on code in PR #10255:
URL: https://github.com/apache/pinot/pull/10255#discussion_r1119909860
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -545,10 +547,54 @@ private Map<String, InstancePartitions>
getTierToInstancePartitionsMap(String ta
* InstancePartitions to zk.
* Then we'll be able to support replica group assignment while creating
InstancePartitions for tiers
*/
- private InstancePartitions getInstancePartitionsForTier(Tier tier, String
tableNameWithType) {
Review Comment:
Update comments. For the persisting states, I was following this
https://github.com/apache/pinot/blob/1ab35ead487a713a126bf03f46604f9d407741c0/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java#L469
as it is for tier side. I'll try to move this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
