[GitHub] [pinot] codecov-commenter commented on pull request #10333: [multistage] Increase Max Inbound Message Size to 64MB for QueryServer

codecov-commenter commented on PR #10333: URL: https://github.com/apache/pinot/pull/10333#issuecomment-1442859122 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] suddendust commented on issue #10313: API for Rebalance Status

suddendust commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1442856890 @Jackie-Jiang But we can calculate the target and the current assigned when the API is invoked? We can just run a rebalance with `dryRun = true` and check the status? -- This i

[GitHub] [pinot] codecov-commenter commented on pull request #10332: [multistage] Dispatch Query Plan in Parallel

codecov-commenter commented on PR #10332: URL: https://github.com/apache/pinot/pull/10332#issuecomment-1442851303 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] ankitsultana opened a new pull request, #10333: [multistage] Increase Max Inbound Message Size to 64MB for QueryServer

ankitsultana opened a new pull request, #10333: URL: https://github.com/apache/pinot/pull/10333 The query-plan can get quite large if there are multiple joins in a query and a lot of servers. Increasing this to a large enough value for now until we explore optimizing this transfer in https

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10332: [multistage] Dispatch Query Plan in Parallel

ankitsultana commented on code in PR #10332: URL: https://github.com/apache/pinot/pull/10332#discussion_r1116522739 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryDispatcherTest.java: ## @@ -51,7 +41,13 @@ public class QueryDispatcherTest extends QueryT

[GitHub] [pinot] ankitsultana opened a new pull request, #10332: [multistage] Dispatch Query Plan in Parallel

ankitsultana opened a new pull request, #10332: URL: https://github.com/apache/pinot/pull/10332 Sends query plans in parallel and uses a deadline derived from the query timeout. Related to #10331 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pinot] ankitsultana opened a new issue, #10331: [multistage] Fix Bottlenecks in QueryDispatcher

ankitsultana opened a new issue, #10331: URL: https://github.com/apache/pinot/issues/10331 There are the following issues with QueryDispatcher right now: 1. There's no timeout set for the dispatch call. This can lead to a query getting stuck indefinitely until the connection is termin

[GitHub] [pinot] codecov-commenter commented on pull request #10330: Fix the missing BIG_DECIMAL handling in range predicate evaluator

codecov-commenter commented on PR #10330: URL: https://github.com/apache/pinot/pull/10330#issuecomment-1442819033 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] codecov-commenter commented on pull request #10329: enable readonly access to controller UI for users without table restrictions

codecov-commenter commented on PR #10329: URL: https://github.com/apache/pinot/pull/10329#issuecomment-1442804397 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[pinot] branch 0.10.0-adls-fix created (now 855e8fc45e)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch 0.10.0-adls-fix in repository https://gitbox.apache.org/repos/asf/pinot.git at 855e8fc45e Allow file overwrite during the segment refresh (#10317) This branch includes the following new com

[pinot] 02/02: Allow file overwrite during the segment refresh (#10317)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch 0.10.0-adls-fix in repository https://gitbox.apache.org/repos/asf/pinot.git commit 855e8fc45e29588bca0f4c1dd4e7b2ea0d98d91b Author: Seunghyun Lee AuthorDate: Thu Feb 23 00:40:08 2023 -0800 Al

[pinot] 01/02: Fix the issue with ADLSGen2 connector when writing a file

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch 0.10.0-adls-fix in repository https://gitbox.apache.org/repos/asf/pinot.git commit a05453fb8affcce0a377f156e3fe19df0b195abc Author: Seunghyun Lee AuthorDate: Sun Feb 5 14:31:25 2023 -0800 Fix

[GitHub] [pinot] apucher opened a new pull request, #10329: enable readonly access to controller UI for users without table restrictions

apucher opened a new pull request, #10329: URL: https://github.com/apache/pinot/pull/10329 This PR aligns the web UI authentication process with the reasonable expectation of read-only users to have access to the web UI. The controller UI currently checks for full (aka "admin") access

[pinot] 01/01: enable readonly access to controller UI for users without table restrictions

This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch auth-enable-readonly-access-controller-ui in repository https://gitbox.apache.org/repos/asf/pinot.git commit 95b73d30fcd3cc15aa7f9a1a190eb962b243c999 Author: Alexander Pucher AuthorDate: Thu Feb

[pinot] branch auth-enable-readonly-access-controller-ui created (now 95b73d30fc)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch auth-enable-readonly-access-controller-ui in repository https://gitbox.apache.org/repos/asf/pinot.git at 95b73d30fc enable readonly access to controller UI for users without table restric

[GitHub] [pinot] vvivekiyer commented on pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on PR #10248: URL: https://github.com/apache/pinot/pull/10248#issuecomment-1442682370 > One more question, this PR shouldn't require any further changes on the execution side, right? In that case, can you also add some execution tests (using the output mechanism if H2 d

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116421695 ## pinot-query-planner/src/test/resources/queries/GroupByPlans.json: ## @@ -91,6 +91,92 @@ "\n LogicalTableScan(table=[[a]])",

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116421527 ## pinot-query-planner/src/test/resources/queries/GroupByPlans.json: ## @@ -91,6 +91,92 @@ "\n LogicalTableScan(table=[[a]])",

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116421093 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java: ## @@ -119,23 +132,25 @@ public void onMatch(RelOptRuleC

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116421093 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java: ## @@ -119,23 +132,25 @@ public void onMatch(RelOptRuleC

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116420746 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java: ## @@ -169,36 +183,136 @@ private RelNode makeNewInterme

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116420526 ## pinot-query-planner/src/test/resources/queries/GroupByPlans.json: ## @@ -91,6 +91,92 @@ "\n LogicalTableScan(table=[[a]])",

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

vvivekiyer commented on code in PR #10248: URL: https://github.com/apache/pinot/pull/10248#discussion_r1116420120 ## pinot-query-planner/src/test/resources/queries/GroupByPlans.json: ## @@ -91,6 +91,92 @@ "\n LogicalTableScan(table=[[a]])",

[GitHub] [pinot] navina commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

navina commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442676787 @snleee / @mcvsubbu I don't think Linkedin is using any of the underlying metrics from the kafka consumer in the dashboards, which is what gets affected due to this change. And I agree wit

[GitHub] [pinot] codecov-commenter commented on pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

codecov-commenter commented on PR #10326: URL: https://github.com/apache/pinot/pull/10326#issuecomment-1442660565 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] jugomezv commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

jugomezv commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442642760 > @mcvsubbu @sajjad-moradi @jugomezv Can you double check on this change given that this may start to emit metrics using different name? @snleee thanks for bringing this up, let me

[GitHub] [pinot] codecov-commenter commented on pull request #10248: [multi-stage] Support query plan for GROUP BY only in the intermediary stage

codecov-commenter commented on PR #10248: URL: https://github.com/apache/pinot/pull/10248#issuecomment-1442619217 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] snleee commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

snleee commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442608074 @mcvsubbu I think that this behavior will not change often once the change is checked in. We made a similar id change about 3 yrs ago https://github.com/apache/pinot/pull/4955 If th

[GitHub] [pinot] mcvsubbu commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

mcvsubbu commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442588942 Does it make sense to introduce an API to the stream to generate a client ID (given some inputs)? That way, these things can be tailored on a per installation basis. -- This is an aut

[GitHub] [pinot] snleee commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

snleee commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442585515 @mcvsubbu @sajjad-moradi @jugomezv Can you double check on this change given that this may start to emit metrics using different name? -- This is an automated message from the Apache Git

[GitHub] [pinot] codecov-commenter commented on pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

codecov-commenter commented on PR #10328: URL: https://github.com/apache/pinot/pull/10328#issuecomment-1442584078 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] egalpin commented on pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on PR #10234: URL: https://github.com/apache/pinot/pull/10234#issuecomment-1442572905 @Jackie-Jiang changed to array-based impl in https://github.com/apache/pinot/pull/10234/commits/e4eb4e624ebdeca30a49839d159484dd3e68cff1 -- This is an automated message from the Apache

[GitHub] [pinot] Jackie-Jiang commented on pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

Jackie-Jiang commented on PR #10234: URL: https://github.com/apache/pinot/pull/10234#issuecomment-1442554110 > The memory overhead really starts to add up. Now that I have the context that the upsert config cannot change without server restart, I feel that this design can be re-implemented

[GitHub] [pinot] andimiller opened a new pull request, #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

andimiller opened a new pull request, #10328: URL: https://github.com/apache/pinot/pull/10328 This enables offline aggregation for `BYTES` columns containing hyperloglogs, and `BYTES` columns containing theta sketches. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [pinot] swaminathanmanish commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

swaminathanmanish commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442519884 @navina , @snleee - Could you please review ? Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[pinot] branch master updated: Upgrade github action versions (#10327)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d3c8ec2ec0 Upgrade github action versions (#1032

[GitHub] [pinot] xiangfu0 merged pull request #10327: Upgrade github action versions

xiangfu0 merged PR #10327: URL: https://github.com/apache/pinot/pull/10327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] egalpin commented on pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on PR #10234: URL: https://github.com/apache/pinot/pull/10234#issuecomment-1442485990 The memory overhead really starts to add up. Now that I have the context that the upsert config cannot change without server restart, I feel that this design can be re-implemented using

[pinot] branch master updated: Always pass the QueryContext into TransformFunctionFactory (#10320)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a1d1c3b1af Always pass the QueryContext into Tran

[GitHub] [pinot] Jackie-Jiang merged pull request #10320: Always pass the QueryContext into TransformFunctionFactory

Jackie-Jiang merged PR #10320: URL: https://github.com/apache/pinot/pull/10320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] xiangfu0 opened a new pull request, #10327: Upgrade github action versions

xiangfu0 opened a new pull request, #10327: URL: https://github.com/apache/pinot/pull/10327 Update github action versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pinot] codecov-commenter commented on pull request #10320: Always pass the QueryContext into TransformFunctionFactory

codecov-commenter commented on PR #10320: URL: https://github.com/apache/pinot/pull/10320#issuecomment-1442394026 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] somandal commented on pull request #8758: Improve accuracy of aggregate group-by without order-by queries by adding a query rewriter to convert aggregate group-by only queries to add

somandal commented on PR #8758: URL: https://github.com/apache/pinot/pull/8758#issuecomment-1442361634 Closing this as we discussed a different approach to handle this and I forgot to close this earlier. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pinot] somandal closed pull request #8758: Improve accuracy of aggregate group-by without order-by queries by adding a query rewriter to convert aggregate group-by only queries to add order-

somandal closed pull request #8758: Improve accuracy of aggregate group-by without order-by queries by adding a query rewriter to convert aggregate group-by only queries to add order-by URL: https://github.com/apache/pinot/pull/8758 -- This is an automated message from the Apache Git Service

[GitHub] [pinot] Jackie-Jiang commented on issue #10313: API for Rebalance Status

Jackie-Jiang commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1442358418 This is duplicate with #9558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] Jackie-Jiang commented on pull request #10047: [WIP] Add upsert ttl configs for Pinot upsert optimizations

Jackie-Jiang commented on PR #10047: URL: https://github.com/apache/pinot/pull/10047#issuecomment-1442355011 > Hi @Jackie-Jiang, thanks for the commit. Can you help understand this part? In my understanding, each partitionManager has its own PrimaryKeyToRecordLocation map. When committing a

[pinot] branch master updated: fix table sorting while filter is applied (#10226)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 69420af19e fix table sorting while filter is appl

[GitHub] [pinot] Jackie-Jiang merged pull request #10226: fix table sorting while filter is applied

Jackie-Jiang merged PR #10226: URL: https://github.com/apache/pinot/pull/10226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on issue #10313: API for Rebalance Status

Jackie-Jiang commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1442336767 cc @navina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] deemoliu commented on pull request #10047: [WIP] Add upsert ttl configs for Pinot upsert optimizations

deemoliu commented on PR #10047: URL: https://github.com/apache/pinot/pull/10047#issuecomment-1442335171 > > Hi @Jackie-Jiang I checked this part, the function will be called during LLRealtimeSegmentDataManager.commitSegment(String, boolean). Since it's triggered when commit Segment, the ne

[GitHub] [pinot] Jackie-Jiang commented on issue #10313: API for Rebalance Status

Jackie-Jiang commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1442331999 Rebalance is slightly different from reload because the target assignment (IS) can change multiple times with no-downtime settings, also if the IS changes while rebalancing, pin

[GitHub] [pinot] swaminathanmanish commented on issue #10313: API for Rebalance Status

swaminathanmanish commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1442330492 I'll be looking into this and will take it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10321: Refactor Spark Connector into two modules for reusability

xiangfu0 commented on code in PR #10321: URL: https://github.com/apache/pinot/pull/10321#discussion_r1116165501 ## pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java: ## @@ -0,0 +1,201 @@ +/** Review Comment:

[GitHub] [pinot] Jackie-Jiang merged pull request #10260: Relax the constraint to have a dictionary and inverted index when forward index is disabled

Jackie-Jiang merged PR #10260: URL: https://github.com/apache/pinot/pull/10260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Add Theta Sketch Aggregation for StarTree Indexes (#10288)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9b49bca554 Add Theta Sketch Aggregation for StarT

[GitHub] [pinot] Jackie-Jiang merged pull request #10288: Add Theta Sketch Aggregation for StarTree Indexes

Jackie-Jiang merged PR #10288: URL: https://github.com/apache/pinot/pull/10288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on pull request #10226: fix table sorting while filter is applied

Jackie-Jiang commented on PR #10226: URL: https://github.com/apache/pinot/pull/10226#issuecomment-1442320318 @jayeshchoudhary Do you think we can merge this bug fix first, then provide a clean fix separately? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pinot] cgenrich opened a new pull request, #10326: Provide results in CompletableFuture for java clients and expose metrics

cgenrich opened a new pull request, #10326: URL: https://github.com/apache/pinot/pull/10326 `feature` https://github.com/apache/pinot/issues/10325 `observability` Expose a new method to provide metrics from the transport layer implementation. `release-notes` - Signature changes to

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1116121225 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertRestletResource.java: ## @@ -129,14 +129,17 @@ public String estimateHeapUsage(St

[GitHub] [pinot] navina commented on pull request #10310: Consumer lag unknown

navina commented on PR #10310: URL: https://github.com/apache/pinot/pull/10310#issuecomment-1442275988 > I think the issue with getUpstreamLatestOffset being null happens at around the time that we're changing the consuming segment/sealing it. @mneedham : I don't think the segment co

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1116120296 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertRestletResource.java: ## @@ -129,14 +129,17 @@ public String estimateHeapUsage(St

[GitHub] [pinot] cgenrich opened a new issue, #10325: Change Future to CompletableFuture in java client

cgenrich opened a new issue, #10325: URL: https://github.com/apache/pinot/issues/10325 Future.get() blocks threads and causes performance issues for users of the java client library or requires an additional watcher thread checking for completions and issuing callbacks. The underlying HTTP

[GitHub] [pinot] egalpin commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1116097731 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java: ## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] swaminathanmanish opened a new pull request, #10324: (IN DRAFT, NOT READY) Adding table name to create unique Kafka consumer client Ids

swaminathanmanish opened a new pull request, #10324: URL: https://github.com/apache/pinot/pull/10324 #10014 This PR is to fix the issue in [](https://github.com/apache/pinot/issues/10014), by creating unique Kafka consumer client Ids. -- This is an automated message from the Apach

svn commit: r60272 - /release/pinot/KEYS

Author: xiangfu Date: Thu Feb 23 15:43:59 2023 New Revision: 60272 Log: Update Pinot KEYS file for 0F912E9BA55E4F6E Modified: release/pinot/KEYS Modified: release/pinot/KEYS == --- release/pinot/KEYS (original) +++ r

[GitHub] [pinot] KKcorps commented on pull request #10323: Bug fix: OpChain marked as errorenous incorrectly

KKcorps commented on PR #10323: URL: https://github.com/apache/pinot/pull/10323#issuecomment-1441526250 Seems like it has already been fixed in a seperate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pinot] KKcorps closed pull request #10323: Bug fix: OpChain marked as errorenous incorrectly

KKcorps closed pull request #10323: Bug fix: OpChain marked as errorenous incorrectly URL: https://github.com/apache/pinot/pull/10323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pinot] KKcorps opened a new pull request, #10323: Bug fix: OpChain marked as errorenous incorrectly

KKcorps opened a new pull request, #10323: URL: https://github.com/apache/pinot/pull/10323 This bug got introduced with the #10289 We are throwing error even in case the opChain completes successfully as well without exceptions. The change order of the checks is the root cause.

[GitHub] [pinot] suddendust closed issue #10278: Admin APIs for ERROR Segments

suddendust closed issue #10278: Admin APIs for ERROR Segments URL: https://github.com/apache/pinot/issues/10278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pinot] suddendust commented on issue #10278: Admin APIs for ERROR Segments

suddendust commented on issue #10278: URL: https://github.com/apache/pinot/issues/10278#issuecomment-1441438088 Ah, this solves it! I think this issue can be closed then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pinot] suddendust commented on issue #10313: API for Rebalance Status

suddendust commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1441430986 I think this can be pretty similar to the reload API. During rebalance, we persist the rebalance config and the segments to monitor in ZK. When the status API is called, we can fe

[GitHub] [pinot] ankitsultana opened a new pull request, #10322: [wip] [Do Not Review] [multistage] Fix Leaks in Mailbox

ankitsultana opened a new pull request, #10322: URL: https://github.com/apache/pinot/pull/10322 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pinot] branch master updated: Allow file overwrite during the segment refresh (#10317)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1fce07ed77 Allow file overwrite during the segment

[GitHub] [pinot] snleee merged pull request #10317: Allow file overwrite during the segment refresh for ADLS Gen2

snleee merged PR #10317: URL: https://github.com/apache/pinot/pull/10317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach