vvivekiyer commented on PR #10248: URL: https://github.com/apache/pinot/pull/10248#issuecomment-1442682370
> One more question, this PR shouldn't require any further changes on the execution side, right? In that case, can you also add some execution tests (using the output mechanism if H2 doesn't work for this) and compare the output of the query with hint and without hint to make sure the results match? @somandal That's right. No execution side changes are necessary. I've added some runtime tests. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
