codecov-commenter commented on PR #10086:
URL: https://github.com/apache/pinot/pull/10086#issuecomment-1376857999
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10086?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
Jackie-Jiang opened a new pull request, #10087:
URL: https://github.com/apache/pinot/pull/10087
Zero padding is made default in #352 (Aug. 2016), and enforced in #2495
(Feb. 2018). This PR drops the support for non-zero padding to avoid
unnecessary checks.
Segments generated with non-zer
saurabhd336 commented on PR #10086:
URL: https://github.com/apache/pinot/pull/10086#issuecomment-1376823431
@Jackie-Jiang @npawar @klsince
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
saurabhd336 opened a new pull request, #10086:
URL: https://github.com/apache/pinot/pull/10086
Right now, we set the modified default time column value for all segments,
if it's absent in original schema. Ideally, that's only needed for CONSUMING
segments since changing the default value fo
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7751867574 solve injection issue using a dummy l
xiangfu0 merged PR #10085:
URL: https://github.com/apache/pinot/pull/10085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
snleee commented on code in PR #10083:
URL: https://github.com/apache/pinot/pull/10083#discussion_r1065359235
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##
@@ -333,9 +333,7 @@ public PinotMeter getMeteredTableValue(final String
tableName
SandishKumarHN commented on code in PR #10030:
URL: https://github.com/apache/pinot/pull/10030#discussion_r1065362676
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -65,4 +75,114 @@ public s
KKcorps commented on code in PR #10030:
URL: https://github.com/apache/pinot/pull/10030#discussion_r1065352035
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -65,4 +75,114 @@ public static F
klsince commented on PR #10077:
URL: https://github.com/apache/pinot/pull/10077#issuecomment-1376693612
> Out of interest how do you know this is more disk-friendly ...
This is a great question! This option is kinda experimental. We're
experimenting a ReadAhead mechanism to access seg
codecov-commenter commented on PR #10085:
URL: https://github.com/apache/pinot/pull/10085#issuecomment-1376653330
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10085?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
zhtaoxiang opened a new pull request, #10085:
URL: https://github.com/apache/pinot/pull/10085
When loggerRootDir is not provided, fix get loggers & set loggers issue
(injection failure) by providing a dummy log file server
--
This is an automated message from the Apache Git Service.
To r
siddharthteotia commented on issue #9055:
URL: https://github.com/apache/pinot/issues/9055#issuecomment-1376615246
PR should be out in a week or two for broker query killing support.
@jasperjiaguo actively working on it.
--
This is an automated message from the Apache Git Service.
To re
jasperjiaguo commented on issue #6707:
URL: https://github.com/apache/pinot/issues/6707#issuecomment-1376612077
Discussed offline. Will pick this up after finishing up broker query killing
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mcvsubbu commented on PR #9994:
URL: https://github.com/apache/pinot/pull/9994#issuecomment-1376607259
Pending comments to be addressed in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6a216c5a4f [feature] Add a Tracker class to sup
mcvsubbu merged PR #9994:
URL: https://github.com/apache/pinot/pull/9994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
Jackie-Jiang commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065260703
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java:
##
@@ -39,37 +39,56 @@ private TableStateUtils() {
}
codecov-commenter commented on PR #10084:
URL: https://github.com/apache/pinot/pull/10084#issuecomment-1376564242
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065220139
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,371 @@
+/**
+ * Licensed to the Apache Software Foundat
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065219973
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##
@@ -45,8 +45,9 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
// Ded
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065219850
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java:
##
@@ -183,4 +184,11 @@ void addOrReplaceSegment(String tableNameWithType, Strin
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065219504
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -201,4 +201,18 @@ void addOrReplaceSegment(String segmentNa
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065219405
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java:
##
@@ -39,37 +39,56 @@ private TableStateUtils() {
}
/
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065219049
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java:
##
@@ -39,37 +39,56 @@ private TableStateUtils() {
}
/
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065218949
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed to the Apache Software Foundat
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065218789
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed to the Apache Software Foundat
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065218428
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed to the Apache Software Foundat
Jackie-Jiang opened a new pull request, #10084:
URL: https://github.com/apache/pinot/pull/10084
They were introduced when adding the segment processing framework, then we
modified the framework to use the general `RecordTransformer` which is used for
all ingestion.
--
This is an automate
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 20ca63f4be handle null more defensively when loading startree index
(#10081)
add fa5526748a push unsigned byte co
Jackie-Jiang merged PR #10044:
URL: https://github.com/apache/pinot/pull/10044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #10043:
URL: https://github.com/apache/pinot/pull/10043#discussion_r1065196146
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java:
##
@@ -44,44 +53,74 @@ public class RangeIndexBasedFilterOper
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065199612
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed to the Apache Software Foundat
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065197699
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed to the Apache Software Foundat
Jackie-Jiang commented on issue #10073:
URL: https://github.com/apache/pinot/issues/10073#issuecomment-1376468240
Can you check if `null` is filled with 1970-01-01? It shouldn't be the case
though. If default value is not provided, we will fill `null` with the current
time, and that's why i
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065190160
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java:
##
@@ -39,37 +39,56 @@ private TableStateUtils() {
}
/
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065185467
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -201,4 +201,18 @@ void addOrReplaceSegment(String segmentNa
Jackie-Jiang commented on issue #10079:
URL: https://github.com/apache/pinot/issues/10079#issuecomment-1376450593
Can you check if there is any exception when creating the JSON index?
`STRING` data type has a default 512 length limit, so maybe some values are
truncated, thus cause exception
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065183312
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##
@@ -45,8 +45,9 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
// Ded
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065182907
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,371 @@
+/**
+ * Licensed to the Apache Software Foundat
Jackie-Jiang commented on code in PR #10052:
URL: https://github.com/apache/pinot/pull/10052#discussion_r1065180884
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##
@@ -423,6 +415,82 @@ public Response downloadSegment(
}
}
+
Jackie-Jiang commented on code in PR #10052:
URL: https://github.com/apache/pinot/pull/10052#discussion_r1065180106
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##
@@ -423,6 +414,83 @@ public Response downloadSegment(
}
}
+
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from f9c8983a1c add realtime consumption exception to LL consumer data
manager metrics (#10074)
add 20ca63f4be handle
Jackie-Jiang merged PR #10081:
URL: https://github.com/apache/pinot/pull/10081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065116929
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##
@@ -45,8 +45,9 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
//
SandishKumarHN commented on PR #10030:
URL: https://github.com/apache/pinot/pull/10030#issuecomment-1376274647
> Thanks a lot for doing this! One request, can we avoid refactoring the
class names such as `ProtoBufRecordReader` to `ProtobufRecordReader` for
backward compatibility.
@KK
codecov-commenter commented on PR #10083:
URL: https://github.com/apache/pinot/pull/10083#issuecomment-1376133104
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10083?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065003417
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,362 @@
+/**
+ * Licensed to the Apache Software Foundat
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065002648
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java:
##
@@ -39,25 +39,25 @@ private TableStateUtils() {
}
/
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1065001747
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -212,6 +223,58 @@ protected void doShutdown() {
if (_le
jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1064933014
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -0,0 +1,362 @@
+/**
+ * Licensed to the Apache Software Foundat
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f9c8983a1c add realtime consumption exception to L
walterddr commented on code in PR #10074:
URL: https://github.com/apache/pinot/pull/10074#discussion_r1064885167
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##
@@ -420,6 +423,9 @@ protected boolean consumeLoop()
walterddr merged PR #10074:
URL: https://github.com/apache/pinot/pull/10074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
kirkrodrigues commented on PR #9942:
URL: https://github.com/apache/pinot/pull/9942#issuecomment-1375623141
Yep, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
KKcorps commented on PR #10030:
URL: https://github.com/apache/pinot/pull/10030#issuecomment-1375542806
Thanks a lot for doing this! One request, can we avoid refactoring the class
names such as `ProtoBufRecordReader` to `ProtobufRecordReader` for backward
compatibility.
--
This is an au
ankitsultana commented on code in PR #9873:
URL: https://github.com/apache/pinot/pull/9873#discussion_r1064571345
##
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##
@@ -98,6 +98,10 @@ protected List queryRunner(String sql) {
prote
codecov-commenter commented on PR #10082:
URL: https://github.com/apache/pinot/pull/10082#issuecomment-1375425811
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
zhtaoxiang opened a new pull request, #10083:
URL: https://github.com/apache/pinot/pull/10083
This PR makes two changes
1. report minion task queue metrics at table level to help triage minion
related problems
2. refactor metric class a bit to make it better
--
This is an automated
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f7c42c82ae logging error if tableConfig is null
xiangfu0 merged PR #10080:
URL: https://github.com/apache/pinot/pull/10080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
elonazoulay commented on issue #10073:
URL: https://github.com/apache/pinot/issues/10073#issuecomment-1375383774
@Jackie-Jiang update: inserting null values for both timestamp and timestamp
arrays results in epoch millis 0, i.e. 1970-01-01 00:00:00.000 - so that can be
used to bypass the mi
61yao commented on PR #10082:
URL: https://github.com/apache/pinot/pull/10082#issuecomment-1375360277
@Jackie-Jiang PTAL @mayankshriv FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
61yao opened a new pull request, #10082:
URL: https://github.com/apache/pinot/pull/10082
Support null literal parsing and broker to server passing. It is printed out
as empty string.
It is passed as string value from broker to server because thrift doesn't
support passing a null valu
64 matches
Mail list logo
