ankitsultana commented on code in PR #9873:
URL: https://github.com/apache/pinot/pull/9873#discussion_r1064571345


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -98,6 +98,10 @@ protected List<Object[]> queryRunner(String sql) {
   protected List<Object[]> queryH2(String sql)
       throws Exception {
     Statement h2statement = 
_h2Connection.createStatement(ResultSet.TYPE_FORWARD_ONLY, 
ResultSet.CONCUR_READ_ONLY);
+    // TODO: Hack. Let's discuss how best to support this.
+    if (sql.contains("option")) {
+      sql = sql.replaceAll("option\\(useColocatedJoin\\=true\\)", "");

Review Comment:
   ^ Essentially the issue is that the H2 queries fail because of the option to 
enable useColocatedJoin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to