[GitHub] [pinot] vvivekiyer opened a new pull request, #9875: Update cardinality when converting raw column to dict based

vvivekiyer opened a new pull request, #9875: URL: https://github.com/apache/pinot/pull/9875 Fixes the issue #9874 Adding tests is still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pinot] KKcorps commented on a diff in pull request #9863: Add rate limit to Kinesis requests

KKcorps commented on code in PR #9863: URL: https://github.com/apache/pinot/pull/9863#discussion_r1035630800 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java: ## @@ -155,6 +162,17 @@ private KinesisRe

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035621542 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -677,4 +836,168 @@ private void updateMet

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035620501 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -258,6 +269,31 @@ Map computeOperation(S

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035617543 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035617369 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035616850 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035616057 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035614972 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -677,4 +836,168 @@ private void updateMetadata

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035613727 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEnableD

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035613884 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035613437 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEnableD

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035612188 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -644,12 +737,15 @@ private void changePropertiesAndReloadSegment(

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035610865 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -554,23 +605,66 @@ public void testSelectWithAggregationQueriesWi

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035610565 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -480,6 +490,47 @@ public void testSelectWithAggregationQueriesWit

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9810: Default column handling of noForwardIndex and regeneration of forward index on reload path

siddharthteotia commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1035601916 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/InvertedIndexAndDictionaryBasedForwardIndexCreator.java: ## @@ -0,0 +1,61

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9810: Default column handling of noForwardIndex and regeneration of forward index on reload path

siddharthteotia commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1035601212 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/InvertedIndexAndDictionaryBasedForwardIndexCreator.java: ## @@ -0,0 +1,61

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9810: Default column handling of noForwardIndex and regeneration of forward index on reload path

siddharthteotia commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1035601212 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/InvertedIndexAndDictionaryBasedForwardIndexCreator.java: ## @@ -0,0 +1,61

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035530196 ## pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java: ## @@ -79,13 +79,39 @@ public void testQueryWithException(String query, String e

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035529816 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -189,4 +172,27 @@ private static boolean canSkipShuffle(Se

[GitHub] [pinot] walterddr commented on a diff in pull request #9571: [multi-stage] allow configurable timeout

walterddr commented on code in PR #9571: URL: https://github.com/apache/pinot/pull/9571#discussion_r1035527985 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,20 +22,43 @@ * Configuration for setting up query runtime. */ publi

[GitHub] [pinot] ankitsultana commented on a diff in pull request #9571: [multi-stage] allow configurable timeout

ankitsultana commented on code in PR #9571: URL: https://github.com/apache/pinot/pull/9571#discussion_r1035515580 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,20 +22,43 @@ * Configuration for setting up query runtime. */ pu

[GitHub] [pinot] 61yao commented on pull request #9870: [multistage][hotfix] shuffle rewrite

61yao commented on PR #9870: URL: https://github.com/apache/pinot/pull/9870#issuecomment-1331586890 Can we also add query option to disable shuffle if needed. So we can know 1) the performance gain from this 2) remove the shuffle when we see an issue -- This is an automated message from t

[GitHub] [pinot] 61yao commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

61yao commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035483859 ## pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java: ## @@ -79,13 +79,39 @@ public void testQueryWithException(String query, String excep

[GitHub] [pinot] 61yao commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

61yao commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035482458 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -189,4 +172,27 @@ private static boolean canSkipShuffle(Set p

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035470897 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -677,4 +836,168 @@ private void updateMet

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035470342 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -677,4 +836,168 @@ private void updateMet

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035465454 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -677,4 +836,168 @@ private void updateMet

[GitHub] [pinot] vvivekiyer commented on issue #9874: Switching from raw index to dictionary encoding breaks REALTIME segments

vvivekiyer commented on issue #9874: URL: https://github.com/apache/pinot/issues/9874#issuecomment-1331548433 Looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] Jackie-Jiang commented on issue #9874: Switching from raw index to dictionary encoding breaks REALTIME segments

Jackie-Jiang commented on issue #9874: URL: https://github.com/apache/pinot/issues/9874#issuecomment-1331544612 @vvivekiyer Can you please take a look at this issue and see if my analysis is correct. cc @siddharthteotia -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

agavra commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035448515 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Jackie-Jiang opened a new issue, #9874: Switching from raw index to dictionary encoding breaks REALTIME segments

Jackie-Jiang opened a new issue, #9874: URL: https://github.com/apache/pinot/issues/9874 #9454 introduces the feature to switch from raw index to dictionary encoding during segment reload. But for REALTIME table, the cardinality info is not available for raw index columns during stats colle

[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

agavra commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035448515 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

Jackie-Jiang commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035432319 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

Jackie-Jiang commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035429392 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035415921 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,25 +145,14 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] walterddr commented on pull request #9571: [multi-stage] allow configurable timeout

walterddr commented on PR #9571: URL: https://github.com/apache/pinot/pull/9571#issuecomment-1331494053 readjusted the PR. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] dependabot[bot] commented on pull request #9813: Bump janino from 3.1.6 to 3.1.9

dependabot[bot] commented on PR #9813: URL: https://github.com/apache/pinot/pull/9813#issuecomment-1331481461 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [pinot] siddharthteotia closed pull request #9813: Bump janino from 3.1.6 to 3.1.9

siddharthteotia closed pull request #9813: Bump janino from 3.1.6 to 3.1.9 URL: https://github.com/apache/pinot/pull/9813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [pinot] dependabot[bot] commented on pull request #9814: Bump azure-storage-file-datalake from 12.8.0 to 12.13.1

dependabot[bot] commented on PR #9814: URL: https://github.com/apache/pinot/pull/9814#issuecomment-1331481415 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [pinot] siddharthteotia closed pull request #9814: Bump azure-storage-file-datalake from 12.8.0 to 12.13.1

siddharthteotia closed pull request #9814: Bump azure-storage-file-datalake from 12.8.0 to 12.13.1 URL: https://github.com/apache/pinot/pull/9814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] dependabot[bot] commented on pull request #9824: Bump loader-utils from 1.4.0 to 1.4.2 in /pinot-controller/src/main/resources

dependabot[bot] commented on PR #9824: URL: https://github.com/apache/pinot/pull/9824#issuecomment-1331481359 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [pinot] siddharthteotia closed pull request #9824: Bump loader-utils from 1.4.0 to 1.4.2 in /pinot-controller/src/main/resources

siddharthteotia closed pull request #9824: Bump loader-utils from 1.4.0 to 1.4.2 in /pinot-controller/src/main/resources URL: https://github.com/apache/pinot/pull/9824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[pinot] branch master updated: [multistage] test coverage for CASE and fix bug with CHAR literals (#9846)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a22250270d [multistage] test coverage for CASE and

[GitHub] [pinot] walterddr merged pull request #9846: [multistage] test coverage for CASE and fix bug with CHAR literals

walterddr merged PR #9846: URL: https://github.com/apache/pinot/pull/9846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035403127 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035402586 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035401877 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035398938 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,25 +145,14 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035398938 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,25 +145,14 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035398836 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,25 +145,14 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] ankitsultana commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

ankitsultana commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035392306 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,25 +145,14 @@ public Set visitMailboxSend(MailboxS

[GitHub] [pinot] codecov-commenter commented on pull request #9873: [Draft] [multistage] PoC for Shuffle Skip Algorithm

codecov-commenter commented on PR #9873: URL: https://github.com/apache/pinot/pull/9873#issuecomment-1331455320 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9873?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

agavra commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035383659 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] ankitsultana opened a new pull request, #9873: [Draft] [multistage] PoC for Shuffle Skip Algorithm

ankitsultana opened a new pull request, #9873: URL: https://github.com/apache/pinot/pull/9873 supersedes: https://github.com/apache/pinot/pull/9838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pinot] ankitsultana closed pull request #9838: [Draft] [multistage] PoC for Shuffle Skip Algorithm

ankitsultana closed pull request #9838: [Draft] [multistage] PoC for Shuffle Skip Algorithm URL: https://github.com/apache/pinot/pull/9838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

agavra commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035360493 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Softwa

[pinot] branch adds-optimization-hotfix updated: AdaptiveServerSelection: hotfix commits (#9872)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch adds-optimization-hotfix in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/adds-optimization-hotfix by this push: new 6c188cf24f Ada

[GitHub] [pinot] jackjlli merged pull request #9872: AdaptiveServerSelection: hotfix commits

jackjlli merged PR #9872: URL: https://github.com/apache/pinot/pull/9872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

agavra commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1035293299 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Softwa

[pinot] branch master updated (ca4c16cc61 -> d50f9ee8b0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ca4c16cc61 [multistage][testing] Add some having test case (#9833) add d50f9ee8b0 Fix a typo in ScalarTransformFu

[GitHub] [pinot] Jackie-Jiang merged pull request #9871: Fix a typo in ScalarTransformFunctionWrapperTest.testStringSplitPartTransformFunction()

Jackie-Jiang merged PR #9871: URL: https://github.com/apache/pinot/pull/9871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035284833 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,19 +147,11 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035275130 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,19 +147,11 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035275130 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,19 +147,11 @@ public Set visitMailboxSend(MailboxSend

[GitHub] [pinot] codecov-commenter commented on pull request #9871: Fix a typo in ScalarTransformFunctionWrapperTest.testStringSplitPartTransformFunction()

codecov-commenter commented on PR #9871: URL: https://github.com/apache/pinot/pull/9871#issuecomment-1331271544 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] agavra commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

agavra commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035233750 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -150,19 +147,11 @@ public Set visitMailboxSend(MailboxSendNod

[GitHub] [pinot] Jackie-Jiang commented on issue #9831: [flaky-test] ForwardIndexHandlerTest.testDisableForwardIndexForSingleRawColumn is flaky

Jackie-Jiang commented on issue #9831: URL: https://github.com/apache/pinot/issues/9831#issuecomment-1331204663 Another example failure run: https://github.com/apache/pinot/actions/runs/3577370671/jobs/6016291495 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pinot] vvivekiyer opened a new pull request, #9872: Adds optimization hotfix l

vvivekiyer opened a new pull request, #9872: URL: https://github.com/apache/pinot/pull/9872 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6

[GitHub] [pinot] mathieudruart commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

mathieudruart commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1035195690 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035175557 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -400,117 +436,262 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035174133 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -400,117 +436,262 @@ private void rewrite

[GitHub] [pinot] navina commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

navina commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1035172757 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@ public

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035128614 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -258,6 +269,31 @@ Map computeOperation(S

[pinot] branch adds-optimization-hotfix created (now 63c6438d3c)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch adds-optimization-hotfix in repository https://gitbox.apache.org/repos/asf/pinot.git at 63c6438d3c Add more test for NonAggregationGroupByToDistinctQueryRewriter (#9616) No new revisi

[pinot] branch master updated (74e13b1aa0 -> ca4c16cc61)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 74e13b1aa0 Merge new columns in existing record with default merge strategy (#9851) add ca4c16cc61 [multistage][te

[GitHub] [pinot] walterddr merged pull request #9833: [multistage][testing] Add some having test case

walterddr merged PR #9833: URL: https://github.com/apache/pinot/pull/9833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035110294 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -644,12 +737,15 @@ private void changePropertiesAndReloadSeg

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035107005 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -554,23 +605,66 @@ public void testSelectWithAggregationQuer

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035105309 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -480,6 +490,47 @@ public void testSelectWithAggregationQueri

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1035103117 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java: ## @@ -480,6 +490,47 @@ public void testSelectWithAggregationQueri

[pinot] branch master updated: Merge new columns in existing record with default merge strategy (#9851)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 74e13b1aa0 Merge new columns in existing record w

[GitHub] [pinot] Jackie-Jiang merged pull request #9851: Merge new columns in existing record with default merge strategy

Jackie-Jiang merged PR #9851: URL: https://github.com/apache/pinot/pull/9851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9832: [multistage] support sort push-down

Jackie-Jiang commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1035078758 ## pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorService.java: ## @@ -129,36 +128,23 @@ public void reduceWithOrdering(Collection

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035064863 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java: ## @@ -54,7 +55,7 @@ public class ShuffleRewriteVisitor implemen

[GitHub] [pinot] rohit-mobstac commented on issue #9869: Pinot stop consuming from Kinesis Data Stream

rohit-mobstac commented on issue #9869: URL: https://github.com/apache/pinot/issues/9869#issuecomment-1331007713 no the server and controller are in different EC2 instances. @navina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pinot] navina commented on issue #9869: Pinot stop consuming from Kinesis Data Stream

navina commented on issue #9869: URL: https://github.com/apache/pinot/issues/9869#issuecomment-1331003798 Looks like it is not able to upload segments. Are the server and controller running on the same host? Segment upload link says "localhost:9000". Hence checking -- This is an automate

[GitHub] [pinot] walterddr commented on a diff in pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on code in PR #9870: URL: https://github.com/apache/pinot/pull/9870#discussion_r1035040562 ## pinot-query-runtime/src/test/resources/queries/SelectExpressions.json: ## @@ -36,7 +36,8 @@ { "sql": "SELECT intCol as \"value\", doubleCol + floatCol AS \"su

[GitHub] [pinot] walterddr opened a new pull request, #9870: [multistage][hotfix] shuffle rewrite

walterddr opened a new pull request, #9870: URL: https://github.com/apache/pinot/pull/9870 shuffle exchange rewrite rules are not carrying partition correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[pinot] branch master updated: [multistage] Add Multi Stage Strict Replica Group Routing Strategy (#9808)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e41bdd0c6f [multistage] Add Multi Stage Strict Re

[GitHub] [pinot] yupeng9 merged pull request #9808: [multistage] Add Multi Stage Strict Replica Group Routing Strategy

yupeng9 merged PR #9808: URL: https://github.com/apache/pinot/pull/9808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[GitHub] [pinot] rohit-mobstac commented on issue #9869: Pinot stop consuming from Kinesis Data Stream

rohit-mobstac commented on issue #9869: URL: https://github.com/apache/pinot/issues/9869#issuecomment-1330894257 Another problem that I have noticed is the segments are not getting committed to deep store (s3) even after `realtime.segment.flush.threshold.time` set to `1h` -- This is an a

[GitHub] [pinot] rohit-mobstac opened a new issue, #9869: Pinot stop consuming from Kinesis Data Stream

rohit-mobstac opened a new issue, #9869: URL: https://github.com/apache/pinot/issues/9869 Pinot realtime ingestion from kinesis data stream works as expected for sometime but eventually stops consuming. While checking server logs, `connection refused` error is shown. Is this due to the issu