siddharthteotia commented on code in PR #9868:
URL: https://github.com/apache/pinot/pull/9868#discussion_r1035103117
##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java:
##########
@@ -480,6 +490,47 @@ public void testSelectWithAggregationQueriesWithReload()
}));
List<Object[]> beforeResultRows3 = resultTable.getRows();
+ // TEST4
Review Comment:
I think since multiple functionalities are being tested here, now this file
has become a bit hard to read and review imo.
I suggest adding brief comments / demarcate tests to indicate what is being
tested where. Will also be more readable for future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
