walterddr commented on code in PR #9870:
URL: https://github.com/apache/pinot/pull/9870#discussion_r1035398836
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java:
##########
@@ -150,25 +145,14 @@ public Set<Integer> visitMailboxSend(MailboxSendNode
node, Void context) {
@Override
public Set<Integer> visitProject(ProjectNode node, Void context) {
Set<Integer> oldPartitionKeys = node.getInputs().get(0).visit(this,
context);
-
- // all inputs carry over if they're still in the projection result
- Set<Integer> partitionKeys = new HashSet<>();
- for (int i = 0; i < node.getProjects().size(); i++) {
- RexExpression rex = node.getProjects().get(i);
- if (rex instanceof RexExpression.InputRef) {
- if (oldPartitionKeys.contains(((RexExpression.InputRef)
rex).getIndex())) {
- partitionKeys.add(i);
- }
- }
- }
-
- return partitionKeys;
+ return deriveNewPartitionKeysFromRexExpressions(node.getProjects(),
oldPartitionKeys);
}
@Override
public Set<Integer> visitSort(SortNode node, Void context) {
- // sort doesn't change the partition keys
- return node.getInputs().get(0).visit(this, context);
+ // with sort shuffling reorder could change, so we can't directly return
the old partition keys.
Review Comment:
sortNode result record type will put collation columns in front of the rest
of the selections. which essentially act as a "project". so it should follow
similar rules to reorder the partitionkey into its new inputRef indices.
since this is a hotfix PR I am not including this in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
