[GitHub] [pinot] 0ZhangJc0 opened a new issue, #9080: gitbook url unavailable

2022-07-20 Thread GitBox
0ZhangJc0 opened a new issue, #9080: URL: https://github.com/apache/pinot/issues/9080 https://docs.pinot.apache.org/ ![image](https://user-images.githubusercontent.com/48285423/180149636-78c3caf3-0da5-4c7f-9f35-ea2df9328d40.png) -- This is an automated message from the Apache G

[GitHub] [pinot] gortiz commented on issue #9079: Support REGEXP_REPLACE

2022-07-20 Thread GitBox
gortiz commented on issue #9079: URL: https://github.com/apache/pinot/issues/9079#issuecomment-1191106340 IMHO this ticket should be labeled as `beginner-task` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pinot] gortiz opened a new issue, #9079: Support REGEXP_REPLACE

2022-07-20 Thread GitBox
gortiz opened a new issue, #9079: URL: https://github.com/apache/pinot/issues/9079 Most SQL databases support `REGEXP_REPLACE` function ([Oracle](https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions130.htm), [Postgres](https://www.postgresql.org/docs/current/functions-matching.h

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926269056 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -517,7 +526,34 @@ private synchronized Map scheduleTasks(

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926267115 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -517,7 +526,34 @@ private synchronized Map scheduleTasks(

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926263366 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java: ## @@ -231,6 +260,55 @@ public Map getTasksDebugInf ret

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926263008 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926262334 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926261222 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926261345 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926260938 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926260568 ## pinot-common/src/main/java/org/apache/pinot/common/minion/InMemoryTaskManagerStatusCache.java: ## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [pinot] codecov-commenter commented on pull request #9078: Throw an exception when MV columns are the first order-by expression in selection order-by queries

2022-07-20 Thread GitBox
codecov-commenter commented on PR #9078: URL: https://github.com/apache/pinot/pull/9078#issuecomment-1190960952 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] somandal opened a new pull request, #9078: Throw an exception when MV columns are the first order-by expression in selection order-by queries

2022-07-20 Thread GitBox
somandal opened a new pull request, #9078: URL: https://github.com/apache/pinot/pull/9078 Today MV columns as the first expression in a Selection Order By query fails during query execution. The error seen today is: ``` 18:25:22.961 BaseCombineOperator - Caught exception while proc

[GitHub] [pinot] gpogulsky commented on a diff in pull request #9063: feature: add table type to segment upload

2022-07-20 Thread GitBox
gpogulsky commented on code in PR #9063: URL: https://github.com/apache/pinot/pull/9063#discussion_r926158159 ## pom.xml: ## @@ -166,8 +166,8 @@ To change kafka connector dependency, we only need to update this version number config. TODO: figure out a way to inject k

[GitHub] [pinot] gpogulsky commented on a diff in pull request #9063: feature: add table type to segment upload

2022-07-20 Thread GitBox
gpogulsky commented on code in PR #9063: URL: https://github.com/apache/pinot/pull/9063#discussion_r926157593 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java: ## @@ -158,7

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r926113601 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -100,7 +100,7 @@ public void processSqlQueryGet(@ApiParam(value = "

[pinot] branch master updated: Support pause/resume consumption of realtime tables (#8986)

2022-07-20 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6903856d39 Support pause/resume consumption of re

[GitHub] [pinot] sajjad-moradi merged pull request #8986: Support pause/resume consumption of realtime tables

2022-07-20 Thread GitBox
sajjad-moradi merged PR #8986: URL: https://github.com/apache/pinot/pull/8986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r926088454 ## pinot-common/src/main/java/org/apache/pinot/common/minion/TaskGeneratorMostRecentRunInfo.java: ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-20 Thread GitBox
sajjad-moradi commented on code in PR #9051: URL: https://github.com/apache/pinot/pull/9051#discussion_r926077254 ## pinot-plugins/pinot-input-format/pinot-confluent-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/confluent/KafkaConfluentSchemaRegistryAvroMessageDecoder.java

[GitHub] [pinot] sajjad-moradi commented on pull request #8986: Support pause/resume consumption of realtime tables

2022-07-20 Thread GitBox
sajjad-moradi commented on PR #8986: URL: https://github.com/apache/pinot/pull/8986#issuecomment-1190758433 > @sajjad-moradi There seems to be test failure on this - > > ``` > Error: PauseResumeConsumptionIntegrationTest.setUp:69->verifyPause:104->verify:116->assertCountStar:13

[GitHub] [pinot] deemoliu commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
deemoliu commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r926044190 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -183,8 +183,8 @@ protected void doInit() { Preconditio

[GitHub] [pinot] mcvsubbu commented on issue #8804: Replication vs ReplicasPerPartition

2022-07-20 Thread GitBox
mcvsubbu commented on issue #8804: URL: https://github.com/apache/pinot/issues/8804#issuecomment-1190724489 @yupeng9 can u please let us know if you are still using this setting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pinot] walterddr commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
walterddr commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925995136 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -175,10 +175,14 @@ private BrokerResponse executeSqlQuery(ObjectNode

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r925983121 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -183,8 +183,8 @@ protected void doInit() { Precond

[GitHub] [pinot] apucher commented on a diff in pull request #9008: Add TLS1.3, Remove TLS1.0, Add User Agent Header, Add Timeouts for Pi…

2022-07-20 Thread GitBox
apucher commented on code in PR #9008: URL: https://github.com/apache/pinot/pull/9008#discussion_r925976777 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java: ## @@ -54,19 +57,19 @@ public class JsonAsyncHttpPinotClie

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925973468 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -273,14 +273,6 @@ public static class QueryOptionKey { public static final

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925972885 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -175,10 +175,14 @@ private BrokerResponse executeSqlQuery(ObjectNod

[GitHub] [pinot] Jackie-Jiang commented on pull request #9008: Add TLS1.3, Remove TLS1.0, Add User Agent Header, Add Timeouts for Pi…

2022-07-20 Thread GitBox
Jackie-Jiang commented on PR #9008: URL: https://github.com/apache/pinot/pull/9008#issuecomment-1190656980 cc @apucher to also take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9077: Ensure conversion of field specs to avro schema is ordered

2022-07-20 Thread GitBox
Jackie-Jiang commented on code in PR #9077: URL: https://github.com/apache/pinot/pull/9077#discussion_r925970719 ## pinot-core/src/main/java/org/apache/pinot/core/util/SegmentProcessorAvroUtils.java: ## @@ -74,7 +74,10 @@ public static GenericData.Record convertGenericRowToAvro

[GitHub] [pinot] navina commented on pull request #9071: Add support for IAM role based credentials in Kinesis Plugin

2022-07-20 Thread GitBox
navina commented on PR #9071: URL: https://github.com/apache/pinot/pull/9071#issuecomment-1190635501 > I planned to add tests in Kinesis integration but unfortunately the localstack IAM service doesn't work as expected and security token fetched from it is always invalid. Ah I see. I

[GitHub] [pinot] jackjlli commented on issue #7144: Add `numConsumingSegmentsProcessed` and `numConsumingSegmentsMatched` into the query response metadata

2022-07-20 Thread GitBox
jackjlli commented on issue #7144: URL: https://github.com/apache/pinot/issues/7144#issuecomment-1190589216 Oops, when I merged the PR, the issue is closed automatically. Thanks @Jackie-Jiang for reopening it! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] Jackie-Jiang commented on issue #7144: Add `numConsumingSegmentsProcessed` and `numConsumingSegmentsMatched` into the query response metadata

2022-07-20 Thread GitBox
Jackie-Jiang commented on issue #7144: URL: https://github.com/apache/pinot/issues/7144#issuecomment-1190587038 @ravishankar15 Yes, reopened it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] Jackie-Jiang opened a new issue, #7144: Add `numConsumingSegmentsProcessed` and `numConsumingSegmentsMatched` into the query response metadata

2022-07-20 Thread GitBox
Jackie-Jiang opened a new issue, #7144: URL: https://github.com/apache/pinot/issues/7144 Currently we have the following metadata in the query response: - numSegmentsQueried: number of segments queried by the broker - numSegmentsProcessed: number of segments processed after the server-s

[GitHub] [pinot] klsince commented on a diff in pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
klsince commented on code in PR #9058: URL: https://github.com/apache/pinot/pull/9058#discussion_r925891929 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -517,7 +526,34 @@ private synchronized Map scheduleTasks(List

[GitHub] [pinot] abhs50 commented on pull request #8907: Log Request header for Broker

2022-07-20 Thread GitBox
abhs50 commented on PR #8907: URL: https://github.com/apache/pinot/pull/8907#issuecomment-1190549618 @vvivekiyer : Any updates for next steps here ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] deemoliu commented on pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
deemoliu commented on PR #9062: URL: https://github.com/apache/pinot/pull/9062#issuecomment-1190534594 > Is there a reason we can't enable this by default and need a config? Hi @KKcorps thanks for reviewing. I think `snapshotEnabled` can be used as a config field similiar to "nullHand

[GitHub] [pinot] saurabhd336 closed pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
saurabhd336 closed pull request #9074: Change indexing exception log level to debug URL: https://github.com/apache/pinot/pull/9074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] saurabhd336 commented on pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
saurabhd336 commented on PR #9074: URL: https://github.com/apache/pinot/pull/9074#issuecomment-1190509274 I'm realising that the `NullValueTransformer` class transforms incoming null values to the default null value for the FieldType. String null values are changed to string "null". The log

[GitHub] [pinot] codecov-commenter commented on pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
codecov-commenter commented on PR #9072: URL: https://github.com/apache/pinot/pull/9072#issuecomment-1190460923 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr commented on pull request #9073: [hotfix] fix pom warnings

2022-07-20 Thread GitBox
walterddr commented on PR #9073: URL: https://github.com/apache/pinot/pull/9073#issuecomment-1190443683 > @gortiz Can you please help take a look if this is the correct way to override the jackson version. @Jackie-Jiang ^ this is not a override. it is fixing a warning ``` [WARN

[GitHub] [pinot] walterddr commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
walterddr commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925737126 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -175,10 +175,14 @@ private BrokerResponse executeSqlQuery(ObjectNode

[GitHub] [pinot] walterddr commented on pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
walterddr commented on PR #9072: URL: https://github.com/apache/pinot/pull/9072#issuecomment-1190388180 > Curious how was this leading to tears running longer ? b/c of the "Failed to meet condition in 60ms" -- This is an automated message from the Apache Git Service. To res

[GitHub] [pinot] siddharthteotia commented on pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
siddharthteotia commented on PR #9072: URL: https://github.com/apache/pinot/pull/9072#issuecomment-1190381869 > > Tests seem to be running for a lot longer than user. > > found the issue was one of the legacy PQL query options. Curious how was this leading to tears running longe

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
siddharthteotia commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925700562 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -175,10 +175,14 @@ private BrokerResponse executeSqlQuery(Object

[GitHub] [pinot] walterddr commented on pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
walterddr commented on PR #9072: URL: https://github.com/apache/pinot/pull/9072#issuecomment-1190369737 > Tests seem to be running for a lot longer than user. found the issue was one of the legacy PQL query options. -- This is an automated message from the Apache Git Service

[GitHub] [pinot] walterddr commented on pull request #9073: [hotfix] fix pom warnings

2022-07-20 Thread GitBox
walterddr commented on PR #9073: URL: https://github.com/apache/pinot/pull/9073#issuecomment-1190369155 > Spark has a very strict dependency with jackson. We can use whatever we want, but we need to ensure spark dep is under provided scope and jackson is shaded in all plugins (not just spar

[GitHub] [pinot] walterddr commented on a diff in pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
walterddr commented on code in PR #9072: URL: https://github.com/apache/pinot/pull/9072#discussion_r925688080 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -175,10 +175,14 @@ private BrokerResponse executeSqlQuery(ObjectNode

[GitHub] [pinot] somandal commented on issue #7870: Possible storage optimization for MV forward index

2022-07-20 Thread GitBox
somandal commented on issue #7870: URL: https://github.com/apache/pinot/issues/7870#issuecomment-1190310738 > I can’t access the document but was byte alignment (rounding the dictionary’s bits up to the next multiple of 8, so padding each dictionarized value with leading zeros) prior to LZ4

[GitHub] [pinot] lksvenoy-r7 opened a new pull request, #9077: Ensure conversion of field specs to avro schema is ordered

2022-07-20 Thread GitBox
lksvenoy-r7 opened a new pull request, #9077: URL: https://github.com/apache/pinot/pull/9077 This is a bug fix for the SegmentProcessorAvroUtils during the conversion of a pinot schema to an avro schema. Since the field specs are a collection, order is not guaranteed. Avro schema rely on or

[pinot] branch dependabot/maven/org.reflections-reflections-0.10.2 created (now 1319ab7d80)

2022-07-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.reflections-reflections-0.10.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1319ab7d80 Bump reflections from 0.9.11 to 0.10.2 No new revisions w

[GitHub] [pinot] dependabot[bot] opened a new pull request, #9076: Bump reflections from 0.9.11 to 0.10.2

2022-07-20 Thread GitBox
dependabot[bot] opened a new pull request, #9076: URL: https://github.com/apache/pinot/pull/9076 Bumps [reflections](https://github.com/ronmamo/reflections) from 0.9.11 to 0.10.2. Release notes Sourced from https://github.com/ronmamo/reflections/releases";>reflections's releases.

[GitHub] [pinot] richardstartin commented on pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
richardstartin commented on PR #9074: URL: https://github.com/apache/pinot/pull/9074#issuecomment-1190120631 Regarding null dictionary values, in the discussion where this was added (which was motivated by index corruption subsequent to a failed attempt to parse truncated JSON, resulting in

[GitHub] [pinot] KKcorps commented on pull request #8986: Support pause/resume consumption of realtime tables

2022-07-20 Thread GitBox
KKcorps commented on PR #8986: URL: https://github.com/apache/pinot/pull/8986#issuecomment-1190104911 @sajjad-moradi There seems to be test failure on this - ``` Error: PauseResumeConsumptionIntegrationTest.setUp:69->verifyPause:104->verify:116->assertCountStar:138 expected [9292]

[GitHub] [pinot] gortiz opened a new issue, #9075: Support extract syntax

2022-07-20 Thread GitBox
gortiz opened a new issue, #9075: URL: https://github.com/apache/pinot/issues/9075 SQL defines the [extract expression](https://modern-sql.com/feature/extract) that can be used to access components of temporal datatypes. Calcite already supports it, so when an expression includes an extract

[GitHub] [pinot] saurabhd336 commented on pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
saurabhd336 commented on PR #9074: URL: https://github.com/apache/pinot/pull/9074#issuecomment-1190030061 I assumed the metrics should help with that. Since row's fields being `null` is a valid scenario, this can (does) flood the logs. Will check and change this. I guess atleast for the dic

[GitHub] [pinot] KKcorps commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r925370537 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -215,6 +216,13 @@ public List getStarTrees() {

[GitHub] [pinot] KKcorps commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r925370537 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -215,6 +216,13 @@ public List getStarTrees() {

[GitHub] [pinot] KKcorps commented on pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

2022-07-20 Thread GitBox
KKcorps commented on PR #9062: URL: https://github.com/apache/pinot/pull/9062#issuecomment-1190024447 Is there a reason we can't enabled this by default and need a config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pinot] KKcorps closed pull request #8995: Bump derby from 10.12.1.1 to 10.14.2.0 in /pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-spark

2022-07-20 Thread GitBox
KKcorps closed pull request #8995: Bump derby from 10.12.1.1 to 10.14.2.0 in /pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-spark URL: https://github.com/apache/pinot/pull/8995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pinot] KKcorps commented on pull request #8995: Bump derby from 10.12.1.1 to 10.14.2.0 in /pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-spark

2022-07-20 Thread GitBox
KKcorps commented on PR #8995: URL: https://github.com/apache/pinot/pull/8995#issuecomment-1190006187 Deprecated module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] dependabot[bot] commented on pull request #8995: Bump derby from 10.12.1.1 to 10.14.2.0 in /pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-spark

2022-07-20 Thread GitBox
dependabot[bot] commented on PR #8995: URL: https://github.com/apache/pinot/pull/8995#issuecomment-1190006233 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [pinot] KKcorps commented on a diff in pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9051: URL: https://github.com/apache/pinot/pull/9051#discussion_r925346196 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/kafka/schemaregistry/SchemaRegistryStarter.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the

[GitHub] [pinot] KKcorps commented on a diff in pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9051: URL: https://github.com/apache/pinot/pull/9051#discussion_r925341097 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/kafka/schemaregistry/SchemaRegistryStarter.java: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the

[GitHub] [pinot] KKcorps commented on a diff in pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9051: URL: https://github.com/apache/pinot/pull/9051#discussion_r925340781 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/kafka/schemaregistry/SchemaRegistryStarter.java: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the

[GitHub] [pinot] KKcorps commented on a diff in pull request #9008: Add TLS1.3, Remove TLS1.0, Add User Agent Header, Add Timeouts for Pi…

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9008: URL: https://github.com/apache/pinot/pull/9008#discussion_r925337504 ## pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java: ## @@ -45,6 +46,12 @@ public class PinotControllerTransp

[GitHub] [pinot] KKcorps commented on pull request #9057: Bump hadoop.version from 2.10.1 to 3.3.3

2022-07-20 Thread GitBox
KKcorps commented on PR #9057: URL: https://github.com/apache/pinot/pull/9057#issuecomment-1189995718 Hadoop 3.X upgrade would require considerable code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pinot] dependabot[bot] commented on pull request #9057: Bump hadoop.version from 2.10.1 to 3.3.3

2022-07-20 Thread GitBox
dependabot[bot] commented on PR #9057: URL: https://github.com/apache/pinot/pull/9057#issuecomment-1189995212 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by a

[GitHub] [pinot] KKcorps closed pull request #9057: Bump hadoop.version from 2.10.1 to 3.3.3

2022-07-20 Thread GitBox
KKcorps closed pull request #9057: Bump hadoop.version from 2.10.1 to 3.3.3 URL: https://github.com/apache/pinot/pull/9057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pinot] KKcorps commented on pull request #9072: [UI] Add controller UI to use multi-stage engine

2022-07-20 Thread GitBox
KKcorps commented on PR #9072: URL: https://github.com/apache/pinot/pull/9072#issuecomment-1189994790 Tests seem to be running for a lot longer than user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] KKcorps commented on pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
KKcorps commented on PR #9074: URL: https://github.com/apache/pinot/pull/9074#issuecomment-1189992969 @richardstartin I was also having the same discussion. IMO, the correct way would be to just target the `null` object LOG in case of dictionary and leave everything else as it is. -- Thi

[GitHub] [pinot] KKcorps commented on pull request #9073: [hotfix] fix pom warnings

2022-07-20 Thread GitBox
KKcorps commented on PR #9073: URL: https://github.com/apache/pinot/pull/9073#issuecomment-1189990607 Spark has a very strict dependency with jackson. We can use whatever we want, but we need to ensure spark dep is under provided scope and jackson is shaded in all plugins (not just spark)

[GitHub] [pinot] KKcorps commented on pull request #9071: Add support for IAM role based credentials in Kinesis Plugin

2022-07-20 Thread GitBox
KKcorps commented on PR #9071: URL: https://github.com/apache/pinot/pull/9071#issuecomment-1189987800 I planned to add tests in Kinesis integration but unfortunately the localstack IAM service doesn't work as expected and security token fetched from it is always invalid. -- This is an au

[GitHub] [pinot] KKcorps commented on a diff in pull request #9071: Add support for IAM role based credentials in Kinesis Plugin

2022-07-20 Thread GitBox
KKcorps commented on code in PR #9071: URL: https://github.com/apache/pinot/pull/9071#discussion_r925328176 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java: ## @@ -48,6 +61,14 @@ public class KinesisCo

[GitHub] [pinot] richardstartin commented on pull request #9074: Change indexing exception log level to debug

2022-07-20 Thread GitBox
richardstartin commented on PR #9074: URL: https://github.com/apache/pinot/pull/9074#issuecomment-1189981859 If you’re trying to index JSON and that JSON gets truncated as a STRING so that it can’t be parsed, you absolutely want to log that at ERROR. -- This is an automated message from t

[GitHub] [pinot] saurabhd336 commented on pull request #9058: Task genrator debug api

2022-07-20 Thread GitBox
saurabhd336 commented on PR #9058: URL: https://github.com/apache/pinot/pull/9058#issuecomment-1189968285 @mcvsubbu @sajjad-moradi @npawar @klsince I've tried addressing the issue with the debug data being present across different controllers by letting the main controller query every other