saurabhd336 commented on code in PR #9058:
URL: https://github.com/apache/pinot/pull/9058#discussion_r926269056
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -517,7 +526,34 @@ private synchronized Map<String, String>
scheduleTasks(List<String> tableNamesWi
private String scheduleTask(PinotTaskGenerator taskGenerator,
List<TableConfig> enabledTableConfigs,
boolean isLeader) {
LOGGER.info("Trying to schedule task type: {}, isLeader: {}",
taskGenerator.getTaskType(), isLeader);
- List<PinotTaskConfig> pinotTaskConfigs =
taskGenerator.generateTasks(enabledTableConfigs);
+ List<PinotTaskConfig> pinotTaskConfigs;
+ try {
+ pinotTaskConfigs = taskGenerator.generateTasks(enabledTableConfigs);
+ for (TableConfig tableConfig : enabledTableConfigs) {
Review Comment:
Didn't get this. This method is only called for `enabledTableConfigs` i.e.
only for tables for which the particular task is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
