navina commented on PR #9071: URL: https://github.com/apache/pinot/pull/9071#issuecomment-1190635501
> I planned to add tests in Kinesis integration but unfortunately the localstack IAM service doesn't work as expected and security token fetched from it is always invalid. Ah I see. I don't think we need localstack. I just meant a quick unit test for the `KinesisConfig` class with mock instances, if needed. This shouldn't block the PR from merge. thanks for working on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
