navina commented on PR #8274:
URL: https://github.com/apache/pinot/pull/8274#issuecomment-1100589573
@0902horn Iiuc, Pinot community is trying to avoid introducing new
implementations of `StreamLevelConsumer`. Having said that, we want to
collaborate and see if we can introduce suitable abs
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2704d88732 Make execute adhoc task call async to
xiangfu0 merged PR #8555:
URL: https://github.com/apache/pinot/pull/8555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
WangCHX commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r851581470
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Founda
xiangfu0 closed pull request #8556: feature: adding sql query type into
PinotQuery struct
URL: https://github.com/apache/pinot/pull/8556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
klsince commented on code in PR #8551:
URL: https://github.com/apache/pinot/pull/8551#discussion_r851568448
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##
@@ -149,6 +149,28 @@ public Map getTaskStatesByTable(
re
jasperjiaguo commented on PR #8552:
URL: https://github.com/apache/pinot/pull/8552#issuecomment-1100495528
@siddharthteotia can you please review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 6fb7e521ef Add tracing for operator planning (#8523)
add ce0a08a49d Add connection based FailureDetector (#8491)
Jackie-Jiang merged PR #8491:
URL: https://github.com/apache/pinot/pull/8491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 87fb007f7d add scalar function for cast so it can be calculated at
compile time (#8535)
add 6fb7e521ef Add tracin
Jackie-Jiang merged PR #8523:
URL: https://github.com/apache/pinot/pull/8523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
Jackie-Jiang commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r851566824
##
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java:
##
@@ -18,21 +18,27 @@
*/
package org.apache.pinot.sql.parser
Jackie-Jiang commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1100477167
Scalar function is used in the following places:
- Ingestion transform
- Compile time evaluation of literal only function
- Post aggregation transform
- If transform fun
Jackie-Jiang commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851559445
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -73,10 +76,16 @@ public CombinePlanNode(List planNodes,
QueryContext queryContext,
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 87fb007f7d add scalar function for cast s
richardstartin merged PR #8535:
URL: https://github.com/apache/pinot/pull/8535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
richardstartin closed issue #8534: CAST function is not calculated at compile
time which prevents usage of index/metadata
URL: https://github.com/apache/pinot/issues/8534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mcvsubbu commented on code in PR #8551:
URL: https://github.com/apache/pinot/pull/8551#discussion_r851555399
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##
@@ -643,6 +650,23 @@ public String getParentTaskNam
Jackie-Jiang commented on code in PR #8555:
URL: https://github.com/apache/pinot/pull/8555#discussion_r851552088
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##
@@ -380,13 +386,16 @@ public Map scheduleTasks(@ApiParam
xiangfu0 opened a new pull request, #8556:
URL: https://github.com/apache/pinot/pull/8556
Update thrift PinotQuery struct to add SqlType field and command for further
semantics extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
codecov-commenter commented on PR #8554:
URL: https://github.com/apache/pinot/pull/8554#issuecomment-1100450383
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851541381
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -73,10 +76,16 @@ public CombinePlanNode(List planNodes,
QueryContext queryContex
codecov-commenter commented on PR #8555:
URL: https://github.com/apache/pinot/pull/8555#issuecomment-1100446174
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
PrachiKhobragade commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r851531894
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -2152,8 +2159,16 @@ static void validateRequest(PinotQue
walterddr commented on PR #8538:
URL: https://github.com/apache/pinot/pull/8538#issuecomment-1100434001
it still fails. I wonder if theres' anything wrong with the consumer itself
that it didn't pull enough data out.
alternatively I can still make the wait for condition checker in th
Jackie-Jiang commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-1100432703
@nizarhejazi Good point on the challenges of supporting `DECIMAL(p, s)`. I
think it is okay for us to add `BIG_DECIMAL` data type for arbitrary precision
and scale (-32768 to 3276
xiangfu0 opened a new pull request, #8555:
URL: https://github.com/apache/pinot/pull/8555
This call returns until the helix enqueues the task. In general, it returns
in around 15 seconds.
Changes to async to prevent the timeout.
--
This is an automated message from the Apache Git Servi
KKcorps commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851528375
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void test
KKcorps commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851528375
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void test
KKcorps opened a new pull request, #8554:
URL: https://github.com/apache/pinot/pull/8554
Also, use TestContainers instead of PulsarStandalone Java process which
starts zookeeper on CLI.
Test containers provide more functionality with respect to port mappings and
pulsar versions.
-
PrachiKhobragade commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r851526066
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -2152,8 +2159,16 @@ static void validateRequest(PinotQue
codecov-commenter commented on PR #8551:
URL: https://github.com/apache/pinot/pull/8551#issuecomment-1100425267
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8551?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
Jackie-Jiang commented on PR #8523:
URL: https://github.com/apache/pinot/pull/8523#issuecomment-1100422156
Reverted most of the changes and only keep the logic of adding tracing for
the combine plan node
--
This is an automated message from the Apache Git Service.
To respond to the messag
siddharthteotia merged PR #8479:
URL: https://github.com/apache/pinot/pull/8479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch multi_stage_query_engine
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/multi_stage_query_engine by
this push:
new 791248a3
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851520814
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/SerDeUtils.java:
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851518043
##
pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java:
##
@@ -73,17 +83,59 @@ public void tearDown() {
}
}
+ @Suppres
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851520085
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/TableScanNode.java:
##
@@ -22,8 +22,12 @@
public class TableScanNode extends Abstrac
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851518043
##
pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java:
##
@@ -73,17 +83,59 @@ public void tearDown() {
}
}
+ @Suppres
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851516735
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java:
##
@@ -46,4 +49,14 @@ public void addInput(StageNode stageNode) {
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851515959
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java:
##
@@ -46,4 +49,14 @@ public void addInput(StageNode stageNode) {
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851515414
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/serde/ProtoSerializable.java:
##
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Softwar
siddharthteotia commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r851514478
##
pinot-common/src/main/proto/plan.proto:
##
@@ -0,0 +1,94 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
Jackie-Jiang commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851513738
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -73,87 +76,33 @@ public CombinePlanNode(List planNodes,
QueryContext queryContext,
siddharthteotia commented on PR #8523:
URL: https://github.com/apache/pinot/pull/8523#issuecomment-1100385289
Please take a look at the NPE in test failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
siddharthteotia commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851506665
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -73,87 +76,33 @@ public CombinePlanNode(List planNodes,
QueryContext queryConte
siddharthteotia commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851505449
##
pinot-core/src/main/java/org/apache/pinot/core/operator/BaseOperator.java:
##
@@ -35,7 +35,7 @@ public final T nextBlock() {
if (Thread.interrupted()) {
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 05a7f28b73 don't snapshot environment in ConfigUtils (#8548)
add 734d203a50 Fix BigDecimal ser/de on negative
siddharthteotia merged PR #8553:
URL: https://github.com/apache/pinot/pull/8553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
vvivekiyer commented on PR #8491:
URL: https://github.com/apache/pinot/pull/8491#issuecomment-1100345080
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
codecov-commenter commented on PR #8553:
URL: https://github.com/apache/pinot/pull/8553#issuecomment-1100318128
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
snleee commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r851439939
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -363,7 +363,13 @@ private BrokerResponseNative handleSQLRequest(lo
sajjad-moradi commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r851431724
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/ReplicaGroupInstanceSelector.java:
##
@@ -49,15 +50,26 @@ public ReplicaGroupInstanceS
Jackie-Jiang opened a new pull request, #8553:
URL: https://github.com/apache/pinot/pull/8553
Fix the bug in BigDecimal deserialization where negative scale will be read
as positive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
codecov-commenter commented on PR #8552:
URL: https://github.com/apache/pinot/pull/8552#issuecomment-1100292198
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
jasperjiaguo opened a new pull request, #8552:
URL: https://github.com/apache/pinot/pull/8552
Old azure-identity conflicts with netty 4.1.74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
klsince opened a new pull request, #8551:
URL: https://github.com/apache/pinot/pull/8551
add two minion tasks related endpoints to allow GET and DELETE
/tasks/{taskType}/{tableNameWithType}/metadata
--
This is an automated message from the Apache Git Service.
To respond to the messag
PrachiKhobragade commented on PR #8550:
URL: https://github.com/apache/pinot/pull/8550#issuecomment-1100262065
Please Review @sajjad-moradi @snleee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jackjlli commented on code in PR #8506:
URL: https://github.com/apache/pinot/pull/8506#discussion_r851407420
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HelixZNodeSizeLimitTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Fou
PrachiKhobragade opened a new pull request, #8550:
URL: https://github.com/apache/pinot/pull/8550
In case when the routingConfig is replicaGroup, user can provide an option to
fan out a query to x replicaGroups where 1 <= x <= replicaGroups so that more
resources could be used for an ex
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 612b173880 Upgrade Helix to 1.0.2
add fce772482a Upgrade Helix to 1.0.2
This update added new revisions after un
jackjlli commented on code in PR #8506:
URL: https://github.com/apache/pinot/pull/8506#discussion_r851392902
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HelixZNodeSizeLimitTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Fou
walterddr commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851349057
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void te
KKcorps commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851344097
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void test
KKcorps commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851344097
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void test
KKcorps commented on code in PR #8538:
URL: https://github.com/apache/pinot/pull/8538#discussion_r851301660
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##
@@ -273,13 +269,31 @@ public void test
Airliquide76 opened a new issue, #8549:
URL: https://github.com/apache/pinot/issues/8549
I face an error linked to cols name I think.
Version used 10.0.0
When I set a filter config with the folowing schema part :
`"filterConfig":{
"filterFunction": "Gr
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r851237556
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/ControllerRequestURLBuilder.java:
##
@@ -16,7 +16,7 @@
* specific language governing permissions and limitation
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r851237132
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/UpdatableBrokerCache.java:
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Founda
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r851237004
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCacheUpdaterPeriodic.java:
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r851236033
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/UpdatableBrokerCache.java:
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Founda
suddendust commented on issue #8526:
URL: https://github.com/apache/pinot/issues/8526#issuecomment-1100024925
Duplicate: https://github.com/apache/pinot/issues/7771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
suddendust commented on issue #7867:
URL: https://github.com/apache/pinot/issues/7867#issuecomment-1100023514
This can be closed as it's released in 0.10.0 @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codecov-commenter commented on PR #8543:
URL: https://github.com/apache/pinot/pull/8543#issuecomment-119349
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 05a7f28b73 don't snapshot environment in ConfigU
xiangfu0 merged PR #8548:
URL: https://github.com/apache/pinot/pull/8548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
codecov-commenter commented on PR #8548:
URL: https://github.com/apache/pinot/pull/8548#issuecomment-1099968823
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
nizarhejazi commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-1099926108
@Jackie-Jiang Supporting fixed-precision BigDecimal w/ configurable
precision and scale (`DECIMAL(p, s)`) is a big intake and requires:
- Optimizing storage based on differen
xiangfu0 closed pull request #8545: Refactor ControllerRequestClient from
pinot-controller to pinot-common module
URL: https://github.com/apache/pinot/pull/8545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
xiangfu0 commented on PR #8545:
URL: https://github.com/apache/pinot/pull/8545#issuecomment-1099925791
Seems like a duplicate of https://github.com/apache/pinot/pull/8467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
80 matches
Mail list logo