richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851541381
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##########
@@ -73,10 +76,16 @@ public CombinePlanNode(List<PlanNode> planNodes,
QueryContext queryContext, Exec
_streamObserver = streamObserver;
}
- @SuppressWarnings({"rawtypes", "unchecked"})
@Override
public BaseCombineOperator run() {
+ try (InvocationScope scope =
Tracing.getTracer().createScope(CombinePlanNode.class)) {
+ return getCombineOperator(scope);
+ }
+ }
+
+ private BaseCombineOperator getCombineOperator(InvocationScope scope) {
Review Comment:
It’s interesting - my intention in creating separate interfaces for
lifecycle management and data capture was so the interface for data capture
could be passed around without worrying whether the scope got closed somewhere
(without downcasting that is, someone would have to go out of their way to
close a scope safely if they receive InvocationRecording) - perhaps the intent
was not clear. Not that it’s particularly important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
