siddharthteotia commented on code in PR #8479: URL: https://github.com/apache/pinot/pull/8479#discussion_r851514478
########## pinot-common/src/main/proto/plan.proto: ########## @@ -0,0 +1,94 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +syntax = "proto3"; + +package org.apache.pinot.common.proto; + +message StageNode { + int32 stageId = 1; + string nodeName = 2; + repeated StageNode inputs = 3; + ObjectField objectField = 4; +} + +// MemberVariableField defines the serialized format of the member variables of a class object. +// MemberVariableField can be one of +// 1. literal +// 2. list +// 3. map +// 4. complex class object +message MemberVariableField { + oneof member_variable_field { + LiteralField literalField = 1; + ListField listField = 2; + MapField mapField = 3; + ObjectField objectField = 4; + } +} + +// ObjectField defines the serialized format of a complex class object. +// it contains: +// 1. its fully-qualified clazz name; +// 2. its MemberVariableField map. +message ObjectField { + string objectClassName = 1; + map<string, MemberVariableField> memberVariables = 2; +} + +// LiteralField defines the serialized format of a literal field. +message LiteralField { + oneof literal_field { + bool boolField = 1; + int32 intField = 2; + int64 longField = 3; + double doubleField = 4; Review Comment: capture float as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
