atris commented on PR #8384:
URL: https://github.com/apache/pinot/pull/8384#issuecomment-1088335458
> here
I am hesitant to add a new function just for the regex matching. I like your
suggestion around CONTAINS, will add that for the same, and a new function for
phrase matching when
vvivekiyer commented on issue #8039:
URL: https://github.com/apache/pinot/issues/8039#issuecomment-1088254137
Sure, I can pick this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
siddharthteotia commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1088250124
@Jackie-Jiang / @KKcorps / @jadami10 are you planning to work on this ?
If not, @vvivekiyer can help pick it up as he is familiarizing himself
through the code
--
Thi
siddharthteotia commented on issue #8039:
URL: https://github.com/apache/pinot/issues/8039#issuecomment-1088249580
@vvivekiyer as discussed please pick this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 2be28a2d67 Upgrade Helix to 1.0.2
add d458d8eadd Upgrade Helix to 1.0.2
This update added new revisions after un
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 164b7a4cd0 Adding Github Actions to build Pinot/
xiangfu0 merged PR #8458:
URL: https://github.com/apache/pinot/pull/8458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
siddharthteotia commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1088192725
Nice. @KKcorps I had created a similar issue around this but was specific to
Arrow flight protocol (which is based on arrow wire format over grpc) to
especially cater to non JV
mayankshriv commented on issue #3851:
URL: https://github.com/apache/pinot/issues/3851#issuecomment-1088172122
+1, if you are interested @BlackDemonZyT , we can guide you to build this
feature in Pinot.
--
This is an automated message from the Apache Git Service.
To respond to the messag
kishoreg commented on issue #3851:
URL: https://github.com/apache/pinot/issues/3851#issuecomment-1088166430
@BlackDemonZyT will you be interested in contributing to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on code in PR #8355:
URL: https://github.com/apache/pinot/pull/8355#discussion_r842244228
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertCapacityEstimationRestletResource.java:
##
@@ -0,0 +1,134 @@
+/**
+ * Licensed
Jackie-Jiang commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1088151917
@KKcorps Good solution! We can re-write the filter expression if the
underlying predicate does not have `FilterKind` as the function. Pinot supports
`WHERE A = true`
--
This is
Jackie-Jiang commented on issue #3851:
URL: https://github.com/apache/pinot/issues/3851#issuecomment-1088149605
Not yet. We might need to keep all values in order to compute these
statistics, and that can be very costly. Is there any approximation data
structure we can leverage to avoid kee
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit dbd3f00d9e Upgrade Helix to 1.0.2
add 2be28a2d67 Upgrade Helix to 1.0.2
This update added new revisions after un
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 2c2c1137c8 Upgrade Helix to 1.0.2
add dbd3f00d9e Upgrade Helix to 1.0.2
This update added new revisions after un
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/dev by this push:
new d6bcec1 0.10.0 announcement blog post edit (#73)
xiangfu0 merged PR #73:
URL: https://github.com/apache/pinot-site/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 99f17ce9ab Upgrade Helix to 1.0.2
add 2c2c1137c8 Upgrade Helix to 1.0.2
This update added new revisions after un
kbastani opened a new pull request, #73:
URL: https://github.com/apache/pinot-site/pull/73
Fixed an attribute reference to the author of the blog post. Thanks
@mneedham!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 249a3a7 remove notification from .asf.
An error occurred while running notifications feature in .asf.yaml!:
Invalid notification target 'notificati...@pinot.apache.org'. Must be a valid
@pinot.apache.org list!
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
An error occurred while running notifications feature in .asf.yaml!:
Invalid notification target 'notificati...@pinot.apache.org'. Must be a valid
@pinot.apache.org list!
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 7231287 Update publish website script
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/dev by this push:
new 0b5afd1 Pinot 0.10.0 Announcement (#72)
0b5afd1
xiangfu0 merged PR #72:
URL: https://github.com/apache/pinot-site/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
Jackie-Jiang commented on code in PR #8398:
URL: https://github.com/apache/pinot/pull/8398#discussion_r842191694
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##
@@ -53,6 +53,8 @@
private SegmentPartitionConfig _segmentPartitionConfig;
p
Jackie-Jiang commented on PR #8441:
URL: https://github.com/apache/pinot/pull/8441#issuecomment-1088071346
> Yes I agree that ideally we want to rely on the determinism of selection
algorithm to deduce the vacant and pool id of down servers, without preserving
any state. But IMO storing RG
Jackie-Jiang commented on code in PR #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r842144361
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##
@@ -50,16 +50,17 @@
private final List _indexTypes;
private final CompressionC
kbastani opened a new pull request, #72:
URL: https://github.com/apache/pinot-site/pull/72
The PR adds a blog post for the Pinot 0.10.0 announcement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jasperjiaguo commented on PR #8441:
URL: https://github.com/apache/pinot/pull/8441#issuecomment-1088042522
> We assign the servers in the following steps:
>
> 1. Pick the pools for the table based on the tenant and pool config
> 2. Apply the constraint to the servers if any
> 3.
Jackie-Jiang commented on PR #8384:
URL: https://github.com/apache/pinot/pull/8384#issuecomment-1088009720
> Here is the plan -- LIKE is going to start using text indices if
available, thus providing support for LIKE on native indices + logical
operators come free due to the ability to comb
Jackie-Jiang closed pull request #8464: Optimize single element ArrayList
creation
URL: https://github.com/apache/pinot/pull/8464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Jackie-Jiang commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1088001276
Since the perf number is so close, probably not worth the effort of
maintaining the code
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
KKcorps commented on code in PR #8017:
URL: https://github.com/apache/pinot/pull/8017#discussion_r842127875
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java:
##
@@ -124,19 +127,28 @@ public
snleee commented on PR #8462:
URL: https://github.com/apache/pinot/pull/8462#issuecomment-1087990840
I have one general comment before reviewing the code.
Currently, our old and new configs look like the following:
```
Current config:
"tableIndexConfig": {
"ag
KKcorps commented on code in PR #8017:
URL: https://github.com/apache/pinot/pull/8017#discussion_r842119590
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java:
##
@@ -80,16 +84,15 @@ public S
codecov-commenter commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1087986944
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
xiangfu0 commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1087979495
The issue here is that we need to perform a recursive check for expression
override.
If not changing this to a mutable single array list, then we need to check
if the list is immutable
richardstartin commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1087975492
This appears to amount to a slight regression, at least it's in the noise,
on a tiny baseline cost:
```java
@State(Scope.Benchmark)
public class OneElementList {
richardstartin commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1087962081
Do we have any measurements which indicate this is worthwhile? This sort of
thing can be surprising.
--
This is an automated message from the Apache Git Service.
To respond to the
FelixGV commented on PR #8464:
URL: https://github.com/apache/pinot/pull/8464#issuecomment-1087952792
Would it not be more optimal to return just `Collections.singletonList(e)`
rather than wrapping the one element in an `ArrayList`? Memory-wise, the
singleton list should have less memory ov
Jackie-Jiang opened a new pull request, #8464:
URL: https://github.com/apache/pinot/pull/8464
Replace `new ArrayList<>(Collections.singletonList(e))` with a util function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on issue #7849:
URL: https://github.com/apache/pinot/issues/7849#issuecomment-1087920424
@mayankshriv The routing issue is not solved yet, so let's keep the issue
open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jackie-Jiang commented on PR #8441:
URL: https://github.com/apache/pinot/pull/8441#issuecomment-1087919194
We assign the servers in the following steps:
1. Pick the pools for the table based on the tenant and pool config
2. Apply the constraint to the servers if any
3. Map each repli
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch retain-instance-sequence
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit a8dec889f2 Add retainInstancesSequence feature to table rebalance to
minimize data movement between in
sajjad-moradi commented on code in PR #8455:
URL: https://github.com/apache/pinot/pull/8455#discussion_r841990120
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -1,30 +1,15 @@
-## Description
-
-## Upgrade Notes
-Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
saurabhd336 closed pull request #8463: Client controller broker selector
URL: https://github.com/apache/pinot/pull/8463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
saurabhd336 opened a new pull request, #8463:
URL: https://github.com/apache/pinot/pull/8463
## Description
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **backward-incompat**
richardstartin commented on code in PR #8457:
URL: https://github.com/apache/pinot/pull/8457#discussion_r841931455
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Phase.java:
##
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
KKcorps commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1087739081
@Jackie-Jiang Should we go with re-writing the query `WHERE A` to `WHERE A
IS TRUE` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
richardstartin commented on PR #8457:
URL: https://github.com/apache/pinot/pull/8457#issuecomment-1087729885
> thanks for creating this tracing SPI, Richard.
>
> is the following assumption correct?
>
> * the `operatorInvocationTrace` interface is used to set extra properties
(
walterddr commented on code in PR #8457:
URL: https://github.com/apache/pinot/pull/8457#discussion_r841863814
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Phase.java:
##
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more con
mayankshriv commented on PR #8461:
URL: https://github.com/apache/pinot/pull/8461#issuecomment-1087696367
@shahsank3t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
noon-stripe opened a new pull request, #8462:
URL: https://github.com/apache/pinot/pull/8462
## Description
This PR adds Ingestion Aggregation. The design doc can be found
[here](https://github.com/apache/pinot/issues/8360).
This feature aggregates values at ingestion time, wh
saurabhd336 opened a new pull request, #8461:
URL: https://github.com/apache/pinot/pull/8461
Upgrade needed to be able to build pinot-controller on mac M1
https://github.com/eirslett/frontend-maven-plugin/issues/952#issuecomment-762163294
## Description
## Upgrade Notes
D
KKcorps commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1087519542
I have created a brief design doc for this. We can sort out all the
questions there.
https://docs.google.com/document/d/1NzVLYhO4frmBOfu6tDaVzu0aWsDGquzsIml2kittS04/edit?usp=sharing
BlackDemonZyT commented on issue #3851:
URL: https://github.com/apache/pinot/issues/3851#issuecomment-1087410058
Someone did this? I'm also interested in getting standard deviation in a
pinot query.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
stym06 closed issue #8460: Null in all columns on Batch ingesting ORC data from
S3
URL: https://github.com/apache/pinot/issues/8460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
stym06 commented on issue #8460:
URL: https://github.com/apache/pinot/issues/8460#issuecomment-1087396255
Thanks @KKcorps . changing the column names worked!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
KKcorps commented on issue #8460:
URL: https://github.com/apache/pinot/issues/8460#issuecomment-1087364095
Schema fields do not seem to match ORC field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r841564584
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/AccessControlFactory.java:
##
@@ -29,6 +31,7 @@
public static final String ACCESS_CONTROL_CLASS_CONFIG
stym06 opened a new issue, #8460:
URL: https://github.com/apache/pinot/issues/8460
Hey guys,
I've been trying to ingest data stored on S3 in ORC format using the Pinot
ingestor with the below command:
`./pinot-admin.sh LaunchDataIngestionJob -jobSpecFile
batch-job-standalone-spec.yaml
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r841550355
##
pinot-core/src/main/java/org/apache/pinot/server/access/BasicAuthAccessFactory.java:
##
@@ -37,10 +40,16 @@
private AccessControl _accessControl;
+ @Overri
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r841527543
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java:
##
@@ -55,10 +57,16 @@ public BasicAuthAccessControlFactory() {
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r841517137
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/AllowAllAccessControlFactory.java:
##
@@ -34,6 +36,10 @@ public AllowAllAccessControlFactory() {
publi
atris commented on PR #8384:
URL: https://github.com/apache/pinot/pull/8384#issuecomment-1087251360
> Ping to see how do we want to move forward ?
Here is the plan -- LIKE is going to start using text indices if available,
thus providing support for LIKE on native indices + logical op
66 matches
Mail list logo
