INNOCENT-BOY commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r841564584
########## pinot-broker/src/main/java/org/apache/pinot/broker/broker/AccessControlFactory.java: ########## @@ -29,6 +31,7 @@ public static final String ACCESS_CONTROL_CLASS_CONFIG = "class"; public abstract void init(PinotConfiguration confguration); + public abstract void init(ZkHelixPropertyStore<ZNRecord> propertyStore); Review Comment: I think your suggestion is more rational. I have accepted your suggestion. Please check it again. ########## pinot-broker/src/main/java/org/apache/pinot/broker/broker/AccessControlFactory.java: ########## @@ -29,6 +31,7 @@ public static final String ACCESS_CONTROL_CLASS_CONFIG = "class"; public abstract void init(PinotConfiguration confguration); + public abstract void init(ZkHelixPropertyStore<ZNRecord> propertyStore); Review Comment: I think your suggestion is more rational. I have accepted your suggestion. Please review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
