richardstartin commented on PR #8457: URL: https://github.com/apache/pinot/pull/8457#issuecomment-1087729885
> thanks for creating this tracing SPI, Richard. > > is the following assumption correct? > > * the `operatorInvocationTrace` interface is used to set extra properties (other than Operator clazz) for the trace; therefore there will be more info to log when calling `TraceContext.logTime/Info`. > * I am assuming the log will always occur when the close() method of the Span is being called Yes, operators set fields on the trace when they know how to compute them. This requires modification of the operators themselves which I haven’t done yet. If the trace doesn’t store the values, they should get optimised away as dead code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
