[pinot] branch master updated (2d809ff -> 449cb72)

2022-03-21 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 2d809ff Fix the missing NOT handling (#8366) add 449cb72 Invoke MetadataEventNotifier on schema delete (#8368)

[pinot] branch master updated: Invoke MetadataEventNotifier on schema delete (#8368)

2022-03-21 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 449cb72 Invoke MetadataEventNotifier on schema de

[GitHub] [pinot] snleee merged pull request #8368: Invoke MetadataEventNotifier on schema delete

2022-03-21 Thread GitBox
snleee merged pull request #8368: URL: https://github.com/apache/pinot/pull/8368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pinot] codecov-commenter commented on pull request #8368: Invoke MetadataEventNotifier on schema delete

2022-03-21 Thread GitBox
codecov-commenter commented on pull request #8368: URL: https://github.com/apache/pinot/pull/8368#issuecomment-1074577493 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8368?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8380: Change default memory allocation for consuming segments from on-heap to off-heap

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8380: URL: https://github.com/apache/pinot/pull/8380#issuecomment-1074565316 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8380?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] nizarhejazi commented on issue #8374: Skip inbuilt DateTime functions used in transformConfigs, and mark the value as null in the null index when the input column value is null and th

2022-03-21 Thread GitBox
nizarhejazi commented on issue #8374: URL: https://github.com/apache/pinot/issues/8374#issuecomment-1074569595 PR to fix this issue for inbuilt datetime functions: https://github.com/apache/pinot/pull/8382 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pinot] nizarhejazi opened a new pull request #8382: builtin datetime functions to avoid throwing NullPointerException when input value is null

2022-03-21 Thread GitBox
nizarhejazi opened a new pull request #8382: URL: https://github.com/apache/pinot/pull/8382 ## Description PR to fix github issue: https://github.com/apache/pinot/issues/8374 Add an annotation for DateTime functions that cannot take null, and just return null when the function is

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831672027 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8380: Change default memory allocation for consuming segments from on-heap to off-heap

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8380: URL: https://github.com/apache/pinot/pull/8380#issuecomment-1074565316 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8380?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8380: Change default memory allocation for consuming segments from on-heap to off-heap

2022-03-21 Thread GitBox
codecov-commenter commented on pull request #8380: URL: https://github.com/apache/pinot/pull/8380#issuecomment-1074565316 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8380?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831672027 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831662915 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831662915 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831662264 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -458,13 +460,42 @@ public boolean routingExists(String

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831643170 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -82,7 +83,7 @@ * TODO: Expose RoutingEntry class

[GitHub] [pinot] mayankshriv opened a new pull request #8380: Change default memory allocation for consuming segments from on-heap to off-heap

2022-03-21 Thread GitBox
mayankshriv opened a new pull request #8380: URL: https://github.com/apache/pinot/pull/8380 ## Description It has been observed as well as established across several production deployments that allocating consuming segments off-heap is better than allocating on-heap. - Mod

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831642318 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831642318 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] walterddr commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831641070 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -458,13 +460,42 @@ public boolean routingExists(String

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831635299 ## File path: pinot-core/src/main/java/org/apache/pinot/core/routing/RouteManager.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] Jackie-Jiang commented on pull request #7971: Fix to query inconsistencies under heavy upsert load (resolves #7958)

2022-03-21 Thread GitBox
Jackie-Jiang commented on pull request #7971: URL: https://github.com/apache/pinot/pull/7971#issuecomment-1074537202 Please also take a look at the approach in #8018. Even though it is practically the same, snapshotting in `run()` is cleaner IMO -- This is an automated message from the A

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831633502 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -458,13 +460,42 @@ public boolean routingExists(

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8379: URL: https://github.com/apache/pinot/pull/8379#discussion_r831633502 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -458,13 +460,42 @@ public boolean routingExists(

[GitHub] [pinot] mayankshriv commented on pull request #7971: Fix to query inconsistencies under heavy upsert load (resolves #7958)

2022-03-21 Thread GitBox
mayankshriv commented on pull request #7971: URL: https://github.com/apache/pinot/pull/7971#issuecomment-1074535087 Seems like we didn't conclude on this PR. @tuor713 may I request to rebase, resolve the conflicts and address any open questions/comments? We can then get this merged. cc: @J

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8378: [WIP] Scalar function for url encoding and decoding

2022-03-21 Thread GitBox
siddharthteotia commented on a change in pull request #8378: URL: https://github.com/apache/pinot/pull/8378#discussion_r831632421 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java ## @@ -94,6 +94,15 @@ public void

[GitHub] [pinot] codecov-commenter commented on pull request #8378: [WIP] Scalar function for url encoding and decoding

2022-03-21 Thread GitBox
codecov-commenter commented on pull request #8378: URL: https://github.com/apache/pinot/pull/8378#issuecomment-1074531174 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[pinot] branch master updated: Fix the missing NOT handling (#8366)

2022-03-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2d809ff Fix the missing NOT handling (#8366) 2d8

[GitHub] [pinot] Jackie-Jiang merged pull request #8366: Fix the missing NOT handling

2022-03-21 Thread GitBox
Jackie-Jiang merged pull request #8366: URL: https://github.com/apache/pinot/pull/8366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] 01/01: Upgrade Helix to 1.0.2

2022-03-21 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git commit 2da8edba8fa5fda254917ed17990145834a2d65c Author: Jack Li(Analytics Engineering) AuthorDate: Tue Mar 8 22:07:25 2022 -080

[pinot] branch helix-1.0 updated (4ff59aa -> 2da8edb)

2022-03-21 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. omit 4ff59aa Upgrade Helix to 1.0.2 new 2da8edb Upgrade Helix to 1.0.2 This update added new revisions after undoi

[pinot] branch master updated: Group by order by interning (#8376)

2022-03-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f97a23f Group by order by interning (#8376) f97a

[GitHub] [pinot] Jackie-Jiang merged pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
Jackie-Jiang merged pull request #8376: URL: https://github.com/apache/pinot/pull/8376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch helix-1.0 updated (bf3f61e -> 4ff59aa)

2022-03-21 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. discard bf3f61e Upgrade Helix to 1.0.2 add 9ed08dc Update license & notice for release 0.10.0 (#8330) add 262dc50

[GitHub] [pinot] Jackie-Jiang merged pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
Jackie-Jiang merged pull request #8029: URL: https://github.com/apache/pinot/pull/8029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8366: Fix the missing NOT handling

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8366: URL: https://github.com/apache/pinot/pull/8366#discussion_r831568667 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java ## @@ -478,6 +486,21 @@ public synchroni

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8366: Fix the missing NOT handling

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8366: URL: https://github.com/apache/pinot/pull/8366#discussion_r831568338 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java ## @@ -478,6 +486,21 @@ public synchroni

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8366: Fix the missing NOT handling

2022-03-21 Thread GitBox
xiangfu0 commented on a change in pull request #8366: URL: https://github.com/apache/pinot/pull/8366#discussion_r831519125 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java ## @@ -478,6 +486,21 @@ public synchronized

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831528011 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,477 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831525452 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,477 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831523383 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNotNullTransformFunction.java ## @@ -0,0 +1,96 @@ +/** + *

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831517930 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,477 @@ +/** + * Licensed to the Apache S

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8376: URL: https://github.com/apache/pinot/pull/8376#issuecomment-1074143697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8376: URL: https://github.com/apache/pinot/pull/8376#issuecomment-1074143697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] KKcorps closed pull request #8375: Remove secrets from job spec

2022-03-21 Thread GitBox
KKcorps closed pull request #8375: URL: https://github.com/apache/pinot/pull/8375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] KKcorps commented on pull request #8375: Remove secrets from job spec

2022-03-21 Thread GitBox
KKcorps commented on pull request #8375: URL: https://github.com/apache/pinot/pull/8375#issuecomment-1074336118 Accidentally got rebased with null handling branch. Closing this PR and opening a new one. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831475849 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,473 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831473442 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -116,7 +132,265 @@ static public Serializable getDefaultValue

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r831471705 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -217,7 +218,10 @@ private BrokerRes

[GitHub] [pinot] KKcorps commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831470109 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -165,6 +165,9 @@ private Trans

[pinot] branch master updated (764a330 -> 34002c7)

2022-03-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 764a330 Refactor Pinot http utils into HttpClient (#8329) add 34002c7 Refactor Segment creation to use Transfor

[GitHub] [pinot] Jackie-Jiang merged pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-21 Thread GitBox
Jackie-Jiang merged pull request #8364: URL: https://github.com/apache/pinot/pull/8364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] KKcorps commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831442675 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNullTransformFunction.java ## @@ -0,0 +1,97 @@ +/** + * Licensed

svn commit: r53246 - /dev/pinot/apache-pinot-0.10.0-rc0/

2022-03-21 Thread sajjad
Author: sajjad Date: Mon Mar 21 18:54:35 2022 New Revision: 53246 Log: Update apache-pinot-0.10.0-rc0 Added: dev/pinot/apache-pinot-0.10.0-rc0/ dev/pinot/apache-pinot-0.10.0-rc0/apache-pinot-0.10.0-bin.tar.gz (with props) dev/pinot/apache-pinot-0.10.0-rc0/apache-pinot-0.10.0-bin.ta

[GitHub] [pinot] KKcorps commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831441999 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNotNullTransformFunction.java ## @@ -0,0 +1,101 @@ +/** + * Lice

[GitHub] [pinot] walterddr opened a new pull request #8379: create routeTable and routeManager API

2022-03-21 Thread GitBox
walterddr opened a new pull request #8379: URL: https://github.com/apache/pinot/pull/8379 currently there's no way to get a routing table out without creating a dummy table broker request. - hoist the routing table and routing manager into pinot-core as interface. - creating a n

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831432053 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNotNullTransformFunction.java ## @@ -0,0 +1,101 @@ +/** + *

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071540686 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r831430275 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNotNullTransformFunction.java ## @@ -0,0 +1,101 @@ +/** + *

[GitHub] [pinot] Jackie-Jiang commented on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-21 Thread GitBox
Jackie-Jiang commented on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1074274131 > One more side note - If these functions are used with a table where Null handling is disabled, they assume everything is non-null. So `IS NULL` will always return `false`

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8358: New Pinot storage metrics for compressed tar.gz and table size w/o replicas

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8358: URL: https://github.com/apache/pinot/pull/8358#discussion_r831390972 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java ## @@ -101,16 +102,17 @@ public void completeSegme

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071540686 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8376: URL: https://github.com/apache/pinot/pull/8376#issuecomment-1074143697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8369: URL: https://github.com/apache/pinot/pull/8369#issuecomment-1072796262 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8369?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8375: Remove secrets from job spec

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8375: URL: https://github.com/apache/pinot/pull/8375#discussion_r831370822 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java ## @@ -288,4 +290,12 @@ public String ge

[GitHub] [pinot] walterddr commented on a change in pull request #8372: reenable highest stream offset metrics

2022-03-21 Thread GitBox
walterddr commented on a change in pull request #8372: URL: https://github.com/apache/pinot/pull/8372#discussion_r831370225 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -417,11 +418,11 @@ protected b

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8372: reenable highest stream offset metrics

2022-03-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #8372: URL: https://github.com/apache/pinot/pull/8372#discussion_r831364534 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -417,11 +418,11 @@ protecte

[pinot] branch master updated (24d4fd2 -> 764a330)

2022-03-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 24d4fd2 fix checkstyle (#8377) add 764a330 Refactor Pinot http utils into HttpClient (#8329) No new revisions

[GitHub] [pinot] Jackie-Jiang merged pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-21 Thread GitBox
Jackie-Jiang merged pull request #8329: URL: https://github.com/apache/pinot/pull/8329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jasperjiaguo opened a new pull request #8378: Scalar function for url encoding and decoding

2022-03-21 Thread GitBox
jasperjiaguo opened a new pull request #8378: URL: https://github.com/apache/pinot/pull/8378 ## Description Add scalar functions to perform url encoding and decoding in queries. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broke

[GitHub] [pinot] codecov-commenter commented on pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
codecov-commenter commented on pull request #8376: URL: https://github.com/apache/pinot/pull/8376#issuecomment-1074143697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] noon-stripe commented on pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

2022-03-21 Thread GitBox
noon-stripe commented on pull request #8369: URL: https://github.com/apache/pinot/pull/8369#issuecomment-1074092447 @Jackie-Jiang I've updated according to your recommendation. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pinot] branch master updated: fix checkstyle (#8377)

2022-03-21 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 24d4fd2 fix checkstyle (#8377) 24d4fd2 i

[GitHub] [pinot] richardstartin merged pull request #8377: fix checkstyle

2022-03-21 Thread GitBox
richardstartin merged pull request #8377: URL: https://github.com/apache/pinot/pull/8377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] richardstartin opened a new pull request #8377: fix checkstyle

2022-03-21 Thread GitBox
richardstartin opened a new pull request #8377: URL: https://github.com/apache/pinot/pull/8377 Fixes checkstyle error (the rule was applied after the change was implemented) merged in #8133 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831197249 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -164,7 +164,7 @@ prote

[GitHub] [pinot] richardstartin opened a new pull request #8376: Group by order by interning

2022-03-21 Thread GitBox
richardstartin opened a new pull request #8376: URL: https://github.com/apache/pinot/pull/8376 Caches raw values extracted from dictionaries in ND group-by/order-by queries where N > 1 for low cardinality columns. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-21 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831090957 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -164,7 +164,7 @

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831080942 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TruncateDecimalTransformFunction.java ## @@ -0,0 +1,98 @@ +/** + *

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831080360 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -161,4 +161,55 @@ prot

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8343: Timestamp type index

2022-03-21 Thread GitBox
codecov-commenter edited a comment on pull request #8343: URL: https://github.com/apache/pinot/pull/8343#issuecomment-1065843913 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-21 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831053899 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Licensed

[pinot] branch master updated: Refresh ZK metadata when dimension table is updated (#8133)

2022-03-21 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 681da61 Refresh ZK metadata when dimensi

[GitHub] [pinot] richardstartin merged pull request #8133: Refresh ZK metadata when dimension table is updated

2022-03-21 Thread GitBox
richardstartin merged pull request #8133: URL: https://github.com/apache/pinot/pull/8133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] KKcorps opened a new pull request #8375: Remove secrets from job spec

2022-03-21 Thread GitBox
KKcorps opened a new pull request #8375: URL: https://github.com/apache/pinot/pull/8375 This PR addresses the issue #8363 We may need to make changes at other places as well where auth token is going into logs. I have also switched the output format to JSON instead of YAML as we alr