KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r831053899
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ########## @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.transform.function; + +import com.google.common.base.Preconditions; +import java.util.List; +import java.util.Map; +import org.apache.pinot.core.operator.blocks.ProjectionBlock; +import org.apache.pinot.core.operator.transform.TransformResultMetadata; +import org.apache.pinot.core.plan.DocIdSetPlanNode; +import org.apache.pinot.segment.spi.datasource.DataSource; + + +public class PowerTransformFunction extends BaseTransformFunction { + public static final String FUNCTION_NAME = "power"; + private double[] _result; + private TransformFunction _leftTransformFunction; + private TransformFunction _rightTransformFunction; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) { + // Check that there are more than 1 arguments + if (arguments.size() != 2) { + throw new IllegalArgumentException("Exactly 2 arguments are required for power transform function"); + } + + _leftTransformFunction = arguments.get(0); + _rightTransformFunction = arguments.get(1); + Preconditions.checkArgument( + _leftTransformFunction.getResultMetadata().isSingleValue() || _rightTransformFunction.getResultMetadata() + .isSingleValue(), "Argument must be single-valued for transform function: %s", getName()); + } + + @Override + public TransformResultMetadata getResultMetadata() { + return DOUBLE_SV_NO_DICTIONARY_METADATA; + } + + @Override + public double[] transformToDoubleValuesSV(ProjectionBlock projectionBlock) { + if (_result == null) { + _result = new double[DocIdSetPlanNode.MAX_DOC_PER_CALL]; Review comment: For now, I have made this change in the classes which are under scope of this PR. I will raise a seperate PR for the rest of the functions. I want to know the reason though, why was it done this way. Maybe we are missing something? ########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ########## @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.transform.function; + +import com.google.common.base.Preconditions; +import java.util.List; +import java.util.Map; +import org.apache.pinot.core.operator.blocks.ProjectionBlock; +import org.apache.pinot.core.operator.transform.TransformResultMetadata; +import org.apache.pinot.core.plan.DocIdSetPlanNode; +import org.apache.pinot.segment.spi.datasource.DataSource; + + +public class PowerTransformFunction extends BaseTransformFunction { + public static final String FUNCTION_NAME = "power"; + private double[] _result; + private TransformFunction _leftTransformFunction; + private TransformFunction _rightTransformFunction; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) { + // Check that there are more than 1 arguments + if (arguments.size() != 2) { + throw new IllegalArgumentException("Exactly 2 arguments are required for power transform function"); + } + + _leftTransformFunction = arguments.get(0); + _rightTransformFunction = arguments.get(1); + Preconditions.checkArgument( + _leftTransformFunction.getResultMetadata().isSingleValue() || _rightTransformFunction.getResultMetadata() + .isSingleValue(), "Argument must be single-valued for transform function: %s", getName()); + } + + @Override + public TransformResultMetadata getResultMetadata() { + return DOUBLE_SV_NO_DICTIONARY_METADATA; + } + + @Override + public double[] transformToDoubleValuesSV(ProjectionBlock projectionBlock) { + if (_result == null) { + _result = new double[DocIdSetPlanNode.MAX_DOC_PER_CALL]; + } + + int length = projectionBlock.getNumDocs(); + double[] leftValues = _leftTransformFunction.transformToDoubleValuesSV(projectionBlock); + double[] rightValues = _rightTransformFunction.transformToDoubleValuesSV(projectionBlock); + for (int i = 0; i < length; i++) { + _result[i] = Math.pow(leftValues[i], rightValues[i]); Review comment: done ########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.transform.function; + +import com.google.common.base.Preconditions; +import java.math.BigDecimal; +import java.math.RoundingMode; +import java.util.List; +import java.util.Map; +import org.apache.pinot.core.operator.blocks.ProjectionBlock; +import org.apache.pinot.core.operator.transform.TransformResultMetadata; +import org.apache.pinot.core.plan.DocIdSetPlanNode; +import org.apache.pinot.segment.spi.datasource.DataSource; +import org.apache.pinot.spi.data.FieldSpec; + + +//TODO: The function should ideally be named 'round' +// but it is not possible because of existing DateTimeFunction with same name. +public class RoundDecimalTransformFunction extends BaseTransformFunction { + public static final String FUNCTION_NAME = "roundDecimal"; + private double[] _result; + private TransformFunction _leftTransformFunction; + private TransformFunction _rightTransformFunction; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) { + int numArguments = arguments.size(); + // Check that there are more than 2 arguments or no arguments + if (numArguments < 1 || numArguments > 2) { + throw new IllegalArgumentException( + "roundDecimal transform function supports either 1 or 2 arguments. Num arguments provided: " + numArguments); + } + + _leftTransformFunction = arguments.get(0); + if (numArguments > 1) { + _rightTransformFunction = arguments.get(1); + Preconditions.checkArgument(_rightTransformFunction.getResultMetadata().isSingleValue() + && isArgumentDataTypeValid(_rightTransformFunction), + "Argument must be single-valued with type INT for transform function: %s", getName()); + } else { + _rightTransformFunction = null; + } + + Preconditions.checkArgument(_leftTransformFunction.getResultMetadata().isSingleValue(), + "Argument must be single-valued for transform function: %s", getName()); + } + + private boolean isArgumentDataTypeValid(TransformFunction transformFunction) { + return transformFunction.getResultMetadata().getDataType().getStoredType() == FieldSpec.DataType.INT + || transformFunction.getResultMetadata().getDataType().getStoredType() == FieldSpec.DataType.LONG; Review comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
