richardstartin commented on a change in pull request #8304:
URL: https://github.com/apache/pinot/pull/8304#discussion_r831090957
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java
##########
@@ -164,7 +164,7 @@ protected void applyMathOperator(double[] values, int
length) {
public static class Log2TransformFunction extends
SingleParamMathTransformFunction {
public static final String FUNCTION_NAME = "log2";
- public static final double LOG_BASE = Math.log(2);
+ public static final double LOG_BASE = 0.6931471805599453d;
Review comment:
This isn't necessary, the field is already `static final` so is trusted
as a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
