codecov-commenter commented on pull request #8179:
URL: https://github.com/apache/pinot/pull/8179#issuecomment-1033459586
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8179?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin closed pull request #8178:
URL: https://github.com/apache/pinot/pull/8178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
codecov-commenter commented on pull request #8178:
URL: https://github.com/apache/pinot/pull/8178#issuecomment-1033435405
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin opened a new pull request #8179:
URL: https://github.com/apache/pinot/pull/8179
Reverts apache/pinot#8160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch revert-8160-tser-threadsafe
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit e5746b0569bf9076fea893f22a85ac86824dad36
Author: Richard Startin
AuthorDate: Wed Feb 9 07:28
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a change to branch revert-8160-tser-threadsafe
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at e5746b0 Revert "Fix regression bug caused by sharing TSerializer
across multiple thread
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a change to branch
revert-8140-allocation-free-datablock-cache
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at c15bf3e Revert "Allocation free `DataBlockCache` lookups (#8140)"
This
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch
revert-8140-allocation-free-datablock-cache
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit c15bf3eeae5e8c154c36e04b484b5efc088a1f5d
Author: Richard Startin
AuthorDate
richardstartin opened a new pull request #8178:
URL: https://github.com/apache/pinot/pull/8178
Reverts apache/pinot#8140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
snleee opened a new issue #8177:
URL: https://github.com/apache/pinot/issues/8177
We are observing that the series of Task related APIs are not working.
```
$ curl localhost:9000/tasks/tasktypes
{"code":500,"error":"HTTP 500 Internal Server Error"}
```
--
This is an automa
walterddr opened a new pull request #8176:
URL: https://github.com/apache/pinot/pull/8176
this is a follow up with several previous attempt to fix segment file
deletion.
Goal
===
Add support to control segment retention period on a per-table basis.
Challenge
===
i
walterddr commented on pull request #8078:
URL: https://github.com/apache/pinot/pull/8078#issuecomment-1033340491
discussed with @Jackie-Jiang offline and we decided to change how we store
the "retention period" overwrite by appending it to the DELETED segment
filename during the move oper
walterddr closed pull request #8078:
URL: https://github.com/apache/pinot/pull/8078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
codecov-commenter edited a comment on pull request #8163:
URL: https://github.com/apache/pinot/pull/8163#issuecomment-108655
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8163:
URL: https://github.com/apache/pinot/pull/8163#issuecomment-108655
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
mqliang closed pull request #8163:
URL: https://github.com/apache/pinot/pull/8163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
codecov-commenter edited a comment on pull request #8175:
URL: https://github.com/apache/pinot/pull/8175#issuecomment-1033283462
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8175?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8175:
URL: https://github.com/apache/pinot/pull/8175#issuecomment-1033283462
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8175?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #8174:
URL: https://github.com/apache/pinot/pull/8174#issuecomment-1033255247
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8174:
URL: https://github.com/apache/pinot/pull/8174#issuecomment-1033255247
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch check-participantHistory
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at ee4f075 Check if participantHistory is null in isInstanceOfflineFor
method
This branch includes the
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch check-participantHistory
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit ee4f075d1234fba1f824cae58be06ac5e763d060
Author: Jack Li(Analytics Engineering)
AuthorDate: Tue Feb 8 17:
jackjlli opened a new pull request #8175:
URL: https://github.com/apache/pinot/pull/8175
## Description
This PR adds the logic to check whether `participantHistory` is null in
`isInstanceOfflineFor` method. If so, it denotes there is no history for this
particular participant and the in
xiangfu0 opened a new pull request #8174:
URL: https://github.com/apache/pinot/pull/8174
## Description
Adding scala profile for kafka 2.x build and remove root pom scala
dependencies
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Contro
timsants commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802181642
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/FunctionEvaluatorFactory.java
##
@@ -96,6 +96,14 @@ public static
timsants commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802175559
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##
@@ -251,6 +251,7 @@ private static long getRandomInitialDe
codecov-commenter edited a comment on pull request #8168:
URL: https://github.com/apache/pinot/pull/8168#issuecomment-1033172065
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
hristo-stripe commented on issue #8089:
URL: https://github.com/apache/pinot/issues/8089#issuecomment-1033177235
You might have to set the `groupby.trim.threshold` property as well. It's
set to 1M by default so anything above that gets trimmed at the group by
operator.
See this code
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 1382d29 Disable recursion in PinotFS copy (#8162)
add 5fa4737 do not identify function types by throwin
codecov-commenter edited a comment on pull request #8168:
URL: https://github.com/apache/pinot/pull/8168#issuecomment-1033172065
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Jackie-Jiang commented on pull request #8170:
URL: https://github.com/apache/pinot/pull/8170#issuecomment-1033172718
I just filed an issue regarding this issue, then see this PR :-P #8173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
codecov-commenter commented on pull request #8168:
URL: https://github.com/apache/pinot/pull/8168#issuecomment-1033172065
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin merged pull request #8137:
URL: https://github.com/apache/pinot/pull/8137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
codecov-commenter commented on pull request #8170:
URL: https://github.com/apache/pinot/pull/8170#issuecomment-1033169473
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
Jackie-Jiang commented on issue #8089:
URL: https://github.com/apache/pinot/issues/8089#issuecomment-1033163742
@xtrntr I just realized that `numGroupsLimitReached` might not be correctly
set in the broker response (filed #8173 to track that). To verify if the groups
limit is properly set,
Jackie-Jiang opened a new issue #8173:
URL: https://github.com/apache/pinot/issues/8173
There is a TODO in `GroupByOrderByCombineOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Jackie-Jiang opened a new pull request #8172:
URL: https://github.com/apache/pinot/pull/8172
When a query has the same mixed regular aggregation and filtered
aggregation, the index of the aggregation function is not maintained correctly.
This PR contains the following changes:
- Fix `
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1382d29 Disable recursion in PinotFS copy (#81
mcvsubbu merged pull request #8162:
URL: https://github.com/apache/pinot/pull/8162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d479ebc fix aggregation error messages (
richardstartin merged pull request #8165:
URL: https://github.com/apache/pinot/pull/8165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
Jackie-Jiang commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802124827
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##
@@ -251,6 +251,7 @@ private static long getRandomIniti
codecov-commenter edited a comment on pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#issuecomment-1033132062
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8159:
URL: https://github.com/apache/pinot/pull/8159#issuecomment-1032101657
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#issuecomment-1033132062
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
sajjad-moradi opened a new issue #8171:
URL: https://github.com/apache/pinot/issues/8171
The following document proposes a design to pause/resume consumption in
realtime tables:
https://docs.google.com/document/d/19uKzPRowJ8WLE0A4g6i8XLOBwqpswH2_OvFvbxxZ_X4/edit#
This feature
hristo-stripe commented on pull request #8170:
URL: https://github.com/apache/pinot/pull/8170#issuecomment-1033130715
How do I request review? cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hristo-stripe opened a new pull request #8170:
URL: https://github.com/apache/pinot/pull/8170
## Description
This patch correctly sets the `numGroupsLimitReached` flag in a few places
where query operators trim results. There might be more places where results
"trimming" occurs with
codecov-commenter edited a comment on pull request #8159:
URL: https://github.com/apache/pinot/pull/8159#issuecomment-1032101657
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
timsants commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802110350
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##
@@ -251,6 +251,7 @@ private static long getRandomInitialDe
timsants opened a new pull request #8169:
URL: https://github.com/apache/pinot/pull/8169
## Description
This change adds a broker config for disabling Groovy transform and filter
functions in the table ingestion config as it is a security risk. See Github
issue https://github.com/ap
xiangfu0 opened a new pull request #8168:
URL: https://github.com/apache/pinot/pull/8168
## Description
Adding main method for LaunchDataIngestionJobCommand for spark-submit command
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controlle
mcvsubbu commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r802089566
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/LocalPinotFSTest.java
##
@@ -205,41 +205,12 @@ public void testFS()
// Expect
codecov-commenter edited a comment on pull request #8167:
URL: https://github.com/apache/pinot/pull/8167#issuecomment-1033080381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8167:
URL: https://github.com/apache/pinot/pull/8167#issuecomment-1033080381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
snleee commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r802070938
##
File path:
pinot-plugins/pinot-file-system/pinot-hdfs/src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java
##
@@ -196,9 +199,21 @@ public
snleee commented on a change in pull request #8166:
URL: https://github.com/apache/pinot/pull/8166#discussion_r802017164
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -2867,7 +2867,7 @@ public String st
codecov-commenter edited a comment on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1030699838
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1030699838
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mcvsubbu commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r801990312
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java
##
@@ -143,7 +143,7 @@ long length(URI fileUri)
/**
* Copies a
jackjlli commented on a change in pull request #8166:
URL: https://github.com/apache/pinot/pull/8166#discussion_r801979192
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -3074,6 +3074,24 @@ public void r
Jackie-Jiang commented on pull request #8159:
URL: https://github.com/apache/pinot/pull/8159#issuecomment-1032967997
@amrishlal It is done on a per query basis on the broker side, which should
be fine. We already have multiple similar operations on the broker (e.g. fixing
column name, over
richardstartin commented on a change in pull request #8166:
URL: https://github.com/apache/pinot/pull/8166#discussion_r801972296
##
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
##
@@ -755,6 +755,13 @@ publi
jtao15 opened a new pull request #8166:
URL: https://github.com/apache/pinot/pull/8166
Enhance `revertReplaceSegments` api so reverting entry1 in the following
example is not allowed:
entry1: `{Seg_0 -> Seg1, COMPLETED}`
entry2: `{Seg_1 -> Seg2, COMPLETED/IN_PROGRESS}`
--
This
richardstartin commented on a change in pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#discussion_r801935690
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java
##
@@ -81,14 +88,28 @@ public String getName
Jackie-Jiang commented on a change in pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#discussion_r801898017
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java
##
@@ -81,14 +88,28 @@ public String getName()
richardstartin opened a new pull request #8165:
URL: https://github.com/apache/pinot/pull/8165
Fixes some incorrect error messages added in #8139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
richardstartin commented on a change in pull request #8139:
URL: https://github.com/apache/pinot/pull/8139#discussion_r801891875
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumAggregationFunction.java
##
@@ -54,10 +54,39 @@ public Gr
richardstartin commented on a change in pull request #8139:
URL: https://github.com/apache/pinot/pull/8139#discussion_r801891692
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java
##
@@ -54,15 +54,47 @@ public Gr
Jackie-Jiang commented on a change in pull request #8139:
URL: https://github.com/apache/pinot/pull/8139#discussion_r801886101
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java
##
@@ -54,15 +54,47 @@ public Grou
siddharthteotia opened a new issue #8164:
URL: https://github.com/apache/pinot/issues/8164
Sharing a design proposal for making Pinot Fault domain (Azure concept)
aware. We have been working on this as part of our cloud migration work. The
doc has more details on the background etc.
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 65dcfe7 Allocation free `DataBlockCache`
richardstartin merged pull request #8140:
URL: https://github.com/apache/pinot/pull/8140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
codecov-commenter edited a comment on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1030699838
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#issuecomment-1030702682
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1030699838
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#issuecomment-1030702682
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1030699838
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#issuecomment-1030702682
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
79 matches
Mail list logo
