timsants commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802110350



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -251,6 +251,7 @@ private static long getRandomInitialDelayInSeconds() {
   private static final String DEFAULT_DIM_TABLE_MAX_SIZE = "200M";
 
   private static final String DEFAULT_PINOT_FS_FACTORY_CLASS_LOCAL = 
LocalPinotFS.class.getName();
+  public static final String DISABLE_GROOVY = "controller.disable.groovy";

Review comment:
       I noticed that the configs defined in this file don't start with the 
`pinot.` prefix like how the properties are defined in CommonConstants. Should 
we make this consistent with the broker config i.e. 
`pinot.broker.disable.groovy`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to