timsants commented on a change in pull request #8169:
URL: https://github.com/apache/pinot/pull/8169#discussion_r802181642
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/FunctionEvaluatorFactory.java
##########
@@ -96,6 +96,14 @@ public static FunctionEvaluator
getExpressionEvaluator(FieldSpec fieldSpec) {
return functionEvaluator;
}
+ public static FunctionEvaluator getExpressionEvaluator(String
transformExpression, boolean disableGroovy) {
Review comment:
So are you saying that we first call `isGroovyExpression(String
transformExpression, boolean disableGroovy)` and pass the return value to the
getter? i.e.
`public static FunctionEvaluator getExpressionEvaluator(String
transformExpression, boolean isGroovyExpression)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
