[GitHub] [pinot] PrachiPrakash commented on pull request #7972: Broker Side validation for the query with aggregation and col but without group by

PrachiPrakash commented on pull request #7972: URL: https://github.com/apache/pinot/pull/7972#issuecomment-1006298232 > Just curious -- how much of a performance improvement do you see after this change? I am not saying we should not do it, but before we add a special case to the parser, i

[pinot] branch master updated: get parameters in logging statement right way round (#7963)

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f17839a get parameters in logging statement rig

[GitHub] [pinot] mayankshriv merged pull request #7963: get parameters in logging statement right way round

mayankshriv merged pull request #7963: URL: https://github.com/apache/pinot/pull/7963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pinot] dang-stripe opened a new issue #7976: Brokers getting into stuck state when interrupted during OFFLINE -> ONLINE state transition

dang-stripe opened a new issue #7976: URL: https://github.com/apache/pinot/issues/7976 We've noticed a case where brokers get stuck when they're interrupted via SIGTERM when the broker resource is transitioning from OFFLINE to ONLINE states. This seems to leave the broker in a stuck state

[GitHub] [pinot] npawar commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

npawar commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779255713 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -275,53 +278,23 @@ public void addSegmentError(Str

[GitHub] [pinot] npawar commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

npawar commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779254245 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -333,94 +306,162 @@ public void reloadSegment(Stri

[GitHub] [pinot] npawar commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

npawar commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779253080 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -333,94 +306,156 @@ public void reloadSegment(Stri

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix ByteArray datatype column metadata getMaxValue NPE bug and expose maxNumMultiValues

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix ByteArray datatype column metadata getMaxValue NPE bug and expose maxNumMultiValues

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix ByteArray datatype column metadata getMaxValue NPE bug and expose maxNumMultiValues

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7961: delete tmp- segment directories on server startup

codecov-commenter edited a comment on pull request #7961: URL: https://github.com/apache/pinot/pull/7961#issuecomment-1001682204 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] klsince commented on a change in pull request #7961: delete tmp- segment directories on server startup

klsince commented on a change in pull request #7961: URL: https://github.com/apache/pinot/pull/7961#discussion_r779152717 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -465,9 +465,7 @@ private void downlo

[GitHub] [pinot] sajjad-moradi commented on issue #7929: Performance problem in segment build

sajjad-moradi commented on issue #7929: URL: https://github.com/apache/pinot/issues/7929#issuecomment-1006095816 The PR is merged. Closing the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] sajjad-moradi closed issue #7929: Performance problem in segment build

sajjad-moradi closed issue #7929: URL: https://github.com/apache/pinot/issues/7929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] joshigaurava opened a new pull request #7975: Frontend dev proxy configuration update

joshigaurava opened a new pull request #7975: URL: https://github.com/apache/pinot/pull/7975 ## Description Proxy configuration that allows the frontend to proxy to a backend during development was broken. Updated the configuration and like before, it points to local port 9000 where Pin

[GitHub] [pinot] jadami10 commented on a change in pull request #7961: delete tmp- segment directories on server startup

jadami10 commented on a change in pull request #7961: URL: https://github.com/apache/pinot/pull/7961#discussion_r779112884 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java ## @@ -165,7 +165,7 @@ public HLRealt

[pinot] branch master updated (0df8492 -> 3c4285b)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 0df8492 faster metric scans (#7920) add 3c4285b Implement OIDC auth workflow in UI (#7121) No new revisions w

[GitHub] [pinot] apucher merged pull request #7121: Implement OIDC auth workflow in UI

apucher merged pull request #7121: URL: https://github.com/apache/pinot/pull/7121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated: faster metric scans (#7920)

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0df8492 faster metric scans (#7920) 0df8492 is

[GitHub] [pinot] mayankshriv merged pull request #7920: faster metric scans

mayankshriv merged pull request #7920: URL: https://github.com/apache/pinot/pull/7920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pinot] klsince commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779041798 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -333,94 +306,162 @@ public void reloadSegment(Str

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7972: Broker Side validation for the query with aggregation and col but without group by

codecov-commenter commented on pull request #7972: URL: https://github.com/apache/pinot/pull/7972#issuecomment-1005988906 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] klsince commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779041798 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -333,94 +306,162 @@ public void reloadSegment(Str

[GitHub] [pinot] klsince commented on a change in pull request #7969: extend SegmentDirectoryLoader interface and refactor BaseTableDataManager

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r779041798 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -333,94 +306,162 @@ public void reloadSegment(Str

[GitHub] [pinot] atris commented on pull request #7972: Broker Side validation for the query with aggregation and col but without group by

atris commented on pull request #7972: URL: https://github.com/apache/pinot/pull/7972#issuecomment-1005954218 Just curious -- how much of a performance improvement do you see after this change? I am not saying we should not do it, but before we add a special case to the parser, it would be

[GitHub] [pinot] klsince commented on a change in pull request #7961: delete tmp- segment directories on server startup

klsince commented on a change in pull request #7961: URL: https://github.com/apache/pinot/pull/7961#discussion_r778974928 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java ## @@ -363,6 +377,41 @@ private void startupServiceSt

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] sarthak77 closed pull request #7974: Noop minion task

sarthak77 closed pull request #7974: URL: https://github.com/apache/pinot/pull/7974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T