PrachiPrakash commented on pull request #7972: URL: https://github.com/apache/pinot/pull/7972#issuecomment-1006298232
> Just curious -- how much of a performance improvement do you see after this change? I am not saying we should not do it, but before we add a special case to the parser, it would be good to understand how much damage does the current approach do. @atris Thanks for having a look, this PR only prevents above type of malformed query to be validated just after compilation rather than going ahead with it fail later with 500 as marked in the issue[1] linked with tis PR. Talking about performance improvement I thinks it depends on how many this type of malformed queries which we get. Having said that I'm open to do some perf testing if it 's possible and you can point me in this direction. [1]https://github.com/apache/pinot/issues/7868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
