jadami10 commented on a change in pull request #7961:
URL: https://github.com/apache/pinot/pull/7961#discussion_r779112884
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -165,7 +165,7 @@ public HLRealtimeSegmentDataManager(final SegmentZKMetadata
segmentZKMetadata, f
_invertedIndexColumns);
_segmentEndTimeThreshold = _start +
_streamConfig.getFlushThresholdTimeMillis();
- _resourceTmpDir = new File(resourceDataDir, "_tmp");
+ _resourceTmpDir = new File(resourceDataDir, "tmp");
Review comment:
there wasn't really a good wait to access the TableDataManager from the
SegmentDataManager, so this is hardcoded for now
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -102,6 +103,10 @@ public void init(TableDataManagerConfig
tableDataManagerConfig, String instanceI
if (!_indexDir.exists()) {
Preconditions.checkState(_indexDir.mkdirs());
}
+ _resourceTmpDir = new File(_indexDir, "tmp");
Review comment:
So with this approach we
1) move the tmp files into their own tmp folder
2) create the tmp folder nested under the table's data dir
@klsince, how do you feel about this approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
