[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705932231 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] kishoreg commented on pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
kishoreg commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-916651307 > I would suggest creating a new pinot-fst module for the new FST implementation. Not sure about this.. we don't create modules at root level for other indexing. Need to t

[GitHub] [pinot] atris commented on a change in pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
atris commented on a change in pull request #7405: URL: https://github.com/apache/pinot/pull/7405#discussion_r705901413 ## File path: pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ComplexTypes.java ## @@ -719,8 +719,

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705871929 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705839273 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705839273 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #6778: URL: https://github.com/apache/pinot/pull/6778#discussion_r704772140 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -613,6 +687,16

[pinot] branch master updated (dc80d67 -> 514f469)

2021-09-09 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from dc80d67 avoid creating stateless ParseContextImpl once per jsonpath evaluation, avoid varargs allocation (#7412)

[GitHub] [pinot] apucher merged pull request #7407: Obfuscator base implementation

2021-09-09 Thread GitBox
apucher merged pull request #7407: URL: https://github.com/apache/pinot/pull/7407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7420: Introduce resultSize in IndexedTable

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7420: URL: https://github.com/apache/pinot/pull/7420#issuecomment-916508520 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7420: Introduce resultSize in IndexedTable

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7420: URL: https://github.com/apache/pinot/pull/7420#issuecomment-916508520 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7420: Introduce resultSize in IndexedTable

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7420: URL: https://github.com/apache/pinot/pull/7420#issuecomment-916508520 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-09-09 Thread GitBox
sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r705794188 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -232,13 +236,21 @@ public synchronized Status getServ

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7394: Replace MINUS(strColum1, strColumn2) with COMPARE(strColumn1,strColumn2)

2021-09-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #7394: URL: https://github.com/apache/pinot/pull/7394#discussion_r705787714 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/StringPredicateFilterOptimizer.java ## @@ -0,0 +1,127 @@ +/** +

[GitHub] [pinot] codecov-commenter commented on pull request #7420: Introduce resultSize in IndexedTable

2021-09-09 Thread GitBox
codecov-commenter commented on pull request #7420: URL: https://github.com/apache/pinot/pull/7420#issuecomment-916508520 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[pinot] branch master updated (3d28c0e -> dc80d67)

2021-09-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 3d28c0e skip .factorypath from rat (#7419) add dc80d67 avoid creating stateless ParseContextImpl once per jsonp

[GitHub] [pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] Jackie-Jiang merged pull request #7412: Reduce allocation in JSONPath evaluation

2021-09-09 Thread GitBox
Jackie-Jiang merged pull request #7412: URL: https://github.com/apache/pinot/pull/7412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7383: Add HLLSketch and HLLPlusPlus aggregate functions

2021-09-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #7383: URL: https://github.com/apache/pinot/pull/7383#discussion_r705781980 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusPlusMVAggregationFunction.java ## @@ -0,0

[pinot] branch master updated (91679c0 -> 3d28c0e)

2021-09-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 91679c0 Adding presto-pinot-driver module (#7384) add 3d28c0e skip .factorypath from rat (#7419) No new revisi

[GitHub] [pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7085: modify segment generator to not return illegal filenames

2021-09-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #7085: URL: https://github.com/apache/pinot/pull/7085#discussion_r705774287 ## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java ## @@ -52,6 +52,10 @@

[GitHub] [pinot] Jackie-Jiang merged pull request #7419: skip .factorypath from rat

2021-09-09 Thread GitBox
Jackie-Jiang merged pull request #7419: URL: https://github.com/apache/pinot/pull/7419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on issue #7404: startServiceManager() not used in StartServiceManagerCommand

2021-09-09 Thread GitBox
Jackie-Jiang commented on issue #7404: URL: https://github.com/apache/pinot/issues/7404#issuecomment-916492966 No it is not mutated, but fixed within the constructor (the port is already picked within the constructor). Alternatively we can also pick the port within the `start()` and fix th

[pinot] branch master updated (c27ae81 -> 91679c0)

2021-09-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from c27ae81 Cache ~/.m2/repository to speed up CI speed (#7408) add 91679c0 Adding presto-pinot-driver module (#73

[GitHub] [pinot] Jackie-Jiang opened a new pull request #7420: Introduce resultSize in IndexedTable

2021-09-09 Thread GitBox
Jackie-Jiang opened a new pull request #7420: URL: https://github.com/apache/pinot/pull/7420 Introduce resultSize (number of records kept after calling finish()) in IndexedTable which can be different from the trimSize. On the broker side, we only need to keep limit records in the final

[GitHub] [pinot] xiangfu0 merged pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
xiangfu0 merged pull request #7384: URL: https://github.com/apache/pinot/pull/7384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] mcvsubbu commented on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
mcvsubbu commented on pull request #6778: URL: https://github.com/apache/pinot/pull/6778#issuecomment-916483054 Please follow through promptly with the TODO and the race condition fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] xiangfu0 commented on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
xiangfu0 commented on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-916466802 fyi: @highker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] codecov-commenter commented on pull request #7419: skip .factory_path from rat

2021-09-09 Thread GitBox
codecov-commenter commented on pull request #7419: URL: https://github.com/apache/pinot/pull/7419#issuecomment-916460498 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7399: create pinot-integration-test-base module to release test-jar

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7399: URL: https://github.com/apache/pinot/pull/7399#issuecomment-914679147 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7399?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] xiangfu0 commented on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
xiangfu0 commented on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-916458250 > This will change our release pipeline steps when building an Apache release. It would be great if you can also update the documentation at https://cwiki.apache.org/confluence/d

[GitHub] [pinot] amrishlal commented on a change in pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
amrishlal commented on a change in pull request #7405: URL: https://github.com/apache/pinot/pull/7405#discussion_r705714655 ## File path: pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ComplexTypes.java ## @@ -719,8 +

[GitHub] [pinot] amrishlal commented on pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
amrishlal commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-916454905 I would suggest creating a new pinot-fst module for the new FST implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] kkrugler commented on pull request #7400: Fix classpath with plugins java 8

2021-09-09 Thread GitBox
kkrugler commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-916452102 @richardstartin - the "new" version of PluginClassLoader seems to work just fine when Pinot is running as a regular Java process. When we're loading plugins (via Hadoop's distrib

[GitHub] [pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/pinot/pull/6778#discussion_r705706889 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -613,6 +687,16

[GitHub] [pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-09-09 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/pinot/pull/6778#discussion_r705706456 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java ## @@ -796,6 +796,33 @@ public SimpleHttpResponse

[GitHub] [pinot] walterddr commented on a change in pull request #7419: skip .factory_path from rat

2021-09-09 Thread GitBox
walterddr commented on a change in pull request #7419: URL: https://github.com/apache/pinot/pull/7419#discussion_r705704533 ## File path: pom.xml ## @@ -1796,6 +1796,9 @@ .github/*.md + + + **/.factorypath Review comment:

[GitHub] [pinot] richardstartin commented on pull request #7400: Fix classpath with plugins java 8

2021-09-09 Thread GitBox
richardstartin commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-916442920 Regression testing this doesn't require running Hadoop: add a classfile with a class `com.Foo` in it to a location on disk, add the URL with `PluginClassloader.addURL` and

[GitHub] [pinot] walterddr opened a new pull request #7419: skip .factory_path from rat

2021-09-09 Thread GitBox
walterddr opened a new pull request #7419: URL: https://github.com/apache/pinot/pull/7419 .factory_path shouldn't be checked by rat plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pinot] kkrugler commented on pull request #7400: Fix classpath with plugins java 8

2021-09-09 Thread GitBox
kkrugler commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-916426906 Hi @richardstartin - yes, it's a quick fix to a regression, so I'd like to get this in for the next release. It basically restores behavior on pre-Java 9 JREs to how it was previ

[GitHub] [pinot] kishoreg commented on pull request #7399: create pinot-integration-test-base module to release test-jar

2021-09-09 Thread GitBox
kishoreg commented on pull request #7399: URL: https://github.com/apache/pinot/pull/7399#issuecomment-916424091 @kkrugler was looking for something like this. Let's document how one can use this to test pinot. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] atris commented on issue #7395: Support for Native Text Indexing in Pinot

2021-09-09 Thread GitBox
atris commented on issue #7395: URL: https://github.com/apache/pinot/issues/7395#issuecomment-916394186 No, FST and regexp automaton are the only two things - - rest of the operations will be performed by Pinot indices On Fri, 10 Sep 2021, 01:10 Kishore Gopalakrishna, ***@***.***>

[GitHub] [pinot] atris commented on pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
atris commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-916388421 Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] kishoreg commented on pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
kishoreg commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-916384652 I think he published the PR to help with the review of the design doc. As long as the PR does not get merged without the approval of the design, it should be ok. @atris c

[GitHub] [pinot] kishoreg commented on issue #7395: Support for Native Text Indexing in Pinot

2021-09-09 Thread GitBox
kishoreg commented on issue #7395: URL: https://github.com/apache/pinot/issues/7395#issuecomment-916383166 Looking at the doc and PR, it looks like only the FST is being implemented. Pinot already has the posting list and the ability to evaluate boolean expressions over posting lists. Is t

[GitHub] [pinot] Jackie-Jiang commented on issue #7413: Race conditions between segment merge/roll-up and purge (or convertToRawIndex) tasks

2021-09-09 Thread GitBox
Jackie-Jiang commented on issue #7413: URL: https://github.com/apache/pinot/issues/7413#issuecomment-916373241 I think the key to solve this problem is to keep the lineage entry longer and only remove it when the segment is already removed in the previous round of cleanup. Combine this wit

[GitHub] [pinot] siddharthteotia commented on pull request #7405: Introduce Native Text Indices (Core Functionality)

2021-09-09 Thread GitBox
siddharthteotia commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-916370107 Please give some time for design doc review. I had commented on the issue a couple of days ago to request time for review. Not sure if this has already been reviewed and a

[GitHub] [pinot] siddharthteotia commented on issue #7395: Support for Native Text Indexing in Pinot

2021-09-09 Thread GitBox
siddharthteotia commented on issue #7395: URL: https://github.com/apache/pinot/issues/7395#issuecomment-916364705 High level question After we added lucene based text index, there was FST text index added which uses Lucene FST libraries for purely regex searches as the former one too

[GitHub] [pinot] richardstartin commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705620782 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] richardstartin commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705620782 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705601492 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
xiangfu0 commented on a change in pull request #7384: URL: https://github.com/apache/pinot/pull/7384#discussion_r705616216 ## File path: .github/workflows/pinot_tests.yml ## @@ -146,3 +146,19 @@ jobs: - name: Quickstart on JDK ${{ matrix.java }} run: .github/wor

[GitHub] [pinot] mcvsubbu commented on issue #7418: Add config to change the default query row limit

2021-09-09 Thread GitBox
mcvsubbu commented on issue #7418: URL: https://github.com/apache/pinot/issues/7418#issuecomment-916318966 In general, keeping a lower number of configurations keeps a product easier to use and document. Along these lines, I think a config variable like this does not add much value to pino

[GitHub] [pinot] TT1103 opened a new issue #7418: Add config to change the default query row limit

2021-09-09 Thread GitBox
TT1103 opened a new issue #7418: URL: https://github.com/apache/pinot/issues/7418 Currently, if no LIMIT if specified, a query will only return 10 results. Add a config to change the default number. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pinot] TT1103 opened a new issue #7417: Add config to automatically generate only the dimensionsSplitOrder in star tree

2021-09-09 Thread GitBox
TT1103 opened a new issue #7417: URL: https://github.com/apache/pinot/issues/7417 Currently, we can specify enableDefaultStarTree=True, which will create a default star tree. It will automatically generate the dimensionsSplitOrder by taking the dimension columns and sorting them by cardina

[GitHub] [pinot] TT1103 opened a new issue #7416: Skip NULL values when creating star-tree

2021-09-09 Thread GitBox
TT1103 opened a new issue #7416: URL: https://github.com/apache/pinot/issues/7416 NULL values should be skipped when creating the pre-aggregated results in the star tree. @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7394: Replace MINUS(strColum1, strColumn2) with COMPARE(strColumn1,strColumn2)

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7394: URL: https://github.com/apache/pinot/pull/7394#issuecomment-912821972 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7319: Move segment download and segment reload into TableManager

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7319: URL: https://github.com/apache/pinot/pull/7319#issuecomment-901313573 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7394: Replace MINUS(strColum1, strColumn2) with COMPARE(strColumn1,strColumn2)

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7394: URL: https://github.com/apache/pinot/pull/7394#issuecomment-912821972 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] liuchang0520 opened a new issue #7415: Fix data racing issue introduced in #6778

2021-09-09 Thread GitBox
liuchang0520 opened a new issue #7415: URL: https://github.com/apache/pinot/issues/7415 #6778 introduced LLC segments deep store upload retry logic in controller periodic task. There is one potential data racing issue: during the controller periodic job setup, it scans LLC segment ZK metad

[GitHub] [pinot] richardstartin commented on issue #7414: Tracing should not rely on the system clock

2021-09-09 Thread GitBox
richardstartin commented on issue #7414: URL: https://github.com/apache/pinot/issues/7414#issuecomment-916273412 I just recalled that [JFR uses RDTSC](https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/hotspot/share/jfr/utilities/jfrTime.cpp#L58) so can measur

[GitHub] [pinot] richardstartin commented on issue #7414: Tracing should not rely on the system clock

2021-09-09 Thread GitBox
richardstartin commented on issue #7414: URL: https://github.com/apache/pinot/issues/7414#issuecomment-916270036 > `System.currentTimeMillis()` was more efficient than nanos This is the first time I have heard that and I must admit I am very skeptical about those articles' claims. On

[GitHub] [pinot] yupeng9 commented on a change in pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
yupeng9 commented on a change in pull request #7384: URL: https://github.com/apache/pinot/pull/7384#discussion_r705483414 ## File path: .github/workflows/pinot_tests.yml ## @@ -146,3 +146,19 @@ jobs: - name: Quickstart on JDK ${{ matrix.java }} run: .github/work

[GitHub] [pinot] mcvsubbu commented on issue #7414: Tracing should not rely on the system clock

2021-09-09 Thread GitBox
mcvsubbu commented on issue #7414: URL: https://github.com/apache/pinot/issues/7414#issuecomment-916248377 I had the same thought as well, way early on in Pinot development. However, when Adwait (a former pinot team member) and I researched a bit, we came across some articles that effecti

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7409: URL: https://github.com/apache/pinot/pull/7409#issuecomment-915143514 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7409?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] kishoreg commented on issue #7414: Tracing should not rely on the system clock

2021-09-09 Thread GitBox
kishoreg commented on issue #7414: URL: https://github.com/apache/pinot/issues/7414#issuecomment-916216423 Good point. We have this in many places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pinot] richardstartin opened a new issue #7414: Tracing should not rely on the system clock

2021-09-09 Thread GitBox
richardstartin opened a new issue #7414: URL: https://github.com/apache/pinot/issues/7414 There's code throughout the codebase which performs tracing of sensitive operations, such as in `BaseOperator`: ```java @Override public final T nextBlock() { if (Thread.interru

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705396060 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705391729 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] richardstartin commented on pull request #7400: Fix classpath with plugins java 8

2021-09-09 Thread GitBox
richardstartin commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-915962900 Rather than add another illegal reflective access to the codebase, can we take a step back? Why do we need to add the URL to `PluginClassLoader`'s `ClassLoader`? Presumably

[GitHub] [pinot] richardstartin commented on a change in pull request #7400: Fix classpath with plugins java 8

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7400: URL: https://github.com/apache/pinot/pull/7400#discussion_r705193813 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginClassLoader.java ## @@ -31,27 +32,53 @@ public class PluginClassLoader exte

[GitHub] [pinot] richardstartin commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705168129 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionConstants.java ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] richardstartin commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705166716 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] richardstartin commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705165725 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/JsonPathMapCache.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Ferrari6 commented on a change in pull request #7409: Fix JSONPath cache inefficient issue

2021-09-09 Thread GitBox
Ferrari6 commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705099616 ## File path: pinot-common/src/test/java/org/apache/pinot/common/function/JsonPathMapCacheTest.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7384: Adding presto-pinot-driver module

2021-09-09 Thread GitBox
codecov-commenter edited a comment on pull request #7384: URL: https://github.com/apache/pinot/pull/7384#issuecomment-910162874 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T