richardstartin opened a new issue #7414:
URL: https://github.com/apache/pinot/issues/7414
There's code throughout the codebase which performs tracing of sensitive
operations, such as in `BaseOperator`:
```java
@Override
public final T nextBlock() {
if (Thread.interrupted()) {
throw new EarlyTerminationException();
}
if (TraceContext.traceEnabled()) {
long start = System.currentTimeMillis();
T nextBlock = getNextBlock();
long end = System.currentTimeMillis();
String operatorName = getOperatorName();
LOGGER.trace("Time spent in {}: {}", operatorName, (end - start));
TraceContext.logTime(operatorName, (end - start));
return nextBlock;
} else {
return getNextBlock();
}
}
```
Calls to `System.currentTimeMillis()` call in to the system clock, so are
subject to NTP/PTP adjustments, meaning that `(end - start)` can be negative or
misleadingly long. `System.nanoTime()` should be used instead, and converted to
milliseconds if so desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
