richardstartin commented on a change in pull request #7409: URL: https://github.com/apache/pinot/pull/7409#discussion_r705168129
########## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionConstants.java ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.function; + +public class FunctionConstants { + private FunctionConstants() { + } + + /** + * Maximum of json path cache size. + * the number of JSON paths is bounded by the size of the transformation config, + * add this threshold for protection from the extreme cases. + */ + public static final int MAX_JSON_PATH_CACHE_SIZE = 1024 * 16; Review comment: This class should be removed and the constant inlined into `JsonPathMapCache` where it is relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
