[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7070: Adding ability to check ingestion status for Offline Pinot table

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7070: URL: https://github.com/apache/incubator-pinot/pull/7070#issuecomment-862946427 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7070?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] xiangfu0 opened a new pull request #7132: Fixing init controller conf for StartControllerCommand

2021-07-06 Thread GitBox
xiangfu0 opened a new pull request #7132: URL: https://github.com/apache/incubator-pinot/pull/7132 ## Description Need to run getControllerConf method first to init the zkAddress and clusterName. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade or

[incubator-pinot] branch master updated: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file (#7131)

2021-07-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b99e804 Fixing Controller/Broker/Serv

[GitHub] [incubator-pinot] xiangfu0 merged pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
xiangfu0 merged pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#issuecomment-875186949 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7131?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#issuecomment-875186949 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7131?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#issuecomment-875186949 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7131?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
xiangfu0 commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664966005 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java ## @@ -141,6 +136,13 @@ public boolean exec

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #7072: Support database concept to create like dbname.tablename

2021-07-06 Thread GitBox
Jackie-Jiang commented on issue #7072: URL: https://github.com/apache/incubator-pinot/issues/7072#issuecomment-875186272 Pinot does not have the database concept, and requires all the table name to be unique. I believe the ask here is to allow `.` within the table name. Currently `_` is a

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
apucher commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664961613 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java ## @@ -141,6 +136,13 @@ public boolean execu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config

2021-07-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664959301 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java ## @@ -141,6 +136,13 @@ public boolean

[incubator-pinot] branch master updated (e656e16 -> 1956c07)

2021-07-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e656e16 Fix custom instance id for controller/broker/minion (#7127) add 1956c07 Add timestamp datatyp

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #7117: Add timestamp datatype support in JDBC

2021-07-06 Thread GitBox
Jackie-Jiang merged pull request #7117: URL: https://github.com/apache/incubator-pinot/pull/7117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
xiangfu0 commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664950044 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartControllerCommand.java ## @@ -161,6 +161,10 @@ public boolean

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
apucher commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664948949 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartControllerCommand.java ## @@ -161,6 +161,10 @@ public boolean e

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
apucher commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664948749 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartControllerCommand.java ## @@ -161,6 +161,10 @@ public boolean e

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
apucher commented on a change in pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664947764 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java ## @@ -141,6 +136,13 @@ public boolean execu

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] xiangfu0 opened a new pull request #7131: Fixing Controller/Broker/Server/Minion zk and cluster name configs in PinotServiceMananger when start using config file

2021-07-06 Thread GitBox
xiangfu0 opened a new pull request #7131: URL: https://github.com/apache/incubator-pinot/pull/7131 ## Description When starting Pinot using a config file, the _zkAddress and _clusterName are set as default values, which are `localhost:2181` and `PinotCluster`. This fix overri

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#discussion_r664935764 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionUtils.java ## @@ -180,6 +180,7 @@

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7070: Adding ability to check ingestion status for Offline Pinot table

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7070: URL: https://github.com/apache/incubator-pinot/pull/7070#issuecomment-862946427 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7070?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 commented on issue #7130: Add a partialResults flag in Response metadata

2021-07-06 Thread GitBox
yupeng9 commented on issue #7130: URL: https://github.com/apache/incubator-pinot/issues/7130#issuecomment-875138897 +1 It'll be also good to have a broker or table-level config that disallows partial results. It's common to see that users are okay with query failure (which they can

[incubator-pinot] branch master updated (0eb0f89 -> e656e16)

2021-07-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0eb0f89 Fix UpsertConfig JSON deserialization. (#7125) add e656e16 Fix custom instance id for control

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #7127: Fix custom instance id for controller/broker/minion

2021-07-06 Thread GitBox
Jackie-Jiang merged pull request #7127: URL: https://github.com/apache/incubator-pinot/pull/7127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-pinot] xiangfu0 commented on issue #7130: Add a partialResults flag in Response metadata

2021-07-06 Thread GitBox
xiangfu0 commented on issue #7130: URL: https://github.com/apache/incubator-pinot/issues/7130#issuecomment-875129813 cc: @yupeng9 @mcvsubbu @mayankshriv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] xiangfu0 edited a comment on issue #7130: Add a partialResults flag in Response metadata

2021-07-06 Thread GitBox
xiangfu0 edited a comment on issue #7130: URL: https://github.com/apache/incubator-pinot/issues/7130#issuecomment-875129813 cc: @yupeng9 @mcvsubbu @mayankshriv @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-pinot] xiangfu0 opened a new issue #7130: Add a partialResults flag in Response metadata

2021-07-06 Thread GitBox
xiangfu0 opened a new issue #7130: URL: https://github.com/apache/incubator-pinot/issues/7130 It would be good to let the broker add a partial result flag, case I can think when this flag is set to true: 1. Any exceptions during segment processing or timeout 2. Routing table doesn't c

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #7070: Adding ability to check ingestion status for Offline Pinot table

2021-07-06 Thread GitBox
icefury71 commented on a change in pull request #7070: URL: https://github.com/apache/incubator-pinot/pull/7070#discussion_r664900565 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java ## @@ -346,6 +346

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7127: Fix custom instance id for controller/broker/minion

2021-07-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #7127: URL: https://github.com/apache/incubator-pinot/pull/7127#discussion_r664829376 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java ## @@ -19,17 +19,17 @@ package org.apache.pinot.

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7126: Wire TaskMetricsEmitter to controller starter

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7126: URL: https://github.com/apache/incubator-pinot/pull/7126#issuecomment-873655373 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7126?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7126: Wire TaskMetricsEmitter to controller starter

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7126: URL: https://github.com/apache/incubator-pinot/pull/7126#issuecomment-873655373 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7126?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] kkrugler commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
kkrugler commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874989183 How about being able to define things via: ``` json "filePathPattern":".+/(.+)/.+\\.parquet", "segmentName":"${tableName}_${filePathPattern:\\1}.parquet"

[incubator-pinot] branch master updated (3c033a6 -> 0eb0f89)

2021-07-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3c033a6 Cleanup PinotHelixResourceManager and move the default tag handling to the starter (#7123) add

[GitHub] [incubator-pinot] jackjlli merged pull request #7125: Fix UpsertConfig JSON deserialization.

2021-07-06 Thread GitBox
jackjlli merged pull request #7125: URL: https://github.com/apache/incubator-pinot/pull/7125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7127: Fix custom instance id for controller/broker/minion

2021-07-06 Thread GitBox
jackjlli commented on a change in pull request #7127: URL: https://github.com/apache/incubator-pinot/pull/7127#discussion_r664775710 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java ## @@ -161,10 +162,18 @@ public void init(Pi

[GitHub] [incubator-pinot] kkrugler commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
kkrugler commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874983795 And pluggable name generators would make it harder to provide a hosted solution :) But without that, I'd need to also add support to format the input dates to be `-MM`.

[GitHub] [incubator-pinot] mayankshriv commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
mayankshriv commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874981243 > Also currently is it possible to implement a custom name generator, via java classes in some plugin dir? I guess we could support patterns to be able to define the res

[GitHub] [incubator-pinot] mayankshriv commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
mayankshriv commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874979849 > Java 8 is the minimum version, right? So we could extend the `SegmentNameGenerator` interface with a default method that takes the input file path, and just calls the

[GitHub] [incubator-pinot] kkrugler commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
kkrugler commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874977841 Also currently is it possible to implement a custom name generator, via java classes in some plugin dir? I guess we could support patterns to be able to define the resultin

[GitHub] [incubator-pinot] kkrugler edited a comment on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
kkrugler edited a comment on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874975957 Java 8 is the minimum version, right? So we could extend the `SegmentNameGenerator` interface with a default method that takes the input file path, and just calls th

[GitHub] [incubator-pinot] kkrugler commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-06 Thread GitBox
kkrugler commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-874975957 Java 8 is the minimum version, right? So we could extend the `SegmentNameGenerator` interface with a default method that takes the input filename, and just calls the old ve

[incubator-pinot] branch wire-TaskMetricsEmitter updated (7c4f2ee -> ad0d11b)

2021-07-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch wire-TaskMetricsEmitter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7c4f2ee Wire TaskMetricsEmitter to controller starter add ad0d11b Wire TaskMetricsEmit

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
mayankshriv commented on a change in pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#discussion_r664755284 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -158,7 +170,8 @@ public PlanNode m

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7126: Wire TaskMetricsEmitter to controller starter

2021-07-06 Thread GitBox
jackjlli commented on a change in pull request #7126: URL: https://github.com/apache/incubator-pinot/pull/7126#discussion_r664751738 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/TaskMetricsEmitter.java ## @@ -86,5 +96,15 @@ protect

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
mayankshriv commented on a change in pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#discussion_r664751213 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -182,6 +195,11 @@ public PlanNode

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
mayankshriv commented on a change in pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#discussion_r664737964 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -69,6 +69,10 @@ public static f

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#issuecomment-874566291 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#issuecomment-874566291 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] kriti-sc commented on pull request #7081: [#6823] Obfuscation of sensitive config

2021-07-06 Thread GitBox
kriti-sc commented on pull request #7081: URL: https://github.com/apache/incubator-pinot/pull/7081#issuecomment-874337369 @npawar @xiangfu0 Working on obfuscating credentials (aws access & secret key for kinesis; truststore passwords, etc for kafka) - https://github.com/kriti-sc/in

[GitHub] [incubator-pinot] kriti-sc edited a comment on pull request #7081: [#6823] Obfuscation of sensitive config

2021-07-06 Thread GitBox
kriti-sc edited a comment on pull request #7081: URL: https://github.com/apache/incubator-pinot/pull/7081#issuecomment-874337369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-pinot] kriti-sc commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-07-06 Thread GitBox
kriti-sc commented on issue #6679: URL: https://github.com/apache/incubator-pinot/issues/6679#issuecomment-874337800 Picking this up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-pinot] minwoo-jung edited a comment on issue #7100: [question] Even if I recreate the kafka topic or modify the topic properties, I wonder how consuming can continue to do it.

2021-07-06 Thread GitBox
minwoo-jung edited a comment on issue #7100: URL: https://github.com/apache/incubator-pinot/issues/7100#issuecomment-873941627 Hi @@mcvsubbu I am writing to get answers to the above questions. You're so busy, but can you answer me when you have time? I am a developer develo

[GitHub] [incubator-pinot] syed72 commented on issue #7072: Support database concept to create like dbname.tablename

2021-07-06 Thread GitBox
syed72 commented on issue #7072: URL: https://github.com/apache/incubator-pinot/issues/7072#issuecomment-874124007 Can someone acknowledge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7127: Fix custom instance id for controller/broker/minion

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #7127: URL: https://github.com/apache/incubator-pinot/pull/7127#issuecomment-873976834 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7127?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] minwoo-jung commented on issue #7100: [question] Even if I recreate the kafka topic or modify the topic properties, I wonder how consuming can continue to do it.

2021-07-06 Thread GitBox
minwoo-jung commented on issue #7100: URL: https://github.com/apache/incubator-pinot/issues/7100#issuecomment-873941627 Hi @@mcvsubbu I am writing to get answers to the above questions. You're so busy, but can you answer me when you have time? I am a developer developing an

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#issuecomment-874566291 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7129: Support Dictionary Based Plan for DISTINCT Aggregates

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #7129: URL: https://github.com/apache/incubator-pinot/pull/7129#issuecomment-874566291 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] kriti-sc edited a comment on pull request #7081: [#6823] Obfuscation of sensitive config

2021-07-06 Thread GitBox
kriti-sc edited a comment on pull request #7081: URL: https://github.com/apache/incubator-pinot/pull/7081#issuecomment-874337369 @npawar @xiangfu0 Working on obfuscating credentials (aws access & secret key for kinesis; truststore passwords, etc for kafka) - https://github.com/krit