apucher commented on a change in pull request #7131:
URL: https://github.com/apache/incubator-pinot/pull/7131#discussion_r664948749
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartControllerCommand.java
##########
@@ -161,6 +161,10 @@ public boolean execute()
Map<String, Object> properties = new HashMap<>();
if (_configFileName != null) {
properties.putAll(PinotConfigUtils.generateControllerConf(_configFileName));
+ // Override the zkAddress and clusterName to ensure ServiceManager is
connecting to the right Zookeeper and Cluster.
+ // Configs existence is already verified.
+ _zkAddress = properties.get(ControllerConf.ZK_STR).toString();
+ _clusterName =
properties.get(ControllerConf.HELIX_CLUSTER_NAME).toString();
Review comment:
couldn't you simply remove the `setZkAddress()` etc calls above, since
the properties get built here either way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
