icefury71 commented on a change in pull request #7070:
URL: https://github.com/apache/incubator-pinot/pull/7070#discussion_r664900565
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
##########
@@ -346,6 +346,39 @@ public synchronized TaskState getTaskState(String
taskName) {
return taskConfigs;
}
+ /**
+ * Helper method to return a map of task names to corresponding task state
+ * where the task corresponds to the given Pinot table name. This is used to
+ * check status of all tasks for a given table.
+ * @param taskType Task Name
+ * @param tableNameWithType table name with type to filter on
+ * @return Map of filtered task name to corresponding state
+ */
+ public synchronized Map<String, TaskState> getTaskStatesByTable(String
taskType, String tableNameWithType) {
+ Map<String, TaskState> filteredTaskStateMap = new HashMap<>();
+ Map<String, TaskState> taskStateMap = getTaskStates(taskType);
+
+ for (Map.Entry<String, TaskState> taskState : taskStateMap.entrySet()) {
+ String taskName = taskState.getKey();
+
+ // Iterate through all task configs associated with this task name
+ for (PinotTaskConfig taskConfig: getTaskConfigs(taskName)) {
+ Map<String, String> pinotConfigs = taskConfig.getConfigs();
+
+ // Filter task configs that matches this table name
+ if (pinotConfigs != null) {
+ String tableNameConfig = pinotConfigs.get("tableName");
Review comment:
@mcvsubbu there is a small issue. Looks like there's already a constant
named 'TABLE_NAME' in CommonConstants:
```
@Deprecated
public static final String TABLE_NAME = "segment.table.name";
```
It'll be confusing if I add another of this. I think we should wait for this
to be removed before adding the TABLE_NAME constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
