codecov-commenter edited a comment on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-828596486
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-828596486
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
amrishlal commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857416829
> we can remove the null check for the returned reference of getTags, while
a null check is needed for instanceConfig. Please include that into this PR.
Fixed.
codecov-commenter edited a comment on pull request #6991:
URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6991:
URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
yupeng9 opened a new issue #7036:
URL: https://github.com/apache/incubator-pinot/issues/7036
There are senairos that users need to run complex adhoc queries (e.g.
multi-way join with other datasets) or ETL jobs that scan all Pinot segments.
Pinot servers are not designed this pattern of wo
chenboat commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857320273
We can contribute the fix. In a high level, we find today's default
implementation before `doMove()` has a lot of assumptions on src and dest
directory structures. It
codecov-commenter edited a comment on pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#issuecomment-853568285
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#issuecomment-853568285
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
chenboat edited a comment on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857288816
> `move()` is intentional made `final` to force the behavior. To optimize
the file move, you can override `doMove()`
What is the intention behind add `fina
Jackie-Jiang commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857295337
@chenboat If you find bug in the `move()`, then feel free to fix it.
Basically we want to keep the override logic within the `doMove()`, the use
`move()` to unify t
chenboat edited a comment on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857288816
> `move()` is intentional made `final` to force the behavior. To optimize
the file move, you can override `doMove()`
What the intention behind add `final`
chenboat commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857288816
> `move()` is intentional made `final` to force the behavior. To optimize
the file move, you can override `doMove()`
What the intention behind add `final` to `mov
codecov-commenter edited a comment on pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#issuecomment-853568285
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from d2bfde5 Fixing HadoopPinotFS listFiles method to always contain
scheme (#7027)
add 6aac7dd fixing p
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 5237e67 Block filter clause not supported during query parsing (#7023)
add d2bfde5 Fixing HadoopPino
xiangfu0 merged pull request #7030:
URL: https://github.com/apache/incubator-pinot/pull/7030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
xiangfu0 merged pull request #7027:
URL: https://github.com/apache/incubator-pinot/pull/7027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jackjlli commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857268994
> `InstanceConfig.getTags()` should never return `null`. Are you using a
different Helix version?
> Here's the Helix code:
>
> ```
> public List getTags()
jackjlli commented on a change in pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#discussion_r647868700
##
File path: pinot-minion/src/main/java/org/apache/pinot/minion/MinionStarter.java
##
@@ -284,7 +284,8 @@ private void addInstanceTagIfNeeded()
Jackie-Jiang commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857255635
`InstanceConfig.getTags()` should never return `null`. Are you using a
different Helix version?
Here's the Helix code:
```
public List getTags() {
Jackie-Jiang closed pull request #6874:
URL: https://github.com/apache/incubator-pinot/pull/6874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
codecov-commenter edited a comment on pull request #7035:
URL: https://github.com/apache/incubator-pinot/pull/7035#issuecomment-857236216
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7035?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #7030:
URL: https://github.com/apache/incubator-pinot/pull/7030#issuecomment-857235402
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7030?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter commented on pull request #7035:
URL: https://github.com/apache/incubator-pinot/pull/7035#issuecomment-857236216
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7035?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
codecov-commenter commented on pull request #7030:
URL: https://github.com/apache/incubator-pinot/pull/7030#issuecomment-857235402
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7030?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 88843ee Fix bug in fetching subset of tier config props (#7025)
add 5237e67 Block filter clause not s
Jackie-Jiang merged pull request #7023:
URL: https://github.com/apache/incubator-pinot/pull/7023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
GSharayu opened a new pull request #7035:
URL: https://github.com/apache/incubator-pinot/pull/7035
This ticket is extension of adding new compression codec LZ4 after
ZSTD(#6876) for Issue (#6804).
When the forward index is not dictionary encoded, we have 2 choices:
store the data
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e91f426 Improvements in compat-tester (#7024)
add 88843ee Fix bug in fetching subset of tier config p
Jackie-Jiang merged pull request #7025:
URL: https://github.com/apache/incubator-pinot/pull/7025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
snleee commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647769770
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java
##
@@ -0,0 +
xiangfu0 commented on pull request #7030:
URL: https://github.com/apache/incubator-pinot/pull/7030#issuecomment-857139059
> I noticed the same thing happening to the pinot-spark module. We need to
do the same thing there.
done
--
This is an automated message from the Apache Git Se
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_pinot-hadoop-test
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 0b87114 fixing pinot-hadoop test
add 00dcf0c fixing pinot-hadoop and pinot-spark t
codecov-commenter commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857129444
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
GSharayu opened a new issue #7034:
URL: https://github.com/apache/incubator-pinot/issues/7034
Currently,
As part of pinot automated onboarding, we support automated inverted index
and sorted index recommendations.
Wiki Doc:
https://cwiki.apache.org/confluence/display/PINOT/Autom
Jackie-Jiang commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857072025
`move()` is intentional made `final` to force the behavior. To optimize the
file move, you can override `doMove()`
--
This is an automated message from the Apache
amrishlal commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857068913
@jackjlli Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
amrishlal opened a new pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033
## Description
Null check to ensure that a default tag will be added for Pinot Minion
instance even when `instanceTags` are null. Broker and Server already carry out
similar null check.
codecov-commenter commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857065048
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7032?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
chenboat commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857001559
lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
chenboat closed pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
codecov-commenter commented on pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#issuecomment-856998244
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7031?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
codecov-commenter edited a comment on pull request #6991:
URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
yupeng9 commented on pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-856975758
@elonazoulay fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Jackie-Jiang commented on a change in pull request #7023:
URL: https://github.com/apache/incubator-pinot/pull/7023#discussion_r647670938
##
File path:
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
##
@@ -179,11 +179,6 @@ public void testFi
yupeng9 opened a new pull request #7032:
URL: https://github.com/apache/incubator-pinot/pull/7032
Recently `PinotFS.move` was marked as final in this
[PR](https://github.com/apache/incubator-pinot/pull/6841). However, it's
possible for the subclass to have different implementations for oth
GSharayu opened a new pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031
Typically the dimension columns are used in filter and group by. However,
technically nothing prevents user from doing a filter on a non-dimension
column. So, we need to update the query inve
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856919437
> OK. I understand this now. The problem is that I did an incompetent job of
breaking t-digest into multiple modules. This meant that I needed to publish
the parent
codecov-commenter edited a comment on pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#issuecomment-855347878
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
KKcorps commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647547669
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java
###
npawar commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647530043
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerFactory.java
##
KKcorps commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647520268
##
File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml
##
@@ -0,0 +1,31 @@
+
+http://maven.apache.org/POM/4.0.0";
Review comment
KKcorps commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647312517
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarStandaloneCluster.java
KKcorps commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647311963
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerFactory.java
##
KKcorps commented on a change in pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r647310962
##
File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml
##
@@ -0,0 +1,31 @@
+
+http://maven.apache.org/POM/4.0.0";
Review comment
56 matches
Mail list logo
