chenboat commented on pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857320273
We can contribute the fix. In a high level, we find today's default implementation before `doMove()` has a lot of assumptions on src and dest directory structures. It is much better to leave this overridable by different PinotFS implementations. > @chenboat If you find bug in the `move()`, then feel free to fix it. Basically we want to keep the override logic within the `doMove()`, the use `move()` to unify the following behaviors: > > 1. Source not exist > 2. Destination exist (delete on overwrite) > 3. Destination parent not exist > > I'm okay making it not `final`, but if you want to override it due to some bug/limitation, we should try to fix `move()` instead of overriding it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
