chenboat edited a comment on pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857288816
> `move()` is intentional made `final` to force the behavior. To optimize the file move, you can override `doMove()` What the intention behind add `final` to `move`? Today's default `move()` implementation has a lot of customized logic before the `doMove()` and some bug/limitation. E.g., we found that it can not work with base URLs with both hostname and port (e.g., “hdfs://localhost:58059”) because the code only consider hostname. That is why we think making it non-final. It is also consistent with other api in the same class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
