[incubator-pinot] branch master updated: Fix the race condition in realtime text index refresh thread (#6858) (#6990)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 211cf8a Fix the race condition in

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6990: Fix the race condition in realtime text index refresh thread (#6858)

siddharthteotia merged pull request #6990: URL: https://github.com/apache/incubator-pinot/pull/6990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6975: Merge rollup executor enhancement

snleee commented on a change in pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975#discussion_r641299163 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java ## @@ -172,7 +185,7 @@ public static URI getD

[GitHub] [incubator-pinot] oker1 commented on a change in pull request #6994: Realtime to offline space saving

oker1 commented on a change in pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#discussion_r641299148 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtime_to_offline_segments/R

[GitHub] [incubator-pinot] oker1 commented on a change in pull request #6994: Realtime to offline space saving

oker1 commented on a change in pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#discussion_r641299148 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtime_to_offline_segments/R

[incubator-pinot] branch master updated: Add constants and metadata properties for MergeRollupTask: (#6932)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4fb234a Add constants and metadata prop

[GitHub] [incubator-pinot] snleee merged pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee merged pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6997: Add genericRow file reader and writer

Jackie-Jiang merged pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[incubator-pinot] branch master updated: Add genericRow file reader and writer (#6997)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6fcccfc Add genericRow file reader and

[incubator-pinot] branch master updated: Normalize LHS and RHS numerical types for >, >=, <, and <= operators. (#6927)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e0b2be8 Normalize LHS and RHS nume

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia merged pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

codecov-commenter edited a comment on pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#issuecomment-847666543 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

codecov-commenter edited a comment on pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#issuecomment-847666543 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6932: Add constants and metadata properties for MergeRollupTask:

codecov-commenter edited a comment on pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#issuecomment-842768635 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

mqliang commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r641260050 ## File path: compatibility-verifier/compCheck.sh ## @@ -41,20 +41,54 @@ RM="/bin/rm" logCount=1 +#Declare the number of mandatory args +margs

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

mqliang commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r641259035 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/SqlResultComparator.java ## @@ -113,9 +126,147 @@ public static

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6997: Add genericRow file reader and writer

codecov-commenter edited a comment on pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997#issuecomment-850086076 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6997: Add genericRow file reader and writer

codecov-commenter commented on pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997#issuecomment-850086076 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641206504 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641193715 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -85,7 +86,7 @@ im

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641189609 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java ## @@ -59,7 +59,7 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641185385 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentErrorInfo.java ## @@ -0,0 +1,94 @@ +/** + * License

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641184869 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentErrorInfo.java ## @@ -0,0 +1,94 @@ +/** + * License

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641183429 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentErrorInfo.java ## @@ -0,0 +1,94 @@ +/** + * License

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r641182090 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -61,7 +61,11 @@ public static final

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r641181681 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java ## @@ -357,4 +372,88 @@ public Comparable extract(Record

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r641181215 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java ## @@ -117,6 +119,19 @@ public Intermed

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641176094 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6997: Add genericRow file reader and writer

Jackie-Jiang commented on a change in pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997#discussion_r641166681 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileReader.java ## @@ -0,0 +1,85 @@ +/*

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r641166342 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java ## @@ -144,4 +147,22 @@ protect

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

Jackie-Jiang commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641140241 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentErrorInfo.java ## @@ -0,0 +1,94 @@ +/** + * Licens

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6975: Merge rollup executor enhancement

codecov-commenter edited a comment on pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975#issuecomment-848278058 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6997: Add genericRow file reader and writer

npawar commented on a change in pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997#discussion_r641140486 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileReader.java ## @@ -0,0 +1,85 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6997: Add genericRow file reader and writer

Jackie-Jiang opened a new pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997 ## Description Add file reader and writer for genericRow leveraging the ser/de classes Replace the usage of ser/de to the file reader/writer -- This is an automated message from th

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641084466 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeProperties.

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641082054 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641081625 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[incubator-pinot] branch master updated (856fe09 -> d615418)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 856fe09 Add annotation for deprecated fields segmentPushType and segmentPushFrequency in TableConfigBui

[GitHub] [incubator-pinot] npawar merged pull request #6661: Add Kinesis Stream Ingestion Plugin

npawar merged pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6661: Add Kinesis Stream Ingestion Plugin

codecov-commenter edited a comment on pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661#issuecomment-849265905 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6994: Realtime to offline space saving

codecov-commenter commented on pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#issuecomment-850013482 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6994?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] harishks commented on issue #6487: Adding numStartreeUsed in query stats

harishks commented on issue #6487: URL: https://github.com/apache/incubator-pinot/issues/6487#issuecomment-850006774 Will be happy to pick this one up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6996: Remove constructor from base class ColumnIndexDirectory

codecov-commenter edited a comment on pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996#issuecomment-84702 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6996?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6996: Remove constructor from base class ColumnIndexDirectory

codecov-commenter commented on pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996#issuecomment-84702 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6996?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641022730 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6994: Realtime to offline space saving

Jackie-Jiang commented on a change in pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#discussion_r641020167 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtime_to_offline_seg

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6932: Add constants and metadata properties for MergeRollupTask:

codecov-commenter edited a comment on pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#issuecomment-842768635 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641017470 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] npawar opened a new pull request #6996: Remove constructor from base class ColumnIndexDirectory

npawar opened a new pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996 The parameters of the constructor in the base class will not make sense for an implementation which doesn't have segmentDirectory on the local disk -- This is an automated message from the Ap

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640998631 ## File path: pinot-common/src/main/java/org/apache/pinot/common/minion/MergeRollupTaskMetadata.java ## @@ -0,0 +1,95 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640998080 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640997717 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988649 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -59,9 +65,14 @@ protected HelixMana

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988017 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java ## @@ -103,7 +103,11 @@ //

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640983000 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int getNu

[GitHub] [incubator-pinot] yupeng9 closed issue #6904: Complex type handling

yupeng9 closed issue #6904: URL: https://github.com/apache/incubator-pinot/issues/6904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [incubator-pinot] yupeng9 commented on issue #6904: Complex type handling

yupeng9 commented on issue #6904: URL: https://github.com/apache/incubator-pinot/issues/6904#issuecomment-849938401 User docs is at https://docs.pinot.apache.org/basics/data-import/complex-type This will be released as part of 0.8 -- This is an automated message from the Apache Git Se

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640928843 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priva

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6977: Enhance debug endpoint for table debugging.

codecov-commenter edited a comment on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] jtao15 edited a comment on issue #6979: SegmentProcessorFramework improvements for merge/rollup

jtao15 edited a comment on issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979#issuecomment-849869980 Besides the time partition, it's good to make the resulted segment name configurable also. Listing down the requirements of the improvements: 1. Time partition -

[GitHub] [incubator-pinot] jtao15 commented on issue #6979: SegmentProcessorFramework improvements for merge/rollup

jtao15 commented on issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979#issuecomment-849869980 Besides the time partition, it's good to make the resulted segment name configurable also. Listing down the requirements of the improvements: 1. Time partition - Partiti

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

codecov-commenter edited a comment on pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#issuecomment-841713694 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640883715 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -253,4 +330,46 @@ privat

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640881513 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java ## @@ -103,7 +103,11 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640880513 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -59,9 +65,14 @@ protected HelixM

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640879901 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

codecov-commenter edited a comment on pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640874473 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -63,6 +79,8 @@ @Api(tag

[incubator-pinot] branch master updated (0b5dcb7 -> 856fe09)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0b5dcb7 Unify the minion plug-in package regex path (#6980) add 856fe09 Add annotation for deprecated f

[GitHub] [incubator-pinot] jackjlli merged pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

jackjlli merged pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640870146 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

codecov-commenter edited a comment on pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993#issuecomment-849367065 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6993?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

codecov-commenter commented on pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640870146 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869998 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * Lice

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869225 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869225 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640807315 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int getNu

[GitHub] [incubator-pinot] oker1 opened a new issue #6995: RealtimeToOfflineSegmentsTask uses too much disk space relative to segments size

oker1 opened a new issue #6995: URL: https://github.com/apache/incubator-pinot/issues/6995 Proposed change: https://github.com/apache/incubator-pinot/pull/6994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-pinot] oker1 opened a new pull request #6994: Realtime to offline save space

oker1 opened a new pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994 ## Description We saw high disk usage when using RealtimeToOfflineSegmentsTask, and as I looked into the code I've found that it keeps lots of temporary files around until the whole task

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

Jackie-Jiang commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640859147 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640852691 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640850582 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640840142 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640840045 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -80,22 +83,29 @@ public

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640801157 ## File path: pinot-core/src/main/java/org/apache/pinot/core/minion/rollup/MergeRollupSegmentConverter.java ## @@ -45,16 +49,16 @@ private Tabl

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640796662 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/ServerResourceUtils.java ## @@ -0,0 +1,58 @@ +/** + * Licensed

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640791864 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -228,4 +240,20 @@ public String get

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640791087 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priva

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640790441 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640789829 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640777126 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640771794 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640770793 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -80,22 +83,29 @@