[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6641: Adding a check for multi-value column in star tree indexing config

codecov-io edited a comment on pull request #6641: URL: https://github.com/apache/incubator-pinot/pull/6641#issuecomment-790321054 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6641?src=pr&el=h1) Report > Merging [#6641](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6611: SegmentWriter interface

yupeng9 commented on a change in pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r592094402 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/writer/SegmentWriter.java ## @@ -0,0 +1,59 @@ +/** + * Licensed to t

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6668: SumPrecision: support all data types and star-tree

icefury71 commented on a change in pull request #6668: URL: https://github.com/apache/incubator-pinot/pull/6668#discussion_r592071217 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/aggregator/SumPrecisionValueAggregator.java ## @@ -0,0 +1,93 @@ +/** + * Lice

[GitHub] [incubator-pinot] fx19880617 removed a comment on pull request #6611: SegmentWriter interface

fx19880617 removed a comment on pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#issuecomment-785567745 @yupeng9 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-pinot] npawar commented on pull request #6611: SegmentWriter interface

npawar commented on pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#issuecomment-796398254 @mcvsubbu would you please review again and unblock from merging? This is an automated message from the A

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6611: SegmentWriter interface

npawar commented on a change in pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r592031623 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/uploader/SegmentUploader.java ## @@ -0,0 +1,38 @@ +/** + * Licensed t

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6611: SegmentWriter interface

npawar commented on a change in pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r592031060 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/writer/SegmentWriter.java ## @@ -0,0 +1,59 @@ +/** + * Licensed to th

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6611: SegmentWriter interface

npawar commented on a change in pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r592030849 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/writer/SegmentWriter.java ## @@ -0,0 +1,59 @@ +/** + * Licensed to th

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6628: [Enhancement Feature Request] Star Tree support for sumprecesion

Jackie-Jiang commented on issue #6628: URL: https://github.com/apache/incubator-pinot/issues/6628#issuecomment-796394907 #6668 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6668: SumPrecision: support all data types and star-tree

Jackie-Jiang opened a new pull request #6668: URL: https://github.com/apache/incubator-pinot/pull/6668 ## Description Currently `SumPrecision` aggregation function only supports summing up the serialized BigDecimal bytes. This PR enhances the `SumPrecision` with: - All data type su

svn commit: r46576 - /dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/

Author: yupeng Date: Thu Mar 11 01:25:26 2021 New Revision: 46576 Log: Update apache-pinot-incubating-0.7.0-rc1 Added: dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/ dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/apache-pinot-incubating-0.7.0-bin.tar.gz (with props)

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6611: SegmentWriter interface

yupeng9 commented on a change in pull request #6611: URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r591961768 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/uploader/SegmentUploader.java ## @@ -0,0 +1,38 @@ +/** + * Licensed

svn commit: r46570 - /dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/

Author: yupeng Date: Thu Mar 11 00:10:03 2021 New Revision: 46570 Log: Deleted old 0.7.0-rc1 Removed: dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6664: Add an option to fail segment creation job when getting empty files

jackjlli commented on a change in pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#discussion_r591963664 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java ## @@ -76,6 +76,9 @@ @Option(name = "-

[incubator-pinot] branch add-option-to-fail-offline-job-on-empty-record updated (b7774ed -> 1ecd548)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-option-to-fail-offline-job-on-empty-record in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b7774ed Add check in handlePostCreation method; add option in Create

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

sajjad-moradi commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591942928 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -331,23 +340,43 @@ void te

[GitHub] [incubator-pinot] codecov-io commented on pull request #6667: Interface changes for Kinesis connector

codecov-io commented on pull request #6667: URL: https://github.com/apache/incubator-pinot/pull/6667#issuecomment-796275454 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6667?src=pr&el=h1) Report > Merging [#6667](https://codecov.io/gh/apache/incubator-pinot/pull/6667?s

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

sajjad-moradi commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591942310 ## File path: pinot-controller/src/test/resources/memory_estimation/schema-with-metadata__dateTimeFieldSpec.json ## @@ -5,34 +5,34 @@

svn commit: r46569 - in /dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1: ./ apache-pinot-incubating-0.7.0-src.tar.gz apache-pinot-incubating-0.7.0-src.tar.gz.asc apache-pinot-incubating-0.7.0-s

Author: yupeng Date: Wed Mar 10 22:50:17 2021 New Revision: 46569 Log: Update apache-pinot-incubating-0.7.0-rc1 Added: dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/ dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/apache-pinot-incubating-0.7.0-src.tar.gz (with props)

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6650: complete compatibility regression testing

mcvsubbu merged pull request #6650: URL: https://github.com/apache/incubator-pinot/pull/6650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: complete compatibility regression testing (#6650)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 59d02c6 complete compatibility regre

[GitHub] [incubator-pinot] npawar opened a new pull request #6667: Interface changes for Kinesis connector

npawar opened a new pull request #6667: URL: https://github.com/apache/incubator-pinot/pull/6667 ## Description #5648 Part 2 of Kinesis implementation changes. This #6518 is the main PR, which is being split up into 3 parts in order to reduce the scope of review. In this PR, A

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591867775 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/RealtimeProvisioningRule.java ## @@ -0,0

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6650: complete compatibility regression testing

codecov-io edited a comment on pull request #6650: URL: https://github.com/apache/incubator-pinot/pull/6650#issuecomment-791657823 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6650?src=pr&el=h1) Report > Merging [#6650](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591875207 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -331,23 +340,43 @@ void

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591871232 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/RealtimeProvisioningRule.java ## @@ -0,0

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591867775 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/RealtimeProvisioningRule.java ## @@ -0,0

[GitHub] [incubator-pinot] codecov-io commented on pull request #6666: Remove unused shaded jars

codecov-io commented on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-796023553 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr&el=h1) Report > Merging [#](https://codecov.io/gh/apache/incubator-pinot/pull/?s

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591834579 ## File path: pinot-controller/src/test/resources/memory_estimation/schema-with-metadata__dateTimeFieldSpec.json ## @@ -5,34 +5,34 @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591833080 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java ## @@ -14

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591832009 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/RealtimeProvisioningRule.java ## @@ -0,0

[GitHub] [incubator-pinot] codecov-io commented on pull request #6664: Add an option to fail segment creation job when getting empty files

codecov-io commented on pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#issuecomment-795925891 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6664?src=pr&el=h1) Report > Merging [#6664](https://codecov.io/gh/apache/incubator-pinot/pull/6664?s

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6625: Add realtime provisioning rule to recommendation engine

siddharthteotia commented on a change in pull request #6625: URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591786053 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimatorTest.java ## @@

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6664: Add an option to fail segment creation job when getting empty files

npawar commented on a change in pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#discussion_r591785586 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java ## @@ -76,6 +76,9 @@ @Option(name = "-re

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6666: Remove unused shaded jars

jackjlli opened a new pull request #: URL: https://github.com/apache/incubator-pinot/pull/ ## Description This PR removes unused shaded jars, i.e. pinot-controller, pinot-broker, pinot-server, pinot-minion. The shaded jars of these modules are added several years ago. As d

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6650: complete compatibility regression testing

mqliang commented on a change in pull request #6650: URL: https://github.com/apache/incubator-pinot/pull/6650#discussion_r591767270 ## File path: compatibility-verifier/compCheck.sh ## @@ -105,13 +102,18 @@ function stopService() { else echo "Pid file ${dirName}/${servi

[incubator-pinot] branch remove-unused-shaded-jars created (now b0c1fa6)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch remove-unused-shaded-jars in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b0c1fa6 Remove unused shaded jars This branch includes the following new commits: n

[incubator-pinot] 01/01: Remove unused shaded jars

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch remove-unused-shaded-jars in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b0c1fa661ce7693100d664e4e0d564e40caf371d Author: Jack Li(Analytics Engineering) AuthorDate: We

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #6665: Query console only view for Cluster Manager

shahsank3t opened a new pull request #6665: URL: https://github.com/apache/incubator-pinot/pull/6665 ## Description This PR is for https://github.com/apache/incubator-pinot/issues/6619 Added a configuration file: `pinot-controller/src/main/resources/app/config.json` which will sto

[incubator-pinot] branch master updated (3b70930 -> 31bdc2b)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3b70930 Kinesis implementation Part 1: Rename partitionId to partitionGroupId (#6655) add 31bdc2b

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6651: Don't throw exception in json_extract_scalar when default value is available.

siddharthteotia merged pull request #6651: URL: https://github.com/apache/incubator-pinot/pull/6651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch add-option-to-fail-offline-job-on-empty-record updated (cd5d805 -> b7774ed)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-option-to-fail-offline-job-on-empty-record in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cd5d805 Address PR comment add b7774ed Add check in handlePostC

[GitHub] [incubator-pinot] jackjlli commented on pull request #6664: Add an option to fail segment creation job when getting empty files

jackjlli commented on pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#issuecomment-795846709 > I don't think this handling all the cases properly. This is just checking if recordreader.next is empty which is handling empty input file but it's not handling the c

[GitHub] [incubator-pinot] kishoreg commented on pull request #6664: Add an option to fail segment creation job when getting empty files

kishoreg commented on pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#issuecomment-795805303 I don't think this handling all the cases properly. This is just checking if recordreader.next is empty which is handling empty input file but it's not handling the cas

[incubator-pinot] branch add-option-to-fail-offline-job-on-empty-record updated (6b8e0a9 -> cd5d805)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-option-to-fail-offline-job-on-empty-record in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6b8e0a9 Add an option to fail segment creation job when getting empty

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6664: Add an option to fail segment creation job when getting empty files

mcvsubbu commented on a change in pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#discussion_r591711454 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java ## @@ -105,6 +105,7 @@ privat

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6650: complete compatibility regression testing

mcvsubbu commented on a change in pull request #6650: URL: https://github.com/apache/incubator-pinot/pull/6650#discussion_r591699572 ## File path: compatibility-verifier/compCheck.sh ## @@ -105,13 +102,18 @@ function stopService() { else echo "Pid file ${dirName}/${serv

[GitHub] [incubator-pinot] Eywek commented on issue #6302: [pinot]Support for pausing the realtime consumption without disabling the table.

Eywek commented on issue #6302: URL: https://github.com/apache/incubator-pinot/issues/6302#issuecomment-795729348 yep exactly This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6302: [pinot]Support for pausing the realtime consumption without disabling the table.

mcvsubbu commented on issue #6302: URL: https://github.com/apache/incubator-pinot/issues/6302#issuecomment-795726785 @Eywek this seems to be a one-time operation as you describe it? Am I right? Once the data is loaded into pinot, you intend to shut off consumption and just query the data

[GitHub] [incubator-pinot] Eywek commented on issue #6302: [pinot]Support for pausing the realtime consumption without disabling the table.

Eywek commented on issue #6302: URL: https://github.com/apache/incubator-pinot/issues/6302#issuecomment-795668118 > Question for the community: Are there others who need this feature? 👋  yes. We're planning to use Pinot to store some data from our users. We currently pull data from

[GitHub] [incubator-pinot] fx19880617 commented on issue #6660: Use Sum, Avg etc. Aggregate func to agg field which type was long will added .0 at end of metrics

fx19880617 commented on issue #6660: URL: https://github.com/apache/incubator-pinot/issues/6660#issuecomment-795146097 Another way is to have functions like `SumLong` to handle this case. This is an automated message from th