codecov-io commented on pull request #6376:
URL: https://github.com/apache/incubator-pinot/pull/6376#issuecomment-749394213
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6376?src=pr&el=h1)
Report
> Merging
[#6376](https://codecov.io/gh/apache/incubator-pinot/pull/6376?s
kishoreg opened a new pull request #6376:
URL: https://github.com/apache/incubator-pinot/pull/6376
## Description
Adding support for indexing (lat,lon) using Uber's H3 indexing.
```
select count(*) from starbucksStores where ST_DISTANCE(location_st_point ,
ST_POINT(-122, 3
kishoreg commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-749367187
> Why are we using the JVM system property based mechanism to set this as
opposed to using pinot.server.* configurations which is how we set the server
instance config?
kishoreg commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-749366869
> > Why are we using the JVM system property based mechanism to set this as
opposed to using pinot.server.* configurations which is how we set the server
instance confi
mcvsubbu commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-749325126
> Why are we using the JVM system property based mechanism to set this as
opposed to using pinot.server.* configurations which is how we set the server
instance config?
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b8bc74f compatibility test: create/d
mcvsubbu merged pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mcvsubbu commented on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-749324271
Thanks, @jtao15
This is an automated message from the Apache Git Service.
To respond to the message, p
codecov-io edited a comment on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-748383568
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6360?src=pr&el=h1)
Report
> Merging
[#6360](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-748383568
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6360?src=pr&el=h1)
Report
> Merging
[#6360](https://codecov.io/gh/apache/incubator-pinot/pull
siddharthteotia commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-749310890
Why are we using the JVM system property based mechanism to set this as
opposed to using pinot.server.* configurations which is how we set the server
instance co
mcvsubbu commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r547028950
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##
@@ -19,6 +19,17 @@
package org.apache.pinot.c
codecov-io edited a comment on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-748383568
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6360?src=pr&el=h1)
Report
> Merging
[#6360](https://codecov.io/gh/apache/incubator-pinot/pull
fx19880617 commented on issue #6349:
URL:
https://github.com/apache/incubator-pinot/issues/6349#issuecomment-749282776
1. For the ingestion job, it's by design to keep the segments in output
directory. The reason is that for URI and METADATA push job, the output dir is
treated at the sour
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 85cf696 Fixing the issue for realtime table creation with env
variables in stream configs (#6373)
npawar merged pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
codecov-io edited a comment on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-748383568
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6360?src=pr&el=h1)
Report
> Merging
[#6360](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
mcvsubbu commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r546999377
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##
@@ -92,4 +101,40 @@ boolean runOp() {
}
codecov-io edited a comment on pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#issuecomment-748383568
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6360?src=pr&el=h1)
Report
> Merging
[#6360](https://codecov.io/gh/apache/incubator-pinot/pull
npawar commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546990341
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/FileIngestionUtils.java
##
@@ -0,0 +1,186 @@
+/**
+ * Licensed to th
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
fx19880617 commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546328688
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/ControllerRequestURLBuilder.java
##
@@ -289,4 +292,18 @@ public
amarnathkarthik commented on issue #6349:
URL:
https://github.com/apache/incubator-pinot/issues/6349#issuecomment-749209495
Here is my analysis, Looked at `LaunchDataIngestionJobCommand.java` and it's
all job runner (Segment Generator and Push job). Did not see implementation to
clean up
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 85cf696 Fixing the issue for realtime
fx19880617 merged pull request #6373:
URL: https://github.com/apache/incubator-pinot/pull/6373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
cbalci commented on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-749187775
Thanks folks!
@Jackie-Jiang can you please merge the branch so I can move to the next step?
This i
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
npawar commented on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-749177669
> some thoughts re API design. I understand that this one is mainly for
testing purposes so it probably doesn't matter too much.
>
> If this is to ever become a pro
mcvsubbu commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r546908744
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##
@@ -92,4 +101,45 @@ boolean runOp() {
}
npawar commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546904614
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/FileIngestionHelper.java
##
@@ -0,0 +1,140 @@
+/**
+ * Licensed to t
npawar commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546903819
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotIngestionRestletResource.java
##
@@ -0,0 +1,145 @@
+/*
npawar commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546897922
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/FileIngestionHelper.java
##
@@ -0,0 +1,140 @@
+/**
+ * Licensed to t
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a commit to branch h3-index
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/h3-index by this push:
new bab10b9 Removing H3WITHIN UDF an
npawar commented on a change in pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#discussion_r546814422
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotIngestionRestletResource.java
##
@@ -0,0 +1,145 @@
+/*
codecov-io commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-748898114
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6375?src=pr&el=h1)
Report
> Merging
[#6375](https://codecov.io/gh/apache/incubator-pinot/pull/6375?s
samarth-gupta-traceable commented on issue #6374:
URL:
https://github.com/apache/incubator-pinot/issues/6374#issuecomment-748879492
created PR" https://github.com/apache/incubator-pinot/pull/6375
This is an automated message
samarth-gupta-traceable opened a new pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375
## Description
Fix for https://github.com/apache/incubator-pinot/issues/6374
## Upgrade Notes
Does this PR otherwise need attention when creating release notes? Thin
codecov-io edited a comment on pull request #6373:
URL: https://github.com/apache/incubator-pinot/pull/6373#issuecomment-748763075
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6373?src=pr&el=h1)
Report
> Merging
[#6373](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch
fixing_table_config_with_env_var_during_table_creation
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 6db99dd Fixing the issue for realtime table creation with
codecov-io edited a comment on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-705891235
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6120?src=pr&el=h1)
Report
> Merging
[#6120](https://codecov.io/gh/apache/incubator-pinot/pull
44 matches
Mail list logo
