mcvsubbu commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r546908744
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##########
@@ -92,4 +101,45 @@ boolean runOp() {
}
return true;
}
+
+ private boolean createSchema() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private boolean createTable() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private boolean deleteTable() {
+ try {
+ ControllerTest.sendDeleteRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forTableDelete(getTableNameFromTableConfigFile()));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private String getTableNameFromTableConfigFile() throws IOException {
Review comment:
Use `JsonUtils.fileToObject()` method. Already there.
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatTestConstants.java
##########
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.compat.tests;
+
+public class CompatTestConstants {
Review comment:
We are already in compat.tests package, so let us not call it
CompatTestConstants
For now, call it `ClusterDescriptor` we will evolve it as we add more
operators. My thought is that eventually we will get these from env variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
