mcvsubbu commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r546999377
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##########
@@ -92,4 +101,40 @@ boolean runOp() {
}
return true;
}
+
+ private boolean createSchema() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private boolean createTable() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private boolean deleteTable() {
+ try {
+ TableConfig tableConfig = JsonUtils.fileToObject(new
File(_tableConfigFileName), TableConfig.class);
+ ControllerTest.sendDeleteRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forTableDelete(tableConfig.getTableName()));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
Review comment:
change to error log
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##########
@@ -92,4 +101,40 @@ boolean runOp() {
}
return true;
}
+
+ private boolean createSchema() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
+ return false;
+ }
+ }
+
+ private boolean createTable() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
Review comment:
error log
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##########
@@ -45,6 +54,8 @@
private Op _op;
private String _tableConfigFileName;
+ private static final String TABLE_NAME = "tableName";
Review comment:
dont need this anymore
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##########
@@ -92,4 +101,40 @@ boolean runOp() {
}
return true;
}
+
+ private boolean createSchema() {
+ try {
+ ControllerTest.sendPostRequest(
+
ControllerRequestURLBuilder.baseUrl(CONTROLLER_URL).forSchemaCreate(),
+ FileUtils.readFileToString(new File(_schemaFileName)));
+ return true;
+ } catch (IOException e) {
+ System.out.println(e.getMessage());
Review comment:
Let us change this to an error log for now. We can then configure logs
appropriately to get whatever we want on the console.
Also, include the table config file path on all log messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
