[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6118: Implement off-heap bloom filter reader

fx19880617 commented on a change in pull request #6118: URL: https://github.com/apache/incubator-pinot/pull/6118#discussion_r501454793 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/BloomFilterConfig.java ## @@ -16,38 +16,26 @@ * specific language go

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6118: Implement off-heap bloom filter reader

fx19880617 commented on a change in pull request #6118: URL: https://github.com/apache/incubator-pinot/pull/6118#discussion_r501454478 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -294,14 +293,19 @@ private static void validateI

[GitHub] [incubator-pinot] Jackie-Jiang closed issue #6093: Use star-tree index when filteres not part of index match all rows of a segment

Jackie-Jiang closed issue #6093: URL: https://github.com/apache/incubator-pinot/issues/6093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch master updated: Enhance star-tree to skip matching-all predicate on non-star-tree dimension (#6109)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 81028ce Enhance star-tree to skip matc

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

Jackie-Jiang merged pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6118: Implement off-heap bloom filter reader

Jackie-Jiang opened a new pull request #6118: URL: https://github.com/apache/incubator-pinot/pull/6118 ## Description Add BloomFilterCreator and BloomFilterReader interface (similar to other indexes) Re-implemented `OnHeapGuavaBloomFilterCreator` and `OffHeapGuavaBloomFilterReader`

[incubator-pinot] branch offheap_bloom_filter created (now 979828b)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch offheap_bloom_filter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 979828b Implement off-heap bloom filter reader This branch includes the following new commit

[incubator-pinot] 01/01: Implement off-heap bloom filter reader

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch offheap_bloom_filter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 979828bfbaaeb1a9d4707b53541782fee0bb4eec Author: Xiaotian (Jackie) Jiang AuthorDate: Wed Oct 7 21

[incubator-pinot] branch enhance_star_tree updated (6519f22 -> 6f07d40)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch enhance_star_tree in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6519f22 Enhance star-tree to skip matching-all predicate on non-star-tree dimension add 1b

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

fx19880617 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501426164 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java ## @@ -267,19 +206,19 @@ private St

[GitHub] [incubator-pinot] yupeng9 commented on pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#issuecomment-705301336 @Jackie-Jiang Thanks for the suggestion. Made some changes to address your comments: - use `PartitionUpsetMetadataManager` directly by the call sites - changed th

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

Jackie-Jiang commented on a change in pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501411620 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java ## @@ -121,81 +117,23 @@ //

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

Jackie-Jiang commented on a change in pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501410938 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java ## @@ -121,81 +117,23 @@ //

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

Jackie-Jiang commented on a change in pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501410590 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java ## @@ -267,19 +206,19 @@ private

[incubator-pinot] branch test-swagger created (now da533a5)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch test-swagger in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at da533a5 Remove api support This branch includes the following new commits: new da533a5 Remove a

[incubator-pinot] 01/01: Remove api support

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch test-swagger in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit da533a5ccbfd56631dc5fd2f8249b4e5aef249df Author: Jack Li(Analytics Engineering) AuthorDate: Wed Oct 7 17:05

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6105: scalar functions for array

codecov-io edited a comment on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-704578112 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6105?src=pr&el=h1) Report > Merging [#6105](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6105: scalar functions for array

codecov-io edited a comment on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-704578112 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6105?src=pr&el=h1) Report > Merging [#6105](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6105: scalar functions for array

codecov-io edited a comment on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-704578112 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6105?src=pr&el=h1) Report > Merging [#6105](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] kishoreg merged pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

kishoreg merged pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

fx19880617 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501269268 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java ## @@ -121,81 +117,23 @@ // St

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501262602 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/TaskGeneratorUtils.java ## @@ -68,4 +73,30 @@

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501260008 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java ## @@ -31,13 +31,28 @@ public class

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501260008 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java ## @@ -31,13 +31,28 @@ public class

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501253784 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -66,42 +66,58 @@ public sta

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501258061 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java ## @@ -187,6 +203,38 @@ p

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501253784 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -66,42 +66,58 @@ public sta

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501253784 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -66,42 +66,58 @@ public sta

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501253784 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -66,42 +66,58 @@ public sta

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6094: Implement the segment merge task generator

snleee commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501251130 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SegmentMergeRollupMinionClusterIntegrationTest.java ## @@ -

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6105: scalar functions for array

codecov-io edited a comment on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-704578112 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6105?src=pr&el=h1) Report > Merging [#6105](https://codecov.io/gh/apache/incubator-pinot/pull

[incubator-pinot] branch master updated: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages (#6117)

This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 02dd3e2 Adding Tenants, Instances, T

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501223500 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertProcessorUtil.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501221581 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataPartitionManager.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501212455 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataTableManager.java ## @@ -0,0 +1,74 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

Jackie-Jiang commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501199958 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertProcessorUtil.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Ap

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

Jackie-Jiang commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501197850 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataPartitionManager.java ## @@ -0,0 +1,83 @@ +/** + * License

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

Jackie-Jiang commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501196582 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataPartitionManager.java ## @@ -0,0 +1,83 @@ +/** + * License

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

Jackie-Jiang commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501196009 ## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataTableManager.java ## @@ -0,0 +1,74 @@ +/** + * Licensed to

[incubator-pinot] branch master updated (8782e47 -> ac3f2af)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8782e47 Fixed indexing link (#6110) add ac3f2af FIX Homepage changelog link (#6116) No new revisions

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6116: FIX Homepage changelog link

Jackie-Jiang merged pull request #6116: URL: https://github.com/apache/incubator-pinot/pull/6116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6112: add max length support in schema builder

Jackie-Jiang commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r501192653 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] kishoreg commented on pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

kishoreg commented on pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117#issuecomment-705077171 Thanks, Verified that it works! This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6113: Adding the upsert support to real-time ingestion and query

codecov-io edited a comment on pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#issuecomment-704686373 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6113?src=pr&el=h1) Report > Merging [#6113](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] shahsank3t commented on pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

shahsank3t commented on pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117#issuecomment-705066450 @kishoreg Removed Segment Count tile.  --

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6105: scalar functions for array

npawar commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501151826 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] SandishKumarHN commented on a change in pull request #6105: scalar functions for array

SandishKumarHN commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501140856 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * License

[GitHub] [incubator-pinot] SandishKumarHN commented on a change in pull request #6105: scalar functions for array

SandishKumarHN commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501141163 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * License

[GitHub] [incubator-pinot] SandishKumarHN commented on a change in pull request #6105: scalar functions for array

SandishKumarHN commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501139219 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * License

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501128615 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -266,14 +291,59 @@ public

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6112: add max length support in schema builder

mayankshriv commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r501130574 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6105: scalar functions for array

npawar commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501129887 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] kishoreg commented on pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

kishoreg commented on pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117#issuecomment-705031759 I think we can remove number of the segments from the tiles. It takes up a lot of time for large clusters -

[GitHub] [incubator-pinot] npawar commented on pull request #6105: scalar functions for array

npawar commented on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-705030345 Please add some tests for ArrayFunctions in the InbuiltFunctionsTest (similar to those for ArithmeticFunctions, DateTimeFunctions and JsonFunctions)

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6105: scalar functions for array

npawar commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501118284 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] KKcorps commented on pull request #6105: scalar functions for array

KKcorps commented on pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-705018662 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6105: scalar functions for array

KKcorps commented on a change in pull request #6105: URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r501102662 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java ## @@ -0,0 +1,133 @@ +/** + * Licensed to th

[GitHub] [incubator-pinot] codecov-io commented on pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

codecov-io commented on pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117#issuecomment-704995920 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6117?src=pr&el=h1) Report > Merging [#6117](https://codecov.io/gh/apache/incubator-pinot/pull/6117?s

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #6117: Adding Tenants, Instances, Tables, Segments count tiles and their respective pages

shahsank3t opened a new pull request #6117: URL: https://github.com/apache/incubator-pinot/pull/6117 ## Description 1. Adding Tenants, Controllers, Brokers, Servers, Tables, Segments count on the homepage and made it clickable. ![image](https://user-images.githubusercontent.com/6761

[GitHub] [incubator-pinot] raphaelauv opened a new pull request #6116: FIX Homepage changelog link

raphaelauv opened a new pull request #6116: URL: https://github.com/apache/incubator-pinot/pull/6116 The current home page of the website is broken if you click on the changelog of the last released version This is an au

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

chenboat commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r500780538 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -266,14 +291,59 @@ public