Jackie-Jiang commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501196582
########## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertMetadataPartitionManager.java ########## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.upsert; + +import java.util.HashSet; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import javax.annotation.concurrent.ThreadSafe; +import org.apache.pinot.core.realtime.impl.ThreadSafeMutableRoaringBitmap; +import org.apache.pinot.spi.data.readers.PrimaryKey; + +/** + * Manages the upsert metadata per partition. This shall be accessed from UpsertMetadataTableManager. + */ +@ThreadSafe +class UpsertMetadataPartitionManager { + + private final int _partitionId; + + private final Map<PrimaryKey, RecordLocation> _primaryKeyIndex = new ConcurrentHashMap(); + // the mapping between the (sealed) segment and its validDocuments + private final Map<String, ThreadSafeMutableRoaringBitmap> _segmentToValidDocIndexMap = new ConcurrentHashMap(); + + UpsertMetadataPartitionManager(int partitionId) { + _partitionId = partitionId; + } + + synchronized void removeRecordLocation(PrimaryKey primaryKey) { + _primaryKeyIndex.remove(primaryKey); + } + + synchronized boolean containsKey(PrimaryKey primaryKey) { + return _primaryKeyIndex.containsKey(primaryKey); + } + + RecordLocation getRecordLocation(PrimaryKey primaryKey) { + return _primaryKeyIndex.get(primaryKey); + } + + synchronized void updateRecordLocation(PrimaryKey primaryKey, RecordLocation recordLocation) { + _primaryKeyIndex.put(primaryKey, recordLocation); + } + + synchronized ThreadSafeMutableRoaringBitmap getValidDocIndex(String segmentName) { + return _segmentToValidDocIndexMap.get(segmentName); + } + + synchronized void putUpsertMetadata(String segmentName, Map<PrimaryKey, RecordLocation> primaryKeyIndex, + ThreadSafeMutableRoaringBitmap validDocIndex) { + //TODO(upsert) do we need to make a backup before update? + _primaryKeyIndex.putAll(primaryKeyIndex); Review comment: If 2 segments are loaded at the same time, you need to do record by record modification instead of batching all the modifications then apply them all ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
